D9045: Better UI for the "Create a new vault" button

ivan added a comment. @ngraham I can not reproduce the text overflow bud you are getting. I'm not setting any size-related things, so the bug is probably in the upstream (libplasma or above) I've reverted the ToolButton change. I agree that systray applets should be unified - either all

D9045: Better UI for the "Create a new vault" button

ivan edited the summary of this revision. REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D9045 To: ivan, #plasma, cryptodude, ngraham Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9045: Better UI for the "Create a new vault" button

ivan updated this revision to Diff 23161. ivan added a comment. - Reverted the 'create a new vault button' to be a proper button REPOSITORY R845 Plasma Vault CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9045?vs=23116&id=23161 BRANCH master REVISION DETAIL https://phabricat

D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

ngraham added a comment. @broulik, any plans for this? REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D4614 To: broulik, #vdg, #plasma, aacid, dfaure Cc: ngraham, cfeck, fabianr, ltoscano, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-moham

D9040: Revert "[Lock Screen / Login] Add "reveal password button""

kigwana added a comment. We have several customer systems that have arcane password requirements and have so spill proof keyboards. Those keyboards are terrible and folks usually end up pounding the keyboard again. This feature saves a lot of aggravation with 1 character errors usually. Mayb

D9040: Revert "[Lock Screen / Login] Add "reveal password button""

davidedmundson added a comment. If the icon is not fixed in the login screen, I'm definitely pushing the SDDM side for 5.12. An invisible hit area is not usability. As for the lock screen: - the rationale for introducing was originally consistency, it isn't. - The virtual keyboa

D9053: Migrate powerdevil keyboard shortcuts

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Looking good! :) thanks REPOSITORY R122 Powerdevil BRANCH master REVISION DETAIL https://phabricator.kde.org/D9053 To: davidedmundson, #plasma, apol Cc: apol, plasma-devel, ZrenBot, pro

Upgrading my KDE version on my system

Hi, I have got a distro KDE  providing v5.8 . In order to have better control on the KDE system setted up in my machine I began to build KDE from sources . It looks nice since all my kde system seems being setted up in ~/kde-latest jail directory. Can I run a complete kde system like this an

D9055: systemsettings enhancement when used in a kiosk environment

sancelot added a comment. I was in branch 5.8 so, ok, I understand it may be have done. I will upgrade . REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D9055 To: sancelot, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, sancelot, ZrenBot, pro

D9045: Better UI for the "Create a new vault" button

ngraham requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D9045 To: ivan, #plasma, cryptodude, ngraham Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abe

D9045: Better UI for the "Create a new vault" button

ngraham added a comment. There's a visual glitch. The text escapes the boundaries of the button: F5518635: escaped.png I would still prefer this to always look like a button, like the Bluetooth widget. REPOSITORY R845 Plasma Vault REVISION D

D9040: Revert "[Lock Screen / Login] Add "reveal password button""

graesslin added a comment. In https://phabricator.kde.org/D9040#173465, @ngraham wrote: > On most touch platforms, only the last character in password prompts is revealed, one-at-a-time. It might make more sense to implement that than to keep the reveal button. On touch platforms

D9040: Revert "[Lock Screen / Login] Add "reveal password button""

ngraham added a comment. On most touch platforms, only the last character in password prompts is revealed, one-at-a-time. It might make more sense to implement that than to keep the reveal button. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.

D9040: Revert "[Lock Screen / Login] Add "reveal password button""

graesslin added a comment. I'm against reverting this. I think this is a very important feature for touch input and nowadays we support a touch keyboard directly in the login screen. Given that the reveal button is IMHO a must have feature. REPOSITORY R120 Plasma Workspace BRANCH master

D9055: systemsettings enhancement when used in a kiosk environment

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Latest master features the line: if (!entry->noDisplay() ) { //add entry which isn't in your diff, is this made against some old code? K

Re: contributing D0955

All worked fine. Will follow anything else up on phabricator. Thanks

contributing D0955

Hi, I hope have made no mistake : https://phabricator.kde.org/D9055 Regards, S.Ancelot

D9055: systemsettings enhancement when used in a kiosk environment

sancelot created this revision. sancelot added a reviewer: Plasma. sancelot added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When you defined a kiosk environment, disabling some modules to user, disabled module were always visible in menus. Ho

Re: Contributing to source code

Hi, thanks for looking into this. Please upload your patch to https://phabricator.kde.org See also https://community.kde.org/Get_Involved and more specifically https://community.kde.org/Get_Involved/development Cheers Kai Uwe

Contributing to source code

Hi, I have made some improvements  in systemsettings5, where can I propose my modifications ? Regards, S.Ancelot

Re: knowing if a module is restricted

I will try it. My aim is to improve systemsettings5 view, when modules have been restricted. because, altough modules are restricted and not available to user, there is always a category icon, and when clicking in it , you open a blank view. And each icon provide the list of restricted items.

Re: knowing if a module is restricted

Hi, KAuthorized::authorizeControlModule Pass it the full name of the desktop file (e.g. kcm_foo.desktop). There's also a function that filters a list of modules to check multiple at once. Cheers Kai Uwe

D9045: Better UI for the "Create a new vault" button

ngraham edited the summary of this revision. REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D9045 To: ivan, #plasma, cryptodude, ngraham Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

knowing if a module is restricted

 Hi, which function does permit to know if a module has been restricted in kdeglobals ? Regards, S.Ancelot

D8798: Add xf86-input-libinput support for X11 mouse backend.

jriddell added a comment. +1 to Pointer Accelaration REPOSITORY R119 Plasma Desktop BRANCH mouse REVISION DETAIL https://phabricator.kde.org/D8798 To: xuetianweng, ngraham, #plasma, jriddell Cc: jriddell, apol, rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreu

D8787: Fix PWD dialog

ngraham edited the summary of this revision. REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D8787 To: cryptodude, #plasma, ivan Cc: ngraham, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8798: Add xf86-input-libinput support for X11 mouse backend.

ngraham added a comment. Or maybe just, "Pointer Acceleration:"? REPOSITORY R119 Plasma Desktop BRANCH mouse REVISION DETAIL https://phabricator.kde.org/D8798 To: xuetianweng, ngraham, #plasma, jriddell Cc: jriddell, apol, rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-moha

D8798: Add xf86-input-libinput support for X11 mouse backend.

jriddell accepted this revision. jriddell added a comment. This revision is now accepted and ready to land. I'm sorry I indeed didn't have that package installed because I'm using HWE packages, I've installed it now and xinput shows my touchpad as using libinput. kcmshell5 mouse now show

D9053: Migrate powerdevil keyboard shortcuts

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Powerdevil "faked" that it's name was "kded5" presumably as a way to keep user's keyboard sho

D8798: Add xf86-input-libinput support for X11 mouse backend.

ngraham added a comment. On Ubuntu: sudo apt install xserver-xorg-input-libinput sudo apt remove xserver-xorg-input-mouse xserver-xorg-input-evdev xserver-xorg-input-[anything else] [reboot] Package names may be slightly different on non-Ubuntu distros. REPOSITORY R119

D8798: Add xf86-input-libinput support for X11 mouse backend.

jriddell added a comment. This is my output from xinput which suggests it's using evdev, how do I get it to use libinput? >xinput list-props 14 Device 'ImExPS/2 Generic Explorer Mouse': Device Enabled (140): 1 Coordinate Transformation Matrix (142): 1.0

D8827: experimental support for auto mnemonics

broulik added a comment. A shortcut is registered by the `Shortcut` item by doing QGuiApplicationPrivate::instance()->shortcutMap.addShortcut(this, shortcut.keySequence, context, *ctxMatcher()); `QShortcut` is in widgets and also another QObject. I don't see a way to do that using

D9050: [KRunner] Show configure button only if not forbidden by KIOSK restriction

This revision was automatically updated to reflect the committed changes. Closed by commit R120:85c2ef3b: [KRunner] Show configure button only if not forbidden by KIOSK restriction (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.o

D9050: [KRunner] Show configure button only if not forbidden by KIOSK restriction

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9050 To: broulik, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abet

D9050: [KRunner] Show configure button only if not forbidden by KIOSK restriction

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN Placed the following in kdeglobals: [KDE Control Module Restrictions] kcm_plasmasearch.desktop=false

Unwritten design policy Re: D9040: Revert "[Lock Screen / Login] Add "reveal password button""

Would it make sense to maybe write it down now? I wasn't aware of it and it's a good rule. It would be useful both for documentation and to get inspired when new policies are required. Aleix On Tue, Nov 28, 2017 at 9:49 PM, David Edmundson < nore...@phabricator.kde.org> wrote: > davidedmundson c

D9037: use desktop file actions instead of global shortcuts

mart marked 5 inline comments as done. mart added a comment. delaying the first show seems to fix the focus issue. a fixed timer of 100ms is of course not a solution but may give some insight in what the problem actually is (a 0 delay timer doesn't work either) REPOSITORY R120 Plasma Work

D9037: use desktop file actions instead of global shortcuts

mart updated this revision to Diff 23123. mart added a comment. - delay first show REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9037?vs=23095&id=23123 BRANCH phab/krunnerondemand REVISION DETAIL https://phabricator.kde.org/D9037 AFFECTED F

D8787: Fix PWD dialog

cryptodude edited the test plan for this revision. REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D8787 To: cryptodude, #plasma, ivan Cc: ngraham, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8787: Fix PWD dialog

cryptodude updated this revision to Diff 23122. REPOSITORY R845 Plasma Vault CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8787?vs=22636&id=23122 REVISION DETAIL https://phabricator.kde.org/D8787 AFFECTED FILES kded/CMakeLists.txt kded/service.cpp kded/ui/mountdialog.cpp

D9037: use desktop file actions instead of global shortcuts

mart added a comment. In https://phabricator.kde.org/D9037#173098, @broulik wrote: > Overall fine with me. > > What hapens to places like Plasma's context menu that show "Run command (Alt+F2)"? What shortcut will they show and do they still work? Same for typing on the desktop.

D9021: determine QQC2 version at build time

This revision was automatically updated to reflect the committed changes. Closed by commit R858:d0e3daafdbdd: determine QQC2 version at build time (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D9021?vs=23036&id=23120#toc REPOSITORY R858 Qt Quick Controls 2: Desktop

D8787: Fix PWD dialog

cryptodude added a comment. Welcome back :) > Replace the text in the 'error' label with 'Failed to open: %1' Ah, that is an improvement indeed. Will do. > Replace the two labels with a single one Let me explain why I separated them, then you can decide if it was a good cal

D8924: Move the KDE Polkit-Agent into ksmserver

davidedmundson planned changes to this revision. davidedmundson added a comment. Yeah, I like that too. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D8924 To: davidedmundson, #plasma Cc: graesslin, ngraham, apol, plasma-devel, ZrenBot, progwolff, lesliezha

D9033: man ioslave: asserts trying to display pam(8)

marten updated this revision to Diff 23118. marten added a comment. Used const where appropriate. Apologies for the lack of context in the diff - I hadn't realised until you pointed it out that Phabricator doesn't automatically provide context (unlike Reviewboard). Maybe there should be

D9033: man ioslave: asserts trying to display pam(8)

marten marked an inline comment as done. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D9033 To: marten, #plasma Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D9045: Better UI for the "Create a new vault" button

ivan retitled this revision from ""New vault" action is now a tool button" to "Better UI for the "Create a new vault" button". REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D9045 To: ivan, #plasma, cryptodude, ngraham Cc: plasma-devel, ZrenBot, progwolff, lesliezh

D9045: "New vault" action is now a tool button

ivan created this revision. ivan added reviewers: Plasma, cryptodude, ngraham. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The button to create a new vault now: - has an icon "list-add" - changed the button type

D8787: Fix PWD dialog

ivan added a comment. Almost mergeable - I just have a few nit-picks: - Replace the two labels with a single one "Please enter the password to open the \"%1\" vault" (this will also remove the need for the leading space) - Replace the text in the 'error' label with 'Failed to open: %1'