ivan added a comment.

  Almost mergeable - I just have a few nit-picks:
  
  - Replace the two labels with  a single one "Please enter the password to 
open the \"%1\" vault" (this will also remove the need for the leading space)
  - Replace the text in the 'error' label with 'Failed to open: %1'
  
  We should also add an 'in progress' state, but that can be a separate patch

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D8787

To: cryptodude, #plasma, ivan
Cc: ngraham, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Reply via email to