D8449: Have a default backend (if one available)

This revision was automatically updated to reflect the committed changes. Closed by commit R845:7f15ce922069: Have a default backend (if one available) (authored by cryptodude, committed by ivan). REPOSITORY R845 Plasma Vault CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8449?vs=213

D8449: Have a default backend (if one available)

ivan accepted this revision. This revision is now accepted and ready to land. REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D8449 To: cryptodude, ivan, #plasma Cc: nicolasfella, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, ab

D8449: Have a default backend (if one available)

ivan added a comment. I was on a vacation, sorry. I'll test everything today and merge it if I don't find a problem. I still don't like the UI change, but lets go with it. REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D8449 To: cryptodude, ivan, #plasma C

Advance Downtime Notification

Hi all, Over the past 24 hours we have received initial warning notifications that a disk in our bulk storage server has begun to show signs of failure. We have now begun the process of having this disk replaced, following which we will need to rebuild the RAID array. As a consequence of this at

D8924: Move the KDE Polkit-Agent into ksmserver

graesslin added a comment. I fail to see how option 3 would help. But I'm in favor of option 1. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D8924 To: davidedmundson, #plasma Cc: graesslin, ngraham, apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-

D8919: Add explicit AppMenu protocol

graesslin accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D8919 To: davidedmundson, #plasma, graessl

D6764: Add font size setting to the digital clock plasmoid

januz added a comment. In https://phabricator.kde.org/D6764#172831, @mmustac wrote: > I think this describes the main problem for most users (including me) very good: > KDE Forum: Padding in plasma panels Actually I posted t

D9040: Revert "[Lock Screen / Login] Add "reveal password button""

davidedmundson added a comment. Edit: There's also a TextInput.canRedo property I'm going to add that anyway. It will fix one of the two open bugs. @broulik does that change your opinion on this. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https:/

D9040: Revert "[Lock Screen / Login] Add "reveal password button""

davidedmundson added a comment. Sorry :( REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D9040 To: davidedmundson, broulik Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9040: Revert "[Lock Screen / Login] Add "reveal password button""

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Insert rolling eye emoji here. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D9040 To: davidedmundson, broulik Cc: broulik, plasma-dev

D9040: Revert "[Lock Screen / Login] Add "reveal password button""

davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Up till this commit we had an unwritten policy: If it's a shared password (wifi, printer, samba) we can reveal the password If it

D9037: use desktop file actions instead of global shortcuts

broulik added a comment. Overall fine with me. What hapens to places like Plasma's context menu that show "Run command (Alt+F2)"? What shortcut will they show and do they still work? Same for typing on the desktop. INLINE COMMENTS > main.cpp:60 > > +QCommandLineOption clipboardOp

D7629: Do not show reveal password button on login screen

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. We also have bug 387418. And we don't have kiosk restrictions in SDDM either. Given the rationale for introducing it was very thin, in the first place. I'm going to merg

D6764: Add font size setting to the digital clock plasmoid

ngraham added a comment. Exactly: the default size is too big. I think if we just make the default size smaller, the complaints will go away. REVISION DETAIL https://phabricator.kde.org/D6764 To: januz, #plasma, #vdg Cc: mmustac, IlyaBizyaev, davidedmundson, ngraham, Zren, mart, plasma-dev

D9021: determine QQC2 version at build time

apol accepted this revision. apol added a comment. Okay, maybe it's not important... INLINE COMMENTS > CMakeLists.txt:4 > set(KF5_VERSION "5.41.0") # handled by release scripts > -set(KF5_DEP_VERSION "5.40.0") # handled by release scripts > +set(KF5_DEP_VERSION "5.39.0") # handled by release

D9033: man ioslave: asserts trying to display pam(8)

apol added a comment. Lack of context in the patch makes it hard to review. INLINE COMMENTS > kio_man.cpp:570 > + > + QStringList entries = mandir.entryList(); > + if (entries.isEmpty()) mark `const`. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.

D9037: use desktop file actions instead of global shortcuts

apol added a comment. Looks cool! INLINE COMMENTS > main.cpp:94 > View view; > -view.setVisible(false); > +const QString query = parser.positionalArguments().isEmpty() ? QString() > : parser.positionalArguments().first(); > +if (parser.isSet(clipboardOption)) { You can do `

D7934: Add KCM for adjusting QtQuick Rendering in Plasma

davidedmundson marked an inline comment as done. davidedmundson added a comment. > expert settings that you shouldn't use like, ever I do want some people to use them, if I didn't, I wouldn't have written a KCM in the first place. and just make it a KCM you can launch from KRunner.

D9037: use desktop file actions instead of global shortcuts

davidedmundson added a comment. Needs the things you pointed out in the comment, but otherwise looks good. Can you confirm you can set shortcuts in systemsettings correctly? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9037 To: mart, #plasma Cc: davi

D9037: use desktop file actions instead of global shortcuts

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY - Don't autostart KRunner, use actions in the desktop file to define global shortcuts and actions - insta

D8924: Move the KDE Polkit-Agent into ksmserver

davidedmundson added a comment. > On X11 ksmserver, on Wayland KWin? In principle great. It was the other possible choice. But this spawns a window, generally kwin is bad at having it's own windows, so it might not be trivial. I certainly don't want to go down the route of kwin hol

D8641: FormLayout

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Please don't push new API 5 days before a release tagging. We'll still be able to make the Plasma 5.12 if we wait till Saturday. INLINE COMMENTS > FormLayout.qml:200-20

D8641: FormLayout

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in FormLayout.qml:152-153 > > why are we doing something different for width and height indeed the width should have the same logic, which now does,the width simply didn't trigger visible layout bugs REPOSITORY R169 Kirigami

D8641: FormLayout

mart updated this revision to Diff 23092. mart added a comment. - same logic for width REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8641?vs=23088&id=23092 BRANCH mart/formlayout REVISION DETAIL https://phabricator.kde.org/D8641 AFFECTED FILES ex

D8641: FormLayout

davidedmundson added inline comments. INLINE COMMENTS > mart wrote in FormLayout.qml:152-153 > I made now "prefer" preferredheight to implicitheight, but sometimes > layout.preferredheight is not set, and it needs to fallback to implicitheight > hor the layout will look completely broken > wh

D8641: FormLayout

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in FormLayout.qml:113 > Is this done? no, will do a related patch to breeze > davidedmundson wrote in FormLayout.qml:121 > I think you'll need to try again. > > Have you tested this code with a really really long label? a real

D8641: FormLayout

mart updated this revision to Diff 23088. mart added a comment. - just use item.Layout.preferredHeight - prefer Layout.preferredHeight to implicitHeight REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8641?vs=23075&id=23088 BRANCH mart/formlayout REVI

D9021: determine QQC2 version at build time

mart added a comment. In https://phabricator.kde.org/D9021#172905, @apol wrote: > In https://phabricator.kde.org/D9021#172842, @mart wrote: > > > could the ide always take info from a set theme, like the base "default" one somehow? > > > Well you are introducing some bit from a

D9033: man ioslave: asserts trying to display pam(8)

marten created this revision. marten added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY That page, and many others, links to another page with just a plain name: .so PAM.8 This is read by

D9030: Feature: New input methods

This revision was automatically updated to reflect the committed changes. Closed by commit R846:6f5cd3c9af5f: Feature: New input methods (authored by Aiix). REPOSITORY R846 Mycroft Plasma integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9030?vs=23077&id=23084 REVISION DETA

D8919: Add explicit AppMenu protocol

davidedmundson updated this revision to Diff 23083. davidedmundson added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. Add line in docs REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8919?vs=22890&id=23083 BRA

D9032: [ResultDelegate] Get rid of Globals.js

This revision was automatically updated to reflect the committed changes. Closed by commit R112:b17f3440465f: [ResultDelegate] Get rid of Globals.js (authored by broulik). REPOSITORY R112 Milou CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9032?vs=23080&id=23082 REVISION DETAIL h

D9032: [ResultDelegate] Get rid of Globals.js

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This file contains a couple of constants but isn't (and cannot be as it's using `units`) marked `pragma libr

D9032: [ResultDelegate] Get rid of Globals.js

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D9032 To: broulik, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9021: determine QQC2 version at build time

apol added a comment. In https://phabricator.kde.org/D9021#172842, @mart wrote: > could the ide always take info from a set theme, like the base "default" one somehow? Well you are introducing some bit from a different language, so parsers won't be able to process it ever. REPOS

D8733: DBus activate KActivityManagerd

This revision was automatically updated to reflect the committed changes. Closed by commit R161:d53f6181de63: DBus activate KActivityManagerd (authored by davidedmundson). REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8733?vs=22114&id=23078

D9030: Feature: New input methods

Aiix created this revision. Aiix added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Added feature new input methods which allows mycroft wakeword activation via the plasmoid when keyboard input is s

D8641: FormLayout

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > davidedmundson wrote in FormLayout.qml:113 > Flat mode: > > main page of current mouse KCM: > button order, icons. Is this done? > mart wrot

D8827: experimental support for auto mnemonics

hein added a comment. > yeah, it's many qobjects, but there aren't other ways to do shortcuts without it (the way to directly do shortcuts even in c++ it's completely private api) Not even event filtering or something? REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAI

D8641: FormLayout

hein accepted this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D8641 To: mart, #plasma, #kirigami, hein, davidedmundson Cc: broulik, colomar, ngraham, davidedmundson, plasma-devel, ngiannip, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abet

D8827: experimental support for auto mnemonics

mart added a comment. In https://phabricator.kde.org/D8827#172520, @hein wrote: > How heavy will be all these Shortcut instances? Is that a lot of QObjects? > > Otherwise it looks pretty good. yeah, it's many qobjects, but there aren't other ways to do shortcuts without it (th

D8641: FormLayout

mart added inline comments. INLINE COMMENTS > hein wrote in FormLayout.qml:66 > Should it be centralized or ...? I don't think so, reasons for switching to one or the other are different. this one is purely wether the contents fit or not, the global one for the app which is how many columns are

D8641: FormLayout

mart updated this revision to Diff 23075. mart added a comment. - hasOwnProperty REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8641?vs=23008&id=23075 BRANCH mart/formlayout REVISION DETAIL https://phabricator.kde.org/D8641 AFFECTED FILES examples

D8641: FormLayout

hein added inline comments. INLINE COMMENTS > mart wrote in FormLayout.qml:66 > yes, they are in some controls, independent from each other Should it be centralized or ...? > mart wrote in FormLayout.qml:114 > what's x in y? I meant the "in" operator, or alternatively object.hasOwnProperty("fo

Re: Request for discussion on mycroft plasmoid project path

On martedì 28 novembre 2017 10:11:08 CET Aditya Mehra wrote: > I understand there is "extra-gears" where i can do self releases and "plasma > addons", which i am keenly interested in for release for this plasmoid so I > would like to initiate a discussion on where this project should live and > wha

D9021: determine QQC2 version at build time

mart added a comment. In https://phabricator.kde.org/D9021#172748, @apol wrote: > Note this breaks integration in the IDE. > > Is it maybe something to discuss with upstream? could the ide always take info from a set theme, like the base "default" one somehow? REPOSITORY R8

Request for discussion on mycroft plasmoid project path

Hi Everyone, Some background to the discussion: Mycroft Plasmoid is a graphical user interface for Mycroft which is an open source community committed technology that ties natural language processing, text-to-speech, speech-to-text, and powerful APIs together to create a powerful experience all

D6764: Add font size setting to the digital clock plasmoid

mmustac added a comment. I think thisdescribes the main problem for most users (including me) very good: KDE Forum: Padding in plasma panels It look out of place when and jumps right into the eyes. I have three screens, the main scree