davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land.
Please don't push new API 5 days before a release tagging. We'll still be able to make the Plasma 5.12 if we wait till Saturday. INLINE COMMENTS > FormLayout.qml:200-203 > + Layout.alignment: root.wideMode > + ? (Qt.AlignRight | > (item.Kirigami.FormData.buddyFor.height > height * 2 ? Qt.AlignTop : > Qt.AlignVCenter)) > + : (Qt.AlignLeft | Qt.AlignBottom) > + verticalAlignment: root.wideMode ? Text.AlignVCenter : > Text.AlignBottom you should be able to just Layout.fillHeight: true then do all this in the verticalAlignment REPOSITORY R169 Kirigami BRANCH mart/formlayout REVISION DETAIL https://phabricator.kde.org/D8641 To: mart, #plasma, #kirigami, hein, davidedmundson Cc: broulik, colomar, ngraham, davidedmundson, plasma-devel, ngiannip, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, hein
