broulik added a comment.
Overall fine with me.
What hapens to places like Plasma's context menu that show "Run command
(Alt+F2)"? What shortcut will they show and do they still work? Same for typing
on the desktop.
INLINE COMMENTS
> main.cpp:60
>
> + QCommandLineOption clipboardOption(QStringList() << QStringLiteral("c")
> << QStringLiteral("clipboard"),
> + i18n("Use the clipboard contents as
> query for KRunner"));
Use initializer list `{QStringLiteral("c"), QStringLiteral("clipboard")}`
> main.cpp:66
> + parser.addOption(daemonOption);
> + parser.addPositionalArgument("query",
> QCoreApplication::translate("query", "The query to run, only used if -c is
> not provided"));
> parser.addHelpOption();
Why no `i18n()` here?
Also, `QStringLiteral("query")`
> main.cpp:110
> +
> + if (parser.isSet(clipboardOption)) {
> + view.displayWithClipboardContents();
This stuffin the lambda is somewhat duplicated, isn't it?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D9037
To: mart, #plasma
Cc: broulik, apol, davidedmundson, plasma-devel, ZrenBot, progwolff,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
