D7590: Don't search for and link to libcln when using libqalculate>=2.0

This revision was automatically updated to reflect the committed changes. Closed by commit R120:b915e5b4bab1: Don't search for and link to libcln when using libqalculate>=2.0 (authored by arojas). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7590?vs

D7590: Don't search for and link to libcln when using libqalculate>=2.0

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7590 To: arojas, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abett

D3805: Per-activity favorites (Final, again?)

hein added a comment. I've tested now and things look good, the multi-activity-migration thing is solved. Here's my remaining concerns: - No Kickoff support: Personally I think we should actually migrate all applets at once. One of the main motivations for this is so users no longer une

D7567: Support edit and appstream actions also for application search results

mak added inline comments. INLINE COMMENTS > hein wrote in actionlist.cpp:380 > That code wasn't touched during this refactoring, so this is immaterial to > the review. Please inform Aleix Pol about it. I know, that's why I didn't flag this as change request (just a general observation). REPO

D7587: kfileaudiopreview: don't autoplay media files by default

graesslin added a comment. obviously +1 from me, but as I'm biased towards security I want someone else to accept it REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D7587 To: elvisangelaccio, #plasma Cc: graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali

D7567: Support edit and appstream actions also for application search results

hein added inline comments. INLINE COMMENTS > mak wrote in actionlist.cpp:380 > This will not work, because the component-ID can be an arbitrary reverse-DNS > string identifying the application, and doesn't have to resemble the > .desktop-entry-id at all. If that happens, it's purely accidental

D7567: Support edit and appstream actions also for application search results

mak added inline comments. INLINE COMMENTS > actionlist.cpp:380 > + > +const auto components = > appstreamPool->componentsById(service->desktopEntryName()+QLatin1String(".desktop")); > +for(const auto &component: components) { This will not work, because the component-ID can be an arbit

D7590: Don't search for and link to libcln when using libqalculate>=2.0

arojas created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Plasma doesn't use any cln code directly, only via libqalculate. In version 2.0, libqalculate dropped cln in favor of gmp, so the cln dependenc

D3805: Per-activity favorites (Final, again?)

hein added a comment. > We can schedule Kickoff for the +1 release - Kicker/Dash would be a nice test for the whole thing. Sounds reasonable, but are you sure you can handle migration then, too? E.g. on a patch with this system migration would have already run for two applets and then o

D7587: kfileaudiopreview: don't autoplay media files by default

elvisangelaccio created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Not only it's annoying, but it's also a potential security risk (basically, a variant of [1]). [1]: https://scarybeastsecurity.b

D7567: Support edit and appstream actions also for application search results

hein updated this revision to Diff 18889. hein added a comment. Put more code into actionlist REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7567?vs=18887&id=18889 BRANCH arcpatch-D7567 REVISION DETAIL https://phabricator.kde.org/D7567 AFFECTE

D3805: Per-activity favorites (Final, again?)

hein added a comment. Possibly, will test over night (I missed the update). REVISION DETAIL https://phabricator.kde.org/D3805 To: ivan, mart, hein Cc: Zren, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7567: Support edit and appstream actions also for application search results

hein updated this revision to Diff 18887. hein added a comment. Add missing manageApplication handler to the runner matches. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7567?vs=18827&id=18887 BRANCH arcpatch-D7567 REVISION DETAIL https://pha

D7567: Support edit and appstream actions also for application search results

hein added reviewers: broulik, davidedmundson. hein added a comment. Stupid arc somehow didn't set reviewers. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7567 To: hein, #plasma, broulik, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-

D7586: [Folder View] Delay delegate creation until plasmoid expands

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. > The listingCompleted property could be moved into the FolderModel I think it's better to have seperate signals for start and stop here to reinforce the transactional nature ... if this wa

D3805: Per-activity favorites (Final, again?)

mart added a comment. a periodic check on this.. ping? can be merged now? REVISION DETAIL https://phabricator.kde.org/D3805 To: ivan, mart, hein Cc: Zren, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7586: [Folder View] Delay delegate creation until plasmoid expands

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY In Plasma expanded representation is created only on demand but since Folder View is used as containment and already massively complex, all of

D6027: Use existing parseInt function

sebas requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D6027 To: davidedmundson, #plasma, sebas Cc: sebas, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D7584: [Icon Item] Don't needlessly unset imagePath

broulik created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY We'll eventually delete the Plasma::Svg anyway if we failed to find an appropriate icon. Just need to make sure we don

Minutes Monday Plasma Hangout

Plasmalicious meeting minutes! -- sebas http://www.kde.org | http://vizZzion.orgPlasma Team meeting, 28-8-2017 Present: notmart, Sho, bshah, kbroulik, sebas SHo: * [TM] Refactored libtm+applet to produce and use non-absolute launcher URLs when dealing in KServices with a valid menuId ** Means

[Breeze] [Bug 384076] Some buttons don't have text and proper styling

https://bugs.kde.org/show_bug.cgi?id=384076 Sebastian Kügler changed: What|Removed |Added Assignee|plasma-devel@kde.org|plasma-b...@kde.org -- You are receiving th

D7538: [MPris Engine] Don't construct QDBusObjectPath in Metadata update

This revision was automatically updated to reflect the committed changes. Closed by commit R120:1a95e7c7e146: [MPris Engine] Don't construct QDBusObjectPath in Metadata update (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7538?

D7538: [MPris Engine] Don't construct QDBusObjectPath in Metadata update

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7538 To: broulik, #plasma, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mar

D7583: [Kicker] Add "Edit application" and "Manage application" entry to service runner results

hein added a comment. I actually set you as reviewer on that one via arc, but somehow it dropped all subscribers, fuck. Sorry about the unnecessary work. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7583 To: broulik, #plasma, hein Cc: plasma-devel, ZrenBot

D7583: [Kicker] Add "Edit application" and "Manage application" entry to service runner results

hein added a comment. Duplicate of https://phabricator.kde.org/D7567. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7583 To: broulik, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, luk

D7583: [Kicker] Add "Edit application" and "Manage application" entry to service runner results

broulik updated this revision to Diff 18880. broulik added a comment. Slight cleanup REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7583?vs=18879&id=18880 REVISION DETAIL https://phabricator.kde.org/D7583 AFFECTED FILES applets/kicker/plugin/ac

D7583: [Kicker] Add "Edit application" and "Manage application" entry to service runner results

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This makes application search results consistent with applications in the menu. The ifdef'd AppStream logic is completely moved into the

D7555: Add basic example for adjusting column width draggable handle

hein updated this revision to Diff 18878. hein added a comment. Fix email (still in the cool four-letter club with notmart) REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7555?vs=18809&id=18878 BRANCH master REVISION DETAIL https://phabricator.kde.or

D7555: Add basic example for adjusting column width draggable handle

mart accepted this revision. mart added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > dragPageWidth.qml:2 > +/* > + * Copyright 2017 Eike Hein > + * Email REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D7555 T

D7582: [FrameSvgItem] Create margins/fixedMargins object on demand

broulik created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY On my machine I end up creating 490 margins and 490 fixed margin objects. After this change I only create 171 margin ob

D7562: Understand KAStats-style applications: launcher URLs.

This revision was automatically updated to reflect the committed changes. Closed by commit R119:01095327f014: Understand KAStats-style applications: launcher URLs. (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7562?vs=18875&id=18876

D7562: Understand KAStats-style applications: launcher URLs.

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH understandApplicationsURLs REVISION DETAIL https://phabricator.kde.org/D7562 To: hein, #plasma, broulik, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai,

D7562: Understand KAStats-style applications: launcher URLs.

hein updated this revision to Diff 18875. hein added a comment. Cleanup repeated code. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7562?vs=18819&id=18875 BRANCH understandApplicationsURLs REVISION DETAIL https://phabricator.kde.org/D7562 AF

D7562: Understand KAStats-style applications: launcher URLs.

hein added a comment. Yeah, probably a good idea (the code it replaces was also copy-pasted three times though :). REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7562 To: hein, #plasma, broulik, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai

D6881: [Folder View] Implement Select All shortcut

This revision was automatically updated to reflect the committed changes. Closed by commit R119:ab3ede4f79a0: [Folder View] Implement Select All shortcut (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6881?vs=18684&id=18874 REVIS

D7561: Avoid absolute paths to .desktop files in launcher URLs.

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Thanks a lot! :) Verified that https://phabricator.kde.org/D7203 works well with it, even deleted the user-local desktop file at runtime and it immediately picked that up and didn't

D7562: Understand KAStats-style applications: launcher URLs.

broulik added a comment. This seems to have been copy-pasted three times - can we put that into a separate method? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7562 To: hein, #plasma, broulik, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai