broulik created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY On my machine I end up creating 490 margins and 490 fixed margin objects. After this change I only create 171 margin objects and 20 fixed margin objects. TEST PLAN RAM consumption negligible and 0.1ms time saved but especially given fixed margins is hardly used, imho shouldn't create a ton of objects that are unused. Changing themes seems fine. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7582 AFFECTED FILES src/declarativeimports/core/framesvgitem.cpp src/declarativeimports/core/framesvgitem.h To: broulik, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
