mak added inline comments.

INLINE COMMENTS

> actionlist.cpp:380
> +
> +    const auto components = 
> appstreamPool->componentsById(service->desktopEntryName()+QLatin1String(".desktop"));
> +    for(const auto &component: components) {

This will not work, because the component-ID can be an arbitrary reverse-DNS 
string identifying the application, and doesn't have to resemble the 
.desktop-entry-id at all. If that happens, it's purely accidental.

I was planning to add a `componentsByLaunchable(TYPE, STR)` method to AppStream 
anyway, I could probably do that for the next release of AS.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7567

To: hein, #plasma, broulik, davidedmundson
Cc: mak, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

Reply via email to