D6186: Implement software cursor in OpenGL backend

2017-06-25 Thread Oleg Chernovskiy
This revision was automatically updated to reflect the committed changes. Kanedias marked 2 inline comments as done. Closed by commit R108:247ef43f683b: Implement software cursor in OpenGL backend (authored by Kanedias). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.

D6186: Implement software cursor in OpenGL backend

2017-06-25 Thread Martin Flöser
graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D6186 To: Kanedias, graesslin, davidedmundson Cc: aacid, luebking, plasma-devel, kwin, #kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hard

D6186: Implement software cursor in OpenGL backend

2017-06-25 Thread Martin Flöser
graesslin added inline comments. INLINE COMMENTS > Kanedias wrote in scene_opengl.h:141 > Should we heal other methods suffering from this? I can prepare such patch. No, we don't change the existing code. Only new code gets override. REPOSITORY R108 KWin REVISION DETAIL https://phabricator

D6186: Implement software cursor in OpenGL backend

2017-06-25 Thread Oleg Chernovskiy
Kanedias marked 2 inline comments as done. Kanedias added inline comments. INLINE COMMENTS > graesslin wrote in scene_opengl.cpp:682-685 > Instead of adding an empty method you could make it pure virtual That moment when I noticed we have no SceneOpenGL instantiations. Tx! > graesslin wrote in

D6186: Implement software cursor in OpenGL backend

2017-06-25 Thread Oleg Chernovskiy
Kanedias updated this revision to Diff 15860. Kanedias marked an inline comment as done. Kanedias added a comment. Review comments fixes REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6186?vs=1&id=15860 REVISION DETAIL https://phabricator.kde.org/D6186

D6186: Implement software cursor in OpenGL backend

2017-06-25 Thread Martin Flöser
graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. Looks good to me. Just a minor comment regarding where to put the new virtual method. Setting to reject changes as requested by Albert :-) INLINE COMMENTS > scene_opengl.cp

D6186: Implement software cursor in OpenGL backend

2017-06-25 Thread Albert Astals Cid
aacid added a comment. If this indeed needs fixing, can someone please mark it as "request changes" so it doesn't show up in the list of "patches that have been accepted but have not been commited"? REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D6186 To: Kanedias, gr

D1230: GBM remote access support for KWin

2017-06-25 Thread Albert Astals Cid
aacid added a comment. If this indeed needs fixing, can someone please mark it as "request changes" so it doesn't show up in the list of "patches that have been accepted but have not been commited"? REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D1230 To: Kanedias, gr

D6373: [libksysguard] Fix text color in memory html view

2017-06-25 Thread Anthony Fieroni
anthonyfieroni added a comment. In https://phabricator.kde.org/D6373#119286, @davidedmundson wrote: > It's "fixed" if you're running breeze dark, but surely this is broken of you're running breeze normal? Ah, you are right. Do you have any suggestion, i want to shoot myself any t

D6373: [libksysguard] Fix text color in memory html view

2017-06-25 Thread David Edmundson
davidedmundson added a comment. It's "fixed" if you're running breeze dark, but surely this is broken of you're running breeze normal? REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D6373 To: anthonyfieroni, #plasma, davidedmundson, graesslin Cc: plasma-de