Kanedias marked 2 inline comments as done. Kanedias added inline comments. INLINE COMMENTS
> graesslin wrote in scene_opengl.cpp:682-685 > Instead of adding an empty method you could make it pure virtual That moment when I noticed we have no SceneOpenGL instantiations. Tx! > graesslin wrote in scene_opengl.h:141 > you don't need to readd the virtual keyword when using override. Should we heal other methods suffering from this? I can prepare such patch. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D6186 To: Kanedias, graesslin, davidedmundson Cc: aacid, luebking, plasma-devel, kwin, #kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
