graesslin added inline comments.
INLINE COMMENTS
> kwaylandintegration.cpp:42
>
> +static bool s_useQt58Workaround;
> +
I don't really like the name of the variable as it's going to be the future way
and not "a workaround" once we depend on Qt 5.8 or later.
REPOSITORY
R135 Integration for
graesslin added a comment.
Please note that the code you wrote will give you an incorrect PID for all
XWayland windows. Instead of going through the ClientConnection I suggest to
use KWin::Toplevel::pid(). That one returns the correct pid for all X windows.
But it would crash for Wayland win
graesslin added a comment.
Commit embargo till 5.10 is branched.
INLINE COMMENTS
> waylandtasksmodel.cpp:340
> } else if (role == AppPid) {
> -// FIXME Implement.
> +return window->pid();
> }
You are aware that pid is not always correct? Any process started by KWin
graesslin added a comment.
This has commit embargo till 5.10 is branched.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D5756
To: hein, #plasma, sebas, graesslin
Cc: kwin, plasma-devel, #kwin, ZrenBot, spstarr, progwolff, lesliezhai,
ali-mohamed, hardening, jensreuter
graesslin requested changes to this revision.
graesslin added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> abstract_client.cpp:708
> updateAppId();
> -w->setSkipTaskbar(skipTaskbar());
> +w->setPid(surface()->client()->processId());
> +surface
hein created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: KWin, kwin.
REVISION SUMMARY
Depends on https://phabricator.kde.org/D5747.
REPOSITORY
R108 KWin
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5756
AFFECTED F
hein added a dependent revision: D5756: Set pid on the ClientConnection backing
the PlasmaWindow surface..
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D5747
To: sebas, #plasma, hein, graesslin
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolf
hein created this revision.
Restricted Application added a project: Plasma.
REVISION SUMMARY
Depends on https://phabricator.kde.org/D5747.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5755
AFFECTED FILES
libtaskmanager/waylandtasksmodel.
hein added a dependent revision: D5755: Expose PlasmaWindow::pid through
WaylandTasksModel..
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D5747
To: sebas, #plasma, hein, graesslin
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff,
lesliezhai
davidedmundson edited the summary of this revision.
davidedmundson edited the test plan for this revision.
REPOSITORY
R135 Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D5746
To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, spstarr, progwolff, le
davidedmundson added a comment.
> I assume this are adjustments for Qt 5.8 or later. How does this work with
Qt 5.7? I fear if we change like this we are going to break Qt 5.7.
Yes, in combination with the other two. There's some notes on
https://phabricator.kde.org/T6064.
It's a valid
https://bugs.kde.org/show_bug.cgi?id=379593
Jonathan Marten changed:
What|Removed |Added
Status|CONFIRMED |RESOLVED
Resolution|---
graesslin added a comment.
I assume this are adjustments for Qt 5.8 or later. How does this work with Qt
5.7? I fear if we change like this we are going to break Qt 5.7.
INLINE COMMENTS
> view.cpp:217
> {
> +qWarning()< // QXcbWindow overwrites the state in its show event. There ar
graesslin requested changes to this revision.
graesslin added a comment.
This revision now requires changes to proceed.
Please also extend the autotests/client/test_wayland_windowmanagement.cpp
INLINE COMMENTS
> plasmawindowmanagement.h:385
> + * @returns The process id this window belong
mart created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
as showEvent is too soon, create the plasma surface on
:Expose event, and reposition the surface
TEST PLAN
krunner is correctly positioned wi
davidedmundson added inline comments.
INLINE COMMENTS
> plasma-window-management.xml:267
> +
> +
> +
uint is a native type:
https://wayland.freedesktop.org/docs/html/ch04.html#sect-Protocol-Wire-Format
you don't need to do an implicit cast
REPOSITORY
R127 KWayland
REVISION
sebas created this revision.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
This patch adds a pid event to the plasma window management protocol. It
allows the compositor to tell allow a
mart updated this revision to Diff 14247.
mart added a comment.
- don't return false
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5745?vs=14246&id=14247
BRANCH
phab/recreateshell
REVISION DETAIL
https://phabricator.kde.org/D5745
mart updated this revision to Diff 14246.
mart added a comment.
- check null region
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5745?vs=14241&id=14246
BRANCH
phab/recreateshell
REVISION DETAIL
https://phabricator.kde.org/D5745
A
davidedmundson added inline comments.
INLINE COMMENTS
> dialog.cpp:1123
> if (event->type() == QEvent::Expose) {
> -// FIXME TODO: We can remove this once we depend on Qt 5.6.1+.
> -// See: https://bugreports.qt.io/browse/QTBUG-26978
> -KWindowSystem::setState(winId()
davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
We need to setup our attachments when the wl_surface is created.
This gets recreated when a window is hidden and shown.
QPlatform
mart created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
every time the window gets shown the wayland surfaces
get created, when hidden, they get destroyed
showevent is too e
https://bugs.kde.org/show_bug.cgi?id=379593
--- Comment #2 from Jonathan Marten ---
CI (comment #1) should have been fixed by commit 6be8b06a to kio-extras.
I'll commit a further fix for the version numbering: to avoid introducing an
extra dependency it should be possible to just use the PROJEC
markg created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Fix deprecation warnings.
TEST PLAN
autotest
REPOSITORY
R135 Integration for Qt applications in Plasma
BRANCH
fix_deprecations (branched
markg created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Override consistency
TEST PLAN
autotest
REPOSITORY
R135 Integration for Qt applications in Plasma
BRANCH
cpp11_override (branched from m
elvisangelaccio added a comment.
Does this patch fix https://bugs.kde.org/show_bug.cgi?id=362135 ?
REPOSITORY
R135 Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D5538
To: eshalygin, #plasma, markg, graesslin
Cc: elvisangelaccio, graesslin, ltoscano
eshalygin added a comment.
Thanks a lot!
REPOSITORY
R135 Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D5538
To: eshalygin, #plasma, markg, graesslin
Cc: graesslin, ltoscano, broulik, markg, plasma-devel, ZrenBot, spstarr,
progwolff, lesliezhai, a
This revision was automatically updated to reflect the committed changes.
Closed by commit R135:7a7dfffba98d: Implement QPlatformTheme::fileIconPixmap()
to make QFileIconProvider work. (authored by eshalygin, committed by markg).
REPOSITORY
R135 Integration for Qt applications in Plasma
CHANGE
markg accepted this revision.
markg added a comment.
Oke by me. Commit lands in a few minutes.
REPOSITORY
R135 Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D5538
To: eshalygin, #plasma, markg, graesslin
Cc: graesslin, ltoscano, broulik, markg, pla
https://bugs.kde.org/show_bug.cgi?id=379593
Harald Sitter changed:
What|Removed |Added
Status|UNCONFIRMED |CONFIRMED
CC|
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:fe231be5e2d4: Keep all touchpad QActions in the main
thread (authored by davidedmundson).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5733?vs=14219&id=14228
REVISI
https://bugs.kde.org/show_bug.cgi?id=379602
Elvis Angelaccio changed:
What|Removed |Added
Product|dolphin |kio-extras
CC|
https://bugs.kde.org/show_bug.cgi?id=339456
Elvis Angelaccio changed:
What|Removed |Added
Resolution|--- |FIXED
CC|
eshalygin updated this revision to Diff 14227.
eshalygin marked 3 inline comments as done.
eshalygin added a comment.
Address review comments.
REPOSITORY
R135 Integration for Qt applications in Plasma
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5538?vs=13677&id=14227
REVISION
graesslin requested changes to this revision.
graesslin added a comment.
This revision now requires changes to proceed.
Please fix the style issues.
INLINE COMMENTS
> kdeplatformtheme.cpp:124-125
> +#if QT_VERSION < QT_VERSION_CHECK(5, 8, 0)
> +QPixmap KdePlatformTheme::fileIconPixmap(const Q
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5733
To: davidedmundson, #plasma, graesslin
Cc: graesslin, plasma-devel, kwin, #kwin, ZrenBot, spstarr, progwolff,
lesliezhai
ltoscano set the repository for this revision to R135 Integration for Qt
applications in Plasma.
REPOSITORY
R135 Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D5538
To: eshalygin, #plasma, markg
Cc: ltoscano, broulik, markg, plasma-devel, ZrenBot, sps
ltoscano added a comment.
In the future, please use arcanist to submit patches (or at least specify the
repository).
REVISION DETAIL
https://phabricator.kde.org/D5538
To: eshalygin, #plasma, markg
Cc: ltoscano, broulik, markg, plasma-devel, ZrenBot, spstarr, progwolff,
lesliezhai, ali-moh
davidedmundson updated this revision to Diff 14219.
davidedmundson added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
Split to new function
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5733?vs=14215&id=14219
BRANCH
master
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:32939fa7b522: Fix regression for timestamp handling for
Xwayland windows (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5731?vs=14210&id=14218
graesslin added inline comments.
INLINE COMMENTS
> input.cpp:1759
> + // steal touchpad shortcuts
> +QAction *touchpadToggleAction = new QAction(this);
> +QAction *touchpadOnAction = new QAction(this);
I think this should be in the if (con) branch.
Given that the method is already q
41 matches
Mail list logo
