graesslin added a comment.

  Commit embargo till 5.10 is branched.

INLINE COMMENTS

> waylandtasksmodel.cpp:340
>      } else if (role == AppPid) {
> -        // FIXME Implement.
> +        return window->pid();
>      }

You are aware that pid is not always correct? Any process started by KWin 
shares KWin pid. Given that one need to be careful outside of KWin. You should 
not base any decisions on it and especially not try to close apps based on pid.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D5755

To: hein, #plasma, davidedmundson, sebas
Cc: graesslin, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

Reply via email to