graesslin added inline comments.

INLINE COMMENTS

> input.cpp:1759
> +     // steal touchpad shortcuts
> +    QAction *touchpadToggleAction = new QAction(this);
> +    QAction *touchpadOnAction = new QAction(this);

I think this should be in the if (con) branch.

Given that the method is already quite long maybe move to a dedicated method.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D5733

To: davidedmundson, #plasma
Cc: graesslin, plasma-devel, kwin, #kwin, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, lukas

Reply via email to