D4915: [Folder View] Fix action button hover and pressed state

anthonyfieroni added a comment. F2799403: Screenshot_20170313_074102.png This broke hover in FolderView at all (Qt 5.8.0, Kf5.32, Plasma 5.9.3 + this patch) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4915 To: bro

D5029: Use seccomp for implementing a sandbox for kscreenlocker_greet

graesslin added inline comments. INLINE COMMENTS > broulik wrote in seccomp_test.cpp:95 > It might fail because KDE CI infrastructure does a redirect we don't follow > instead of failing because we actually restricted it. I'm pretty sure that it would fail properly for the IP variants in such a

D4945: QuickShare: Fix attempt for Plasma freezing when trying to paste large images to imgur

yuenlim abandoned this revision. yuenlim added a comment. Fixed in https://phabricator.kde.org/D5013 REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D4945 To: yuenlim, #plasma, apol Cc: mart, broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreut

D5029: Use seccomp for implementing a sandbox for kscreenlocker_greet

broulik added inline comments. INLINE COMMENTS > graesslin wrote in seccomp_test.cpp:95 > The point of this test is that the call doesn't work. See line 101. The > seccomp filter disallows network access. No matter whether I use > FollowRedirectsAttribute or not: kde.org will never see the requ

D5013: Truncate url string in KIO::job description to avoid freezing up plasma notification

This revision was automatically updated to reflect the committed changes. Closed by commit R241:f65946ece03c: Handle/truncate url display string assigned to job description. Prevents large… (authored by Lim Yuen Hoe ). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.or

D5029: Use seccomp for implementing a sandbox for kscreenlocker_greet

graesslin added inline comments. INLINE COMMENTS > broulik wrote in seccomp_test.cpp:95 > set `QNetworkRequest::FollowRedirectsAttribute` or else Ben will get angry The point of this test is that the call doesn't work. See line 101. The seccomp filter disallows network access. No matter whether

D5029: Use seccomp for implementing a sandbox for kscreenlocker_greet

broulik added a comment. Cool! INLINE COMMENTS > seccomp_test.cpp:95 > +QFETCH(QString, url); > +QNetworkRequest request(url); > +auto reply = manager.get(request); set `QNetworkRequest::FollowRedirectsAttribute` or else Ben will get angry > greeterapp.cpp:148 > +return

D5029: Use seccomp for implementing a sandbox for kscreenlocker_greet

graesslin added dependencies: D4997: Support for long running kcheckpass supporting multiple authentications, D4806: [greeter] Send the auth result through the server instead return value. REVISION DETAIL https://phabricator.kde.org/D5029 To: graesslin, #plasma Cc: plasma-devel, progwolff, le

D4997: Support for long running kcheckpass supporting multiple authentications

graesslin added a dependent revision: D5029: Use seccomp for implementing a sandbox for kscreenlocker_greet. REVISION DETAIL https://phabricator.kde.org/D4997 To: graesslin, #plasma Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4806: [greeter] Send the auth result through the server instead return value

graesslin added a dependent revision: D5029: Use seccomp for implementing a sandbox for kscreenlocker_greet. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D4806 To: graesslin, #plasma Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D5029: Use seccomp for implementing a sandbox for kscreenlocker_greet

graesslin created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This change introduces a new optional dependency on libseccomp. Libseccomp allows to forbid syscalls. With that we can constrain the user

D5013: Truncate url string in KIO::job description to avoid freezing up plasma notification

dfaure added a comment. Ship it ;) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D5013 To: yuenlim, #plasma, dfaure Cc: dfaure, plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5013: Truncate url string in KIO::job description to avoid freezing up plasma notification

yuenlim updated this revision to Diff 12411. yuenlim added a comment. Got it! REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5013?vs=12403&id=12411 REVISION DETAIL https://phabricator.kde.org/D5013 AFFECTED FILES src/core/job.cpp To: yuenlim, #plasma, df

D5013: Truncate url string in KIO::job description to avoid freezing up plasma notification

dfaure added a comment. Yes; looks much nicer, doesn't it? INLINE COMMENTS > job_p.h:76 > Job *q_ptr; > +static const int DescriptionUrlMaxLength = 100; > This can now be moved to the helper function. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D5013 To:

D3805: Per-activity favorites (Final, again?)

ivan updated this revision to Diff 12409. ivan retitled this revision from "Per-activity favorites (Final?)" to "Per-activity favorites (Final, again?)". ivan edited the test plan for this revision. ivan added a comment. **requires kactivities-stats master** CHANGES SINCE LAST UPDATE https:

D3531: Drop remote ioslave, which is now in KIO 5.32

elvisangelaccio retitled this revision from "Drop remote ioslave, will be in KIO 5.32" to "Drop remote ioslave, which is now in KIO 5.32". elvisangelaccio edited the summary of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3531 To: elvisangelac

D5025: Do not use fixed steps when scrolling on battery icon

fvogt added a comment. Arc seems to have selected my local branch as target branch for some reason, it should be "master" instead, obviously REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5025 To: fvogt, #plasma Cc: plasma-devel, progwolff, lesliezhai, ali

D5025: Do not use fixed steps when scrolling on battery icon

fvogt created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY This makes it possible to have some more fine-grained control over the screen brightness with scroll devices that support it, like touchpads or trackpoints. TEST PLAN Tested with touchpad, trackp

D5024: Applet: Add spacing to context menu button + same size for volume indicator

drosca added a comment. F2793543: Screenshot_20170312_091343.png REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D5024 To: drosca, #plasma Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D5024: Applet: Add spacing to context menu button + same size for volume indicator

drosca created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Add small spacing to context menu button icon to make it look like other ToolButtons. Also use small icon size for volume indicator instead of