broulik added a comment.

  Cool!

INLINE COMMENTS

> seccomp_test.cpp:95
> +    QFETCH(QString, url);
> +    QNetworkRequest request(url);
> +    auto reply = manager.get(request);

set `QNetworkRequest::FollowRedirectsAttribute` or else Ben will get angry

> greeterapp.cpp:148
> +        return new Authenticator(Authenticator::AuthenticationMode::Delayed, 
> this);
> +    }
> +#endif

Might lead to an unreachable code warning?

REVISION DETAIL
  https://phabricator.kde.org/D5029

To: graesslin, #plasma
Cc: broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

Reply via email to