graesslin added inline comments. INLINE COMMENTS
> broulik wrote in seccomp_test.cpp:95 > set `QNetworkRequest::FollowRedirectsAttribute` or else Ben will get angry The point of this test is that the call doesn't work. See line 101. The seccomp filter disallows network access. No matter whether I use FollowRedirectsAttribute or not: kde.org will never see the request. And if not and Ben gets angry: even better, than we have a human auto test ;-) > broulik wrote in greeterapp.cpp:148 > Might lead to an unreachable code warning? why should it? The code looks quite reachable to me. If kcheckpass is setuid it uses the code from line 151. REVISION DETAIL https://phabricator.kde.org/D5029 To: graesslin, #plasma Cc: broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
