[Differential] [Request, 14 lines] D4833: Only activate kded Appmenu signals if menus are in the window decoration

davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The Appmenu applet doesn't use the AppMenu module, and it interferes with the applet. TEST PLAN Set menus to in decoration Presse

Re: Phabricator Project Organisation - Plasma

On Wed, Feb 1, 2017 at 6:59 PM, Ben Cooksley wrote: > On Wed, Feb 1, 2017 at 3:35 AM, Marco Martin wrote: >> On Sat, Jan 28, 2017 at 8:51 PM, Ben Cooksley wrote: >>> The easiest one from my perspective is to classify the Plasma: >>> Workspaces project as the "Release" project for Plasma (to matc

[kio-extras] [Bug 376344] cant write to smb shares which has write access

https://bugs.kde.org/show_bug.cgi?id=376344 Diego D changed: What|Removed |Added CC||di...@daroch.com --- Comment #2 from Diego D --- Sam

[Differential] [Request, 27 lines] D4832: Open the correct submenu in kwin menu when activating the Appmenu with a shortcut

davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Export actionForId as a method in menuImporter IDs are used in the low level API which the appmenu kded module wants to use direc

[Differential] [Request, 54 lines] D4831: Add new component for the greyed out labels in Item Delegates.

davidedmundson created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Plasma code is full of Label {opacity: 0.6}. We shouldn't be hardcoding style into a UI, especially with magic n

[Differential] [Closed] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

This revision was automatically updated to reflect the committed changes. Closed by commit R115:f063ff829928: [Applet] Context Menu per device/stream to offer additional functionality (authored by subdiff). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabrica

[Maniphest] [Edited] T5412: Improve Plasma PA usability

subdiff edited the task description. TASK DETAIL https://phabricator.kde.org/T5412 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: subdiff Cc: Zren, broulik, #vdg, plasma-devel, #plasma, subdiff, drosca, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

[Differential] [Commented On] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

subdiff added a comment. Since it looks ok for @drosca and me I'll commit it for now. Maybe we can fix your issue afterwards, or maybe you need to update something else to current master head (compiling via kdesrc-build is of course the most secure way of doing it). REPOSITORY R115 Plasma

[Differential] [Commented On] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

Zren added a comment. Oh crap. I just realized the stringlist => string error caused the svg not to load at all. Which means it wouldn't detect the margins from the svg. Essentially causing it to not add any "padding". If I copy "use anchors instead of fillHeight …"

[Differential] [Commented On] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

subdiff added a comment. In https://phabricator.kde.org/D4751#90695, @Zren wrote: > Ah! Sorry bout that, `/usr/lib/x86_64-linux-gnu/qt5/qml/QtQuick/Controls/Styles/Plasma/ToolButtonStyle.qml` is different from what it shows in git. > > I copied the git source to that file, and while

[Differential] [Commented On] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

Zren added a comment. Ah! Sorry bout that, `/usr/lib/x86_64-linux-gnu/qt5/qml/QtQuick/Controls/Styles/Plasma/ToolButtonStyle.qml` is different from what it shows in git. I copied the git source to that file, and while there was a bit of complaining about the stringlist => string bit, it

[Differential] [Accepted] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

drosca accepted this revision. drosca added a comment. This revision is now accepted and ready to land. Looks fine now. We should add more actions later as for streams there is just single action "mute" in menu. @Zren You need to use latest plasma-framework as there are changes in ToolBu

[Differential] [Commented On] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

Zren added a comment. I did, there wasn't any change from when I tested it with `Layout.maximumHeight`, because there's padding around the icon. Huh, I didn't post a screenshot, here: F2657863: 2017-02-27___14-51-23.png https://github.com/KDE/

[Differential] [Commented On] D3484: Center systemmonitor window properly on multi-screen setup

aacid added a comment. So we should remove the setGeometry call altogether then? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3484 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: valeriymalov, #plasma_workspaces, mart

[Differential] [Commented On] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

subdiff added a comment. In https://phabricator.kde.org/D4751#90677, @Zren wrote: > I mentioned earlier: > > > Using Layout.maximumHeight: parent.height on the ToolButton will make it 18px tall, but will also make the icon tiny by default (because it keeps the padding). We can bypass

[Differential] [Updated, 99 lines] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

subdiff updated this revision to Diff 11917. subdiff marked 2 inline comments as done. REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4751?vs=11914&id=11917 REVISION DETAIL https://phabricator.kde.org/D4751 AFFECTED FILES applet/content

[Differential] [Updated, 28 lines] D4821: Implement manual focus on click

fvogt updated this revision to Diff 11916. fvogt added a comment. Handle the case better when the currently focused window vanishes REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4821?vs=11898&id=11916 BRANCH Plasma/5.8 REVISION DETAIL https://p

Re: Merging strings

Unfortunately, not sure what to do with this, one string is a prefix for the spin box, and the other is the suffix. See plasma-desktop/kcms/activities/PrivacyTab.cpp:215 What does the UI look like if it is set to a space or even better an empty string? Cheers, Ivan

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 83 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/83/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 27 Feb 2017 18:43:26 + Build duration: 27 min CHANGE SET Revision 04c922dac118f0c58d361f5475

[Differential] [Commented On] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

Zren added a comment. I mentioned earlier: > Using Layout.maximumHeight: parent.height on the ToolButton will make it 18px tall, but will also make the icon tiny by default (because it keeps the padding). We can bypass this by anchoring a child IconItem. You need to anchor an IconIt

[Differential] [Commented On] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

drosca added inline comments. INLINE COMMENTS > ListItemBase.qml:98 > > -PlasmaExtras.Heading { > -id :textLabel > -Layout.fillWidth: true > -level: 5 > -opacity: 0.6 > -wrapMode:

[Differential] [Commented On] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

subdiff added a comment. In https://phabricator.kde.org/D4751#89462, @Zren wrote: > ... Looks quite complicated in the end. I would like to avoid that. Can you test my current work around? It just uses the slider height for the ToolButton size. Works quite well on my system and m

[Differential] [Updated, 95 lines] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

subdiff updated this revision to Diff 11914. subdiff marked 15 inline comments as done. subdiff added a comment. After https://phabricator.kde.org/D4827 has landed, I'm finally able to update this Diff without crying into my pillow every evening (Yeah, maybe I'm exaggerating, but the former T

Re: Merging strings

Kristóf Kiszel ha scritto: > Hello, > > in the kde-workspace/kcm_activities5.po there is a message which isn't > translatable to Hungarian in itself, the message #28. If I translate it to a > space, it will look silly on the GUI, but if it could be merged with the > message #27 to "for %1 month" /

[Differential] [Closed] D4491: Let make taskmanager tooltip readable again

anthonyfieroni closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4491 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: anthonyfieroni, #plasma:_design, #plasma, hein, subdiff Cc: jsalatas, markg, broulik, su

[Differential] [Commented On] D4821: Implement manual focus on click

fvogt added a comment. In https://phabricator.kde.org/D4821#90657, @graesslin wrote: > Just as an fyi: in the build tree there is a test app which does the complete locking without the need for restart the session. Would that really work for changes in x11locker.cpp as well? it's

[Differential] [Commented On] D4821: Implement manual focus on click

graesslin added a comment. Just as an fyi: in the build tree there is a test app which does the complete locking without the need for restart the session. Overall I think that the problem might also be in the greeter. On Wayland we have the same issue, which could indicate a problem in t

[Differential] [Abandoned] D4797: [ToolButtonStyle] Use pure colors and no frame as background in flat mode

subdiff abandoned this revision. subdiff added a comment. Not anymore relevant thanks to https://phabricator.kde.org/D4827. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4797 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpre

[Differential] [Closed] D4827: possibility to use a fallback chain as prefix

This revision was automatically updated to reflect the committed changes. Closed by commit R242:916bcbf6c0ac: possibility to use a fallback chain as prefix (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4827?vs=11912&id=1

[Differential] [Abandoned] D4827: possibility to use a fallback chain as prefix

mart abandoned this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4827 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, davidedmundson, #plasma Cc: davidedmundson, broulik, plasma-devel, #framework

[Differential] [Updated, 67 lines] D4827: possibility to use a fallback chain as prefix

mart updated this revision to Diff 11912. mart added a comment. - use m_prefixes.last() REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4827?vs=11910&id=11912 BRANCH phab/framesvgFallback REVISION DETAIL https://phabricator.kde.org/D

[Differential] [Commented On] D4821: Implement manual focus on click

fvogt added a comment. This is weird: While the fix works absolutely fine (and reliably) for me on my primary user account, it does not have any effect for a different user around and @broulik Even weirder: I cannot reproduce the original bug in any of my VMs using multihead QXL...

[Differential] [Commented On] D4827: possibility to use a fallback chain as prefix

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in framesvgitem.cpp:571-574 > this !found is a behavioural change on the existing code. > > Why are we adding it? before it did set the elementprefix on the framesvg regardless it was present or not, so this is done in order pr

[Differential] [Requested Changes] D4827: possibility to use a fallback chain as prefix

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > framesvgitem.cpp:571-574 > +if (!found) { > +qWarning() << "The image" << m_frameSvg->imagePath() << "doesn't > contain any of the

[Differential] [Accepted] D4827: possibility to use a fallback chain as prefix

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. note there is a minor API break for any JS code that does if (prefix === "someValue") but I've checked and no-one does...(and it would be a bit of a weird thing to

[Differential] [Request, 33 lines] D4830: Adjust plasma-desktop to the new fallback prefixes

davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Grepped code for repaintNeeded on prefixes and adjusted as appropriately to match https://phabricator.kde.org/D4827 TEST PLAN Boot

[Differential] [Updated, 66 lines] D4827: possibility to use a fallback chain as prefix

mart updated this revision to Diff 11910. mart added a comment. - logic all in applyPrefixes() REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4827?vs=11904&id=11910 BRANCH phab/framesvgFallback REVISION DETAIL https://phabricator.kd

[Differential] [Commented On] D4827: possibility to use a fallback chain as prefix

mart added a comment. In https://phabricator.kde.org/D4827#90608, @davidedmundson wrote: > Either: > > a QML client could just do > prefix: frame.hasElementPrefix("toolbutton-pressed") ? "toolbutton-pressed" : "pressed" > > > > or this doesn't

[Differential] [Commented On] D4827: possibility to use a fallback chain as prefix

davidedmundson added a comment. Either: a QML client could just do prefix: frame.hasElementPrefix("toolbutton-pressed") ? "toolbutton-pressed" : "pressed" or this doesn't work It's the same thing both are just using for m_frameSvg->hasElementPrefi

[Differential] [Updated] D4827: possibility to use a fallback chain as prefix

mart marked an inline comment as done. mart added a comment. In https://phabricator.kde.org/D4827#90599, @davidedmundson wrote: > > [15:20] ‎<‎notmart‎>‎ if the svg doesn't exists, it falls back to the breeze one > > ‎[15:20] ‎<‎notmart‎>‎ then all hasElementPrefix would check if said

[Differential] [Commented On] D4827: possibility to use a fallback chain as prefix

davidedmundson added a comment. > [15:20] ‎<‎notmart‎>‎ if the svg doesn't exists, it falls back to the breeze one > ‎[15:20] ‎<‎notmart‎>‎ then all hasElementPrefix would check if said prefix exists in the breeze theme That's exactly what this code is doing, just in a much more compli

[Differential] [Commented On] D4827: possibility to use a fallback chain as prefix

mart added a comment. F2657134: Spectacle.X22789.png REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4827 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc:

[Differential] [Changed Subscribers] D4827: possibility to use a fallback chain as prefix

broulik added inline comments. INLINE COMMENTS > framesvgitem.cpp:287 > +m_frameSvg->setElementPrefix(prefix); > +break; > +} Maybe print a warning if none found? Or how did the old code behave where we would always call this no matter if we had it? > framesvgit

[Differential] [Request, 58 lines] D4827: possibility to use a fallback chain as prefix

mart created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY if a framesvgitem has an array as prefix, like FrameSvg { prefix: ["toolbutton-hover", "hover"] } it will use

[Differential] [Accepted] D4821: Implement manual focus on click

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R133 KScreenLocker BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D4821 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: fvogt, graesslin, brou

[Differential] [Updated] D4821: Implement manual focus on click

broulik edited reviewers, added: Plasma; removed: plasma-devel. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D4821 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: fvogt, graesslin, broulik, #plasma Cc: plasma-devel, progwolff

[Differential] [Request, 24 lines] D4821: Implement manual focus on click

fvogt created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY Currently only the first created screenlock window gets focus. On clicks, no focus events are sent, which makes it impossible to input passwords. This patch now makes it possible to focus to a diffe

[Differential] [Commented On] D4550: Task Manager: Make the icon size configurable for task buttons in a vertical task manager

ppalaga added a comment. In https://phabricator.kde.org/D4550#90464, @hein wrote: > Looks good! Thanks. What is the next step, actually? Is there more feedback to be expected here or somewhere else? REVISION DETAIL https://phabricator.kde.org/D4550 EMAIL PREFERENCES https://

[Differential] [Accepted] D4762: [SliderStyle] Allow providing a "hint-handle-size" element

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4762 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, #vdg, mart Cc: pl

[Differential] [Commented On] D4797: [ToolButtonStyle] Use pure colors and no frame as background in flat mode

mart added a comment. In https://phabricator.kde.org/D4797#90144, @broulik wrote: > > So changing only the theme would mean to change the svg of `ButtonStyle`, which is not desirable. > > Then we need to introduce new elements in `widgets/button.svg` or a new `widget/toolbutton.svg`

[Differential] [Requested Changes] D4797: [ToolButtonStyle] Use pure colors and no frame as background in flat mode

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. in general, this gives me the idea that it may be a good idea to try to expand framesvgitem api to have things like FrameSvgItem { prefix: ["toolbutton-normal", "normal"

[Differential] [Commented On] D4797: [ToolButtonStyle] Use pure colors and no frame as background in flat mode

mart added a comment. In https://phabricator.kde.org/D4797#90142, @subdiff wrote: > In https://phabricator.kde.org/D4797#90126, @broulik wrote: > > > Design looks ok but still you can't change `ToolButtonStyle`, instead, the Breeze Plasma theme needs to be changed. > > > Sorry,

[kio-extras] [Bug 376344] cant write to smb shares which has write access

https://bugs.kde.org/show_bug.cgi?id=376344 Hariec changed: What|Removed |Added CC||hari...@gmail.com --- Comment #1 from Hariec --- Abso

[Differential] [Commented On] D4689: IconItem: Add roundToIconSize property

drosca added inline comments. INLINE COMMENTS > sebas wrote in iconitem.cpp:313 > Changing roundToIconSize may change the size of the icon, so should we > trigger size changes (paintedWidth / paintedHeight / boundingRect likely? > Perhaps others.) and re-rendering here as well? Right now, judgi

[Differential] [Updated, 68 lines] D4689: IconItem: Add roundToIconSize property

drosca updated this revision to Diff 11897. drosca added a comment. Rename getter Emit paintedSizeChanged + schedulePixmapUpdate REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4689?vs=11845&id=11897 BRANCH arcpatch-D4689 REVISION DE

[Differential] [Commented On] D4550: Task Manager: Make the icon size configurable for task buttons in a vertical task manager

hein added a comment. Looks good! REVISION DETAIL https://phabricator.kde.org/D4550 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ppalaga, davidedmundson, hein, broulik Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, seb

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 639 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/639/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 27 Feb 2017 12:39:39 + Build duration: 33 min CHANGE SET Revision 14ed8ceb62376fd321b4b9eb245bb7ab0676

[Differential] [Commented On] D4792: [Kicker] Property for hiding app categories in RootModel

hein added a comment. I totally get your argument, but this two-steps-forward-one-step-back code is still so ugly - we need some sort of new approach to composability here. It's more work but may lead us into a better direction long-term. QML like this would be nice: FooModel {

[Differential] [Closed] D4817: [Kickoff] Increase opacity for item description

This revision was automatically updated to reflect the committed changes. Closed by commit R119:14ed8ceb6237: [Kickoff] Increase opacity for item description (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4817?vs=11882&id=11894 R

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 638 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/638/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 27 Feb 2017 11:59:21 + Build duration: 21 min CHANGE SET Revision c88e4bff746c72d96d1bd69b49e0d83e5cea

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 82 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/82/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 27 Feb 2017 11:57:41 + Build duration: 22 min CHANGE SET Revision c88e4bff746c72d96d1bd69b49

[Differential] [Closed] D4819: Make the hover state optional.

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d1463b3fca5a: Make the hover state optional. (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4819?vs=11884&id=11888 REVISION DETAIL htt

[Differential] [Closed] D4820: Add an option to limit the number of text lines in task buttons.

This revision was automatically updated to reflect the committed changes. Closed by commit R119:0a83f161140b: Add an option to limit the number of text lines in task buttons. (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4820?vs=118

[Differential] [Closed] D4818: Make the hover state optional.

This revision was automatically updated to reflect the committed changes. Closed by commit R119:c88e4bff746c: Make the hover state optional. (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4818?vs=11883&id=11887 REVISION DETAIL htt

[Differential] [Commented On] D4818: Make the hover state optional.

hein added a comment. @Mark: I respect that point of view, but there's also some value to reducing the patch delta between us and downstreams. I sometimes see distributons write (and rewrite, and rewrite, and rewrite) and carry patches to do things like this for years, and they sometimes get

[Differential] [Accepted] D4819: Make the hover state optional.

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.9 REVISION DETAIL https://phabricator.kde.org/D4819 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, #plasma, mart Cc: pl

[Differential] [Accepted] D4818: Make the hover state optional.

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.9 REVISION DETAIL https://phabricator.kde.org/D4818 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, #plasma, mart Cc: ma

[Differential] [Accepted] D4820: Add an option to limit the number of text lines in task buttons.

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.9 REVISION DETAIL https://phabricator.kde.org/D4820 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, #plasma, m

[Differential] [Updated, 5 lines] D4820: Add an option to limit the number of text lines in task buttons.

hein updated this revision to Diff 11886. hein added a comment. Fix copy paste error. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4820?vs=11885&id=11886 BRANCH Plasma/5.9 REVISION DETAIL https://phabricator.kde.org/D4820 AFFECTED FILES ap

[Differential] [Commented On] D4818: Make the hover state optional.

markg added a comment. I really doubt the usefulness in supporting this "feature". It smalls like something one distribution apparently wants, but the vast majority is fine with having the hover effect there. In fact, they might even consider it a bug - i would - if it doesn't change on hov

[Differential] [Changed Subscribers] D4820: Add an option to limit the number of text lines in task buttons.

davidedmundson added inline comments. INLINE COMMENTS > main.xml:102-103 > + The maximum number of text lines to show in a task button. 0 > means no limit. > + 0 > + 1 > + you can't set the min as 1 if the default is 0, you'll break config saving REPOSITORY R119 Plasma Des

[Differential] [Request, 6 lines] D4820: Add an option to limit the number of text lines in task buttons.

hein created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY This is desired by a downstream who always wants a single line of text. This should go into the 5.9 branch to allow them to ship 5.9. REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.9 REVISI

[Differential] [Request, 7 lines] D4819: Make the hover state optional.

hein created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY This is desired by a downstream distro which doesn't want hover effects in Task Manager. This also adds back a small tweak to support themes that don't ship a "hover" prefix in tasks.svgz that s

[Differential] [Request, 8 lines] D4818: Make the hover state optional.

hein created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY This is desired by a downstream distro which doesn't want hover effects in Folder View, but can't remove the graphics from the theme without negatively impacting other UI. It should go into the

Minutes Monday Plasma Meeting

Voila! -- sebas http://www.kde.org | http://vizZzion.orgPlasma Meeting minutes 27-02-2017 Present: romangg, notmart, Sho_, bshah, kbroulik, sebas romangg: * more KDE SoK work -> problems with reaching out to Martin because of tearing problems most probably coming from KWayland directly, but mo

[Differential] [Accepted] D4817: [Kickoff] Increase opacity for item description

sebas accepted this revision. sebas added a comment. This revision is now accepted and ready to land. 0.6 is used consistently, dunno why not here. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4817 EMAIL PREFERENCES https://phabricator.kde.org/settings/pa

[Differential] [Commented On] D4792: [Kicker] Property for hiding app categories in RootModel

subdiff added a comment. In https://phabricator.kde.org/D4792#90384, @hein wrote: > I'm not sure I like it. Maybe it's better to expose more of the individual models in the plugin so you can instanciate them directly? Well, you can already use most of the indivdiual models, for ex

[Differential] [Request, 2 lines] D4817: [Kickoff] Increase opacity for item description

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This makes text more readable while still not drawing too much attention to it. TEST PLAN Before (Light) F2655430: Screenshot_20170227_11

[Differential] [Commented On] D4792: [Kicker] Property for hiding app categories in RootModel

hein added a comment. I'm not sure I like it. Maybe it's better to expose more of the individual models in the plugin so you can instanciate them directly? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4792 EMAIL PREFERENCES https://phabricator.kde.org/se

[Differential] [Closed] D4737: [Icon Applet] Reject unacceptable drags

This revision was automatically updated to reflect the committed changes. Closed by commit R120:2c286ee8d27e: [Icon Applet] Reject unacceptable drags (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4737?vs=11668&id=11881 REVISIO

[Differential] [Updated] D4765: Make DesktopIcon aware of iamgeproviders and embedded ressources

bsonnemann added a reviewer: mart. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D4765 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bsonnemann, mart Cc: plasma-devel, apol

[Differential] [Commented On] D4491: Let make taskmanager tooltip readable again

subdiff added a comment. In https://phabricator.kde.org/D4491#90362, @anthonyfieroni wrote: > At least i plan to commit it from tomorrow release, so title 1 line or 2 lines ? After the pic

[Differential] [Updated, 8 lines] D4712: Ungrab mouse on menu close

anthonyfieroni updated this revision to Diff 11880. anthonyfieroni added a comment. To commit it later today ? REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4712?vs=11601&id=11880 REVISION DETAIL https://phabricator.kde.org/D4712 AFFECTED FILE