drosca added inline comments. INLINE COMMENTS
> sebas wrote in iconitem.cpp:313 > Changing roundToIconSize may change the size of the icon, so should we > trigger size changes (paintedWidth / paintedHeight / boundingRect likely? > Perhaps others.) and re-rendering here as well? Right now, judging from the > code, changing this property mid-flight is broken. We may even have to go as > far as loading a new pixmap (in loadPixmap() from a quick glance). > > Please also add unit tests for the effects on the iconitem's size properties. The only property that should change is paintedWidth/paintedHeight. > sebas wrote in iconitem.h:147 > bool roundToIconSize() const; > > we generally don't use "is" in new code where we can avoid it, and the ing > makes this even more inconsistent. I'd much prefer the above suggestion. > > Please also add api docs, at least for new code. The property is documented, I think there's no point in documenting the getters/setters as you can't use them from QML anyway. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4689 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, #plasma, sebas Cc: sebas, mart, davidedmundson, plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol
