davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> framesvgitem.cpp:571-574
> + if (!found) {
> + qWarning() << "The image" << m_frameSvg->imagePath() << "doesn't
> contain any of the prefixes" << m_prefixes;
> + m_frameSvg->setElementPrefix(QString());
> + }
this !found is a behavioural change on the existing code.
Why are we adding it?
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4827
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mart, #plasma, davidedmundson
Cc: davidedmundson, broulik, plasma-devel, #frameworks, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol
