[Differential] [Commented On] D3931: [Plasma folderview] Replace "Up" button with "Back" button in listview mode

chinmoyr added a comment. Push and pop methods were not updating the property might be they were working on another copy of "history". Due to this I used "history=history" so as to update it explicitly. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3931 E

Jenkins-kde-ci: plasma-desktop Plasma-5.8 stable-kf5-qt5 » Linux,gcc - Build # 85 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/85/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 09 Jan 2017 07:30:35 + Build duration: 2 min 17 sec CHANGE SET Revision d2fde361d3c8fb40fb6c1

[Differential] [Closed] D3302: [Task Manager] Indicate applications playing audio

This revision was automatically updated to reflect the committed changes. Closed by commit R119:89e61df4e936: [Task Manager] Indicate applications playing audio (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3302?vs=9891&id=9892

[Differential] [Updated, 122 lines] D3302: [Task Manager] Indicate applications playing audio

broulik updated this revision to Diff 9891. broulik added a comment. - Rebased on master with new tooltip design REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3302?vs=9750&id=9891 REVISION DETAIL https://phabricator.kde.org/D3302 AFFECTED FILES

[Differential] [Commented On] D3992: Sync kicker tooltip icon to config setting

hein added a comment. Let's try but see https://bugs.kde.org/show_bug.cgi?id=368912#c3 for context REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D3992 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: david

[Differential] [Requested Changes To] D3931: [Plasma folderview] Replace "Up" button with "Back" button in listview mode

hein requested changes to this revision. hein added a comment. This revision now requires changes to proceed. - Leave FolderModel::up unchanged - There's no need for a FolderModel::back, it just duplicates setUrl - I don't understand the need for updateHistory, please explain REPOSITORY

[Differential] [Accepted] D4033: Return valid string value for DescriptionRole in all models

hein accepted this revision. hein added a reviewer: hein. hein added a comment. This revision is now accepted and ready to land. Not a big fan of adding implement-role-to-match-type clutter, usually go with ===/!== checks in QML instead, but it's a toss up I guess. REPOSITORY R119 Plasma De

[Differential] [Commented On] D3805: Per-activity favorites (WIP)

hein added a comment. Yeah! Sorry, it wasn't specifically aimed at you or just this review. REVISION DETAIL https://phabricator.kde.org/D3805 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ivan, mart, hein Cc: plasma-devel, lesliezhai, ali-mohamed, jen

[Differential] [Commented On] D3085: Use DBusMenu if available

davidedmundson added a comment. > Dunno about the applet. The applet requires it. Dynamic bookmarks just don't work otherwise. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D3085 EMAIL PREFERENCES https://phabricator.kde.org/

[Differential] [Closed] D3914: Rename expander icon tooltip to "close popup" to close the popup

This revision was automatically updated to reflect the committed changes. Closed by commit R120:04ed182cf10a: Rename expander icon tooltip to "close popup" to close the popup (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

[Differential] [Request, 39 lines] D4036: When updating another user's avatar don't save icon into our home

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY We want to save the face using AccountsService, but for backwards compatibility we also save

[Differential] [Commented On] D4034: Show descriptive text when changing containment plugins

davidedmundson added a comment. Screenshot after changing plugin type F1968769: Spectacle.C16867.png restoring previous value restores contents REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4034 EMAIL PREFEREN

[Differential] [Request, 30 lines] D4034: Show descriptive text when changing containment plugins

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When one changes containment plugin, the rest of the configuration options don't apply or in

[Differential] [Request, 4 lines] D4033: Return valid string value for DescriptionRole in all models

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY A qml binding converting an empty QVariant to a string value will result in a warning: Unab

[Differential] [Accepted] D4028: Sort out compile warnings on unused vars

markg accepted this revision. markg added a reviewer: markg. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D4028 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Accepted] D4031: warning on unused var

markg accepted this revision. markg added a reviewer: markg. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D4031 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Accepted] D4030: Remove shell's copy of PlasmaQuick headers

markg accepted this revision. markg added a comment. This revision is now accepted and ready to land. Ahh, now it's gone. You're doing things in little pieces? hehe. Ship it. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4030 EMAIL PREFERENCES htt

[Differential] [Requested Changes To] D4030: Remove shell's copy of PlasmaQuick headers

markg requested changes to this revision. markg added a reviewer: markg. markg added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > containmentconfigview.h:56 > > +void setContainment(Plasma::Containment* containment); > + I think you forgot to remove thi

[Differential] [Updated, 370 lines] D4030: Remove shell's copy of PlasmaQuick headers

davidedmundson updated this revision to Diff 9883. davidedmundson added a comment. remove irrelevant bit of diff meant for another commit REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4030?vs=9882&id=9883 REVISION DETAIL https://phabricator.kde

[Differential] [Updated, 372 lines] D4030: Remove shell's copy of PlasmaQuick headers

davidedmundson updated this revision to Diff 9882. davidedmundson added a comment. fixup phab REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4030?vs=9880&id=9882 REVISION DETAIL https://phabricator.kde.org/D4030 AFFECTED FILES shell/containme

[Differential] [Request, 1 line] D4031: warning on unused var

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN Compile and grep REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabr

[Differential] [Request, 386 lines] D4030: Remove shell's copy of PlasmaQuick headers

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY It's exported and we're including the include path in our cmake so we had two paths to the sa

[Differential] [Accepted] D4029: Remove private include of PlasmaQuick

markg accepted this revision. markg added a reviewer: markg. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D4029 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Request, 234 lines] D4029: Remove private include of PlasmaQuick

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY It's been exported for ages And these versions can lag behind causing all sorts of problems

[Differential] [Request, 4 lines] D4028: Sort out compile warnings on unused vars

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN Compiles REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.k

[Differential] [Closed] D4010: Don't register ConfigModel twice

This revision was automatically updated to reflect the committed changes. Closed by commit R242:dcd81c6be85f: Don't register ConfigModel twice (authored by davidedmundson). REPOSITORY R242 Plasma Frameworks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4010?vs=9837&id=9876 REVISION

[Differential] [Request, 50 lines] D4024: [System Tray] Trigger context menu on press

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R120 Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Everywhere else context menus are trig

[Differential] [Closed] D4019: [ToolTipDialog] Use KWindowSystem::isPlatformX11() which is cached

This revision was automatically updated to reflect the committed changes. Closed by commit R242:a0119858e400: [ToolTipDialog] Use KWindowSystem::isPlatformX11() which is cached (authored by broulik). REPOSITORY R242 Plasma Frameworks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D401

[Differential] [Closed] D3971: RFC: Run first action on Shift+Return

This revision was automatically updated to reflect the committed changes. Closed by commit R112:c5216d347163: Run first action on Shift+Return (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3971?vs=9727&id=9864#toc REPOSITORY R112 Milou CHANGES SINCE LAST UPDATE

[Powerdevil] [Bug 343962] Add option to disable Backlight OSD

https://bugs.kde.org/show_bug.cgi?id=343962 --- Comment #18 from Kevin --- Oops, there is a better method! Create the following directory: ~/.local/share/plasma/look-and-feel/org.kde.breeze.desktop/contents/osd/ And then put the following files in it: OsdItem.qml: http://pastebin.com/PZ69qucR Os

[Powerdevil] [Bug 343962] Add option to disable Backlight OSD

https://bugs.kde.org/show_bug.cgi?id=343962 --- Comment #17 from Kevin --- For those who are interested, you can replace OsdItem.qml and Osd.qml in /usr/share/plasma/look-and-feel/org.kde.breeze.desktop/contents/osd/ to change or remove the volume and backlight OSD. I'm currently using OsdItem.qm

[Differential] [Closed] D4011: [Icon Item] Fix updating implicit size when icon sizes change

This revision was automatically updated to reflect the committed changes. Closed by commit R242:8875a04a1bbe: [Icon Item] Fix updating implicit size when icon sizes change (authored by broulik). REPOSITORY R242 Plasma Frameworks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4011?vs=

[Differential] [Closed] D4009: [Dialog] Use setPosition / setSize instead of setting everything individually

This revision was automatically updated to reflect the committed changes. Closed by commit R242:4b55493568b1: [Dialog] Use setPosition / setSize instead of setting everything individually (authored by broulik). REPOSITORY R242 Plasma Frameworks CHANGES SINCE LAST UPDATE https://phabricator.k

[Differential] [Closed] D4001: [Image Wallpaper] Simplify width/height management

This revision was automatically updated to reflect the committed changes. Closed by commit R120:f6ce91499a16: [Image Wallpaper] Simplify width/height management (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4001?vs=9825&id=9861

[Differential] [Closed] D4012: Introduce Units singleton

This revision was automatically updated to reflect the committed changes. Closed by commit R242:56773014e157: Introduce Units singleton (authored by broulik). REPOSITORY R242 Plasma Frameworks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4012?vs=9857&id=9859 REVISION DETAIL http

[Differential] [Closed] D4013: [Units] Make iconSizes property constant

This revision was automatically updated to reflect the committed changes. Closed by commit R242:4479fdab7fff: [Units] Make iconSizes property constant (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D4013?vs=9842&id=9860#toc REPOSITORY R242 Plasma Frameworks CHANG

[Differential] [Commented On] D3738: [Task Manager] Tooltips redesign

broulik added a comment. I like thew new layout a lot, it might let me keeping them enabled! :D Good job. Few nitpicks: - Font color of the large heading in the tooltip is darker/stronger, I think Heading (used in the default tooltip) sets some opacity making it softer - Descender

[Differential] [Accepted] D4012: Introduce Units singleton

markg accepted this revision. markg added a comment. This revision is now accepted and ready to land. Looks nice and clean to me now :) Nice job! REPOSITORY R242 Plasma Frameworks REVISION DETAIL https://phabricator.kde.org/D4012 EMAIL PREFERENCES https://phabricator.kde.org/settings

[Differential] [Changed Subscribers] D4019: [ToolTipDialog] Use KWindowSystem::isPlatformX11() which is cached

markg added inline comments. INLINE COMMENTS > tooltipdialog.cpp:116-118 > +if (KWindowSystem::isPlatformX11()) { > flags = flags | Qt::BypassWindowManagerHint; > } Isn't this redundant anyway? It's being set in the constructor as well. The constructor only deviates in initial

[Differential] [Updated] D4012: Introduce Units singleton

broulik marked an inline comment as done. REPOSITORY R242 Plasma Frameworks REVISION DETAIL https://phabricator.kde.org/D4012 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, markg, davidedmundson, #plasma Cc: markg, plasma-devel, #frameworks, le

[Differential] [Updated] D4012: Introduce Units singleton

broulik marked 3 inline comments as done. REPOSITORY R242 Plasma Frameworks REVISION DETAIL https://phabricator.kde.org/D4012 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, markg, davidedmundson, #plasma Cc: markg, plasma-devel, #frameworks, le

[Differential] [Accepted] D4019: [ToolTipDialog] Use KWindowSystem::isPlatformX11() which is cached

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Frameworks REVISION DETAIL https://phabricator.kde.org/D4019 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpre

[Differential] [Updated, 33 lines] D4012: Introduce Units singleton

broulik updated this revision to Diff 9857. broulik added a comment. - Return reference instead of ptr - Rename to "instance" - Disable move and stuff REPOSITORY R242 Plasma Frameworks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4012?vs=9846&id=9857 REVISION DETAIL https

[Differential] [Commented On] D4012: Introduce Units singleton

broulik added a comment. I was actually thinking about using the "proper" singleton way but didn't want it to be inconsistent with everywhere else. But, yeah, I'll do that. REPOSITORY R242 Plasma Frameworks REVISION DETAIL https://phabricator.kde.org/D4012 EMAIL PREFERENCES https://ph

[Differential] [Request, 13 lines] D4019: [ToolTipDialog] Use KWindowSystem::isPlatformX11() which is cached

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R242 Plasma Frameworks. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY I think it's wr

[Differential] [Requested Changes To] D4012: Introduce Units singleton

markg requested changes to this revision. markg added a reviewer: markg. markg added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > units.cpp:61 > SharedAppFilter *Units::s_sharedAppFilter = nullptr; > +Units *Units::s_self = nullptr; > Remove this line if y

[Differential] [Commented On] D3822: use a native event filter to notice the screen was swapped

broulik added inline comments. INLINE COMMENTS > screenpool.cpp:188 > + > +const xcb_query_extension_reply_t* reply = > xcb_get_extension_data(QX11Info::connection(), &xcb_randr_id); > + Is that call to X really neccessary everytime? It's called constantly for all kinds of events. Also at

[Differential] [Request, 2 lines] D4017: Break from loop once we've found a Layout

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R242 Plasma Frameworks. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY There's no poin

[Differential] [Accepted] D4010: Don't register ConfigModel twice

broulik accepted this revision. broulik added a reviewer: broulik. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Frameworks BRANCH master REVISION DETAIL https://phabricator.kde.org/D4010 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefere

[Differential] [Accepted] D4009: [Dialog] Use setPosition / setSize instead of setting everything individually

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Frameworks REVISION DETAIL https://phabricator.kde.org/D4009 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpre

[Differential] [Accepted] D4011: [Icon Item] Fix updating implicit size when icon sizes change

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Frameworks REVISION DETAIL https://phabricator.kde.org/D4011 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpre

[Differential] [Accepted] D4001: [Image Wallpaper] Simplify width/height management

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4001 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpref

[Differential] [Commented On] D4009: [Dialog] Use setPosition / setSize instead of setting everything individually

davidedmundson added a comment. The idea that it will change whether you see the tab bar resize isn't true. Setwidth and setHeight are done in sequence. There's no way you can get a repaint in between them. (Unless some code has an animation somewhere?) However this is still better.

[Differential] [Accepted] D4012: Introduce Units singleton

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Frameworks REVISION DETAIL https://phabricator.kde.org/D4012 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpre

[Differential] [Accepted] D4013: [Units] Make iconSizes property constant

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Frameworks REVISION DETAIL https://phabricator.kde.org/D4013 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpre

[Differential] [Updated, 30 lines] D4012: Introduce Units singleton

broulik updated this revision to Diff 9846. broulik added a comment. - Q_DISABLE_COPY - Make constructor private REPOSITORY R242 Plasma Frameworks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4012?vs=9841&id=9846 REVISION DETAIL https://phabricator.kde.org/D4012 AFFECTED F

[Differential] [Commented On] D3805: Per-activity favorites (WIP)

ivan added a comment. > Please be less in a rush to push things to Kicker without maintainer review > if they're non-trivial :) Less in rush? I did say I'm not going to merge it into 5.9, but go for 5.10 (and that I'll rebase the patch on 5.9 when it comes out). :) REVISION DET

[Differential] [Request, 4 lines] D4013: [Units] Make iconSizes property constant

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R242 Plasma Frameworks. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY It's not the pr

[Differential] [Request, 26 lines] D4012: Introduce Units singleton

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R242 Plasma Frameworks. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Every single (F

[Differential] [Request, 51 lines] D4011: [Icon Item] Fix updating implicit size when icon sizes change

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R242 Plasma Frameworks. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY The old code wa

[Differential] [Request, 4 lines] D4010: Don't register ConfigModel twice

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. TEST PLAN Opened config REPOSITORY R242 Plasma Frameworks BRANCH master REVISION DE

[Differential] [Request, 7 lines] D4009: [Dialog] Use setPosition / setSize instead of setting everything individually

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R242 Plasma Frameworks. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Reduces the amo

[Powerdevil] [Bug 343962] Add option to disable Backlight OSD

https://bugs.kde.org/show_bug.cgi?id=343962 --- Comment #16 from Kai Stian --- (In reply to Martin Klapetek from comment #15) > > I will call that redundant information. > > For every one calling that a redundant information there will be someone > calling that a missing information if it was re