broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R242 Plasma Frameworks. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY Every single (Frame)SvgItem would creates its own Units instance which in turn would create a property map for icon sizes and lots of other stuff. Avoid this. TEST PLAN I no longer get a tonne of Units objects created REPOSITORY R242 Plasma Frameworks REVISION DETAIL https://phabricator.kde.org/D4012 AFFECTED FILES src/declarativeimports/core/corebindingsplugin.cpp src/declarativeimports/core/framesvgitem.cpp src/declarativeimports/core/framesvgitem.h src/declarativeimports/core/svgitem.cpp src/declarativeimports/core/svgitem.h src/declarativeimports/core/units.cpp src/declarativeimports/core/units.h EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, andreaska, sebas
