[Differential] [Commented On] D3931: [Plasma folderview] Introduce "Back to Desktop" option in listview mode

chinmoyr added a comment. In https://phabricator.kde.org/D3931#73817, @hein wrote: > my original request to use Up normally and Back for links, and you ended up special-casing desktop for some reason with no explanation :) I "special cased" desktop because links were treated as

[Differential] [Commented On] D3931: [Plasma folderview] Introduce "Back to Desktop" option in listview mode

hein added a comment. No, hardcoding magic behavior based on special URLs and inconsistent behavior depending on URL is not "simple". REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3931 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpref

[Differential] [Commented On] D3931: [Plasma folderview] Introduce "Back to Desktop" option in listview mode

hein added a comment. I don't follow you at all there, sorry - my original request to use Up normally and Back for links, and you ended up special-casing desktop for some reason with no explanation :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3931 EMAI

[Differential] [Commented On] D3931: [Plasma folderview] Introduce "Back to Desktop" option in listview mode

chinmoyr added a comment. IMO limiting this behaviour only to desktop will keep things simple. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3931 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: chinmoyr, hein, #plasma Cc

[Differential] [Commented On] D3931: [Plasma folderview] Introduce "Back to Desktop" option in listview mode

chinmoyr added a comment. In https://phabricator.kde.org/D3931#73814, @hein wrote: > I'm referring to links to folders outside of a parent. .desktop links to folders are sort of similar to symlinks. May be we can treat them as folders but then i guess we'll have to drop the "Up"

[Differential] [Commented On] D3931: [Plasma folderview] Introduce "Back to Desktop" option in listview mode

hein added a comment. I'm referring to links to folders outside of a parent. .desktop links to folders are sort of similar to symlinks. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3931 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpr

[Differential] [Commented On] D3931: [Plasma folderview] Introduce "Back to Desktop" option in listview mode

chinmoyr added a comment. In https://phabricator.kde.org/D3931#73809, @hein wrote: > Why is this specific to the desktop? What about other links? The default behaviour is to treat desktop links as folder and for normal links dolphin (or the associated program) is launched. It's

[Differential] [Commented On] D3931: [Plasma folderview] Introduce "Back to Desktop" option in listview mode

hein added a comment. Why is this specific to the desktop? What about other links? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3931 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: chinmoyr, hein, #plasma Cc: plasma-dev

[Differential] [Updated, 52 lines] D3931: [Plasma folderview] Introduce "Back to Desktop" option in listview mode

chinmoyr retitled this revision from "[Plasma folderview] Change behaviour of FolderModel::up" to "[Plasma folderview] Introduce "Back to Desktop" option in listview mode". chinmoyr updated the summary for this revision. chinmoyr updated this revision to Diff 9687. REPOSITORY R119 Plasma Deskt

plasma-devel@kde.org

graesslin accepted this revision. graesslin added a reviewer: graesslin. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH arcpatch-D3832 REVISION DETAIL https://phabricator.kde.org/D3832 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/e

[Differential] [Changed Subscribers] D3738: [Task Manager] Tooltips redesign

anthonyfieroni added inline comments. INLINE COMMENTS > subdiff wrote in ToolTipDelegate.qml:199 > I wanted to use Headings with different levels. The problem is, that they > always automatically create huge margins. Since we wanted to minimize the > size of the tooltips as much as possible, I

[Differential] [Requested Changes To] D3738: [Task Manager] Tooltips redesign

hein requested changes to this revision. hein added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > Task.qml:229 > > -active: !inPopup && !groupDialog.visible && > plasmoid.configuration.showToolTips > -interactive: true > -

[Differential] [Commented On] D3738: [Task Manager] Tooltips redesign

hein added inline comments. INLINE COMMENTS > subdiff wrote in ContextMenu.qml:59 > The context menu can be called now also for a grouped task. The visualParent > is the grouped task parent though. So we need to get the modelProps of > property var modelIndex (which is in case of a grouped task

[Differential] [Closed] D3946: And fix yet another KPLuginMetaData::value breakage with QStringLists

This revision was automatically updated to reflect the committed changes. Closed by commit R120:dca741910638: And fix yet another KPLuginMetaData::value breakage with QStringLists (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde

[Differential] [Closed] D3944: Fix yet another KPluginMetaData::value porting mistake on stringlists

This revision was automatically updated to reflect the committed changes. Closed by commit R120:c43757666aa6: Fix yet another KPluginMetaData::value porting mistake on stringlists (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde

[Differential] [Closed] D3945: Remove unused class

This revision was automatically updated to reflect the committed changes. Closed by commit R120:6d82aa5f68b1: Remove unused class (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3945?vs=9682&id=9685 REVISION DETAIL http

[Differential] [Accepted] D3945: Remove unused class

bshah accepted this revision. bshah added a reviewer: bshah. bshah added a comment. This revision is now accepted and ready to land. This looks like some code to generate user avatars..? But anyway looks good. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabr

[Differential] [Accepted] D3944: Fix yet another KPluginMetaData::value porting mistake on stringlists

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D3944 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Accepted] D3946: And fix yet another KPLuginMetaData::value breakage with QStringLists

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D3946 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Request, 2 lines] D3946: And fix yet another KPLuginMetaData::value breakage with QStringLists

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN Startup scripts now run REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https:

[Differential] [Request, 350 lines] D3945: Remove unused class

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY It's not used, and it doesn't even have any docs saying what it's supposedly for. Removing.

[Differential] [Updated, 4 lines] D3944: Fix yet another KPluginMetaData::value porting mistake on stringlists

davidedmundson updated this revision to Diff 9681. davidedmundson added a comment. Update - found another one! REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3944?vs=9680&id=9681 BRANCH master REVISION DETAIL https://phabricator.kde.org/D3944

[Differential] [Request, 2 lines] D3944: Fix yet another KPluginMetaData::value porting mistake on stringlists

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN Now get a populated Panel's menu (this doesn't answer why Marco and Kai said it worked for them thou

[Differential] [Commented On] D3943: Make sure we only initialize the appstream pool once

mak added a comment. Looks good! (appstreamPool is a bit verbose for my taste, AppStream interally calls it dpool (DataPooL) asPool or just pool - but that's just me being lazy and having to type too much n C anyways) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.

[Differential] [Request, 9 lines] D3943: Make sure we only initialize the appstream pool once

apol created this revision. apol added reviewers: Plasma, broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D3943 AFFECTED FILES apple

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 511 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/511/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 03 Jan 2017 18:28:24 + Build duration: 6 min 2 sec CHANGE SET Revision a54b04dd86c140d8f73913ae3f45c529

Jenkins-kde-ci: oxygen-icons5 master stable-kf5-qt5 » Linux,gcc - Build # 103 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/oxygen-icons5%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/103/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 03 Jan 2017 17:22:54 + Build duration: 5 min 25 sec CHANGE SET Revision 437221d5932a115cee259e8e

Jenkins-kde-ci: oxygen-icons5 master kf5-qt5 » Linux,gcc - Build # 106 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/oxygen-icons5%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/106/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 03 Jan 2017 17:25:24 + Build duration: 1 min 3 sec CHANGE SET Revision 437221d5932a115cee259e8e3ce36bc7

[Differential] [Updated] D3738: [Task Manager] Tooltips redesign

subdiff added inline comments. INLINE COMMENTS > hein wrote in ContextMenu.qml:59 > Maybe s/get/data to be more conventional, but could you argue for kicks why > this churn is needed vs. just making sure the visualParent has the m prop? The context menu can be called now also for a grouped task

[Differential] [Updated, 1,056 lines] D3738: [Task Manager] Tooltips redesign

subdiff updated this revision to Diff 9670. subdiff marked 6 inline comments as done. subdiff added a comment. - Rebased on current master - Review changes REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3738?vs=9170&id=9670 REVISION DETAIL https

[Differential] [Request, 7 lines] D3939: fix description for option -t in man page

lueck created this revision. lueck added reviewers: Plasma, Frameworks. lueck set the repository for this revision to R290 KPackage. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY see https://phabricator.kde.or

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 510 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/510/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 03 Jan 2017 14:58:20 + Build duration: 9 min 31 sec CHANGE SET Revision 5f9db9b909b58e7fc67da1188ee4019

[Powerdevil] [Bug 348529] Turn off screen after lock screen

https://bugs.kde.org/show_bug.cgi?id=348529 --- Comment #14 from k...@web.de --- If you set the lockscreen timeout to less than the DPMS timeout (-30s), that effectively reduces the DPMS timeout to the lockscreen timeout (+30s), making the DPMS timeout setting ineffective. this must somehow be com

[Differential] [Closed] D3916: TaskManager: Hide tooltip after activating task

This revision was automatically updated to reflect the committed changes. Closed by commit R119:4c8b2ea3ba88: TaskManager: Hide tooltip after activating task (authored by drosca). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3916?vs=9601&id=9665 REVI

[Differential] [Closed] D3917: AppletConfig: Use correct icon state for category icons

This revision was automatically updated to reflect the committed changes. Closed by commit R119:a54b04dd86c1: AppletConfig: Use correct icon state for category icons (authored by drosca). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3917?vs=9602&id=96

Jenkins-kde-ci: oxygen-icons5 master kf5-qt5 » Linux,gcc - Build # 105 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/oxygen-icons5%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/105/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 03 Jan 2017 12:32:17 + Build duration: 10 min CHANGE SET Revision e28e695337b0cd5e9d48bb444816f06d1d14c

Jenkins-kde-ci: oxygen-icons5 master stable-kf5-qt5 » Linux,gcc - Build # 102 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/oxygen-icons5%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/102/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 03 Jan 2017 12:32:17 + Build duration: 8 min 27 sec CHANGE SET Revision e28e695337b0cd5e9d48bb44

[Differential] [Closed] D3936: use KPluginMetaData::readStringList()

This revision was automatically updated to reflect the committed changes. Closed by commit R242:94edfa149f1d: use KPluginMetaData::readStringList() (authored by mart). REPOSITORY R242 Plasma Frameworks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3936?vs=9660&id=9663 REVISION DETA

plasma-devel@kde.org

mart added inline comments. INLINE COMMENTS > graesslin wrote in kcm.cpp:342 > I think you got that part wrong. The difference is the value passed to > library. eew, sorry, that's what you get for writing that before cofee :/ REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabrica

plasma-devel@kde.org

mart updated this revision to Diff 9662. mart added a comment. - the ifdef should be at setWindowDecoration REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3832?vs=9650&id=9662 BRANCH arcpatch-D3832 REVISION DETAIL https://phabricator.kde.org/D3

[Differential] [Commented On] D3892: [Icon Item] Support non-square icons

mart added a comment. +1 from me REPOSITORY R242 Plasma Frameworks REVISION DETAIL https://phabricator.kde.org/D3892 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, hein Cc: #frameworks, mart, davidedmundson, plasma-devel, lesliezha

[Differential] [Accepted] D3936: use KPluginMetaData::readStringList()

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Frameworks BRANCH phab/readstringlist REVISION DETAIL https://phabricator.kde.org/D3936 EMAIL PREFERENCES https://phabricator.k

[Differential] [Request, 10 lines] D3936: use KPluginMetaData::readStringList()

mart created this revision. mart added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY replace the last remaining place in pluginloader where a string list was read as a normal s

[Differential] [Updated] D3936: use KPluginMetaData::readStringList()

mart added a reviewer: broulik. REPOSITORY R242 Plasma Frameworks REVISION DETAIL https://phabricator.kde.org/D3936 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma, broulik Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterb

plasma-devel@kde.org

graesslin added inline comments. INLINE COMMENTS > kcm.cpp:342 > +#endif > +setWindowDecoration(cg.readEntry("library", > QStringLiteral("org.kde.breeze")), cg.readEntry("theme", QString())); > +} I think you got that part wrong. The difference is the value passed to library

[Differential] [Accepted] D3928: Sync opacity from an internal QWindow to its ShellClient

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH opacity-internal-window REVISION DETAIL https://phabricator.kde.org/D3928 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 509 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/509/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 03 Jan 2017 11:55:36 + Build duration: 8 min 15 sec CHANGE SET Revision 60a7a21fbe197c57663ad5534ff183c

[Differential] [Closed] D3630: [Digital Clock] Bug fixes and ui code optimization

This revision was automatically updated to reflect the committed changes. Closed by commit R120:1d362c4ae2e2: [Digital Clock] Bug fixes and ui code optimization (authored by subdiff). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3630?vs=9657&id=9659

[Differential] [Updated, 85 lines] D3892: [Icon Item] Support non-square icons

broulik updated this revision to Diff 9658. broulik added a comment. Restricted Application added a subscriber: Frameworks. - Don't blindly round both sizes, instead round one and then scale the other accordingly - Adjust unit test REPOSITORY R242 Plasma Frameworks CHANGES SINCE LAST UPD

[Differential] [Accepted] D3630: [Digital Clock] Bug fixes and ui code optimization

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3630 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: subdiff, #plasma, mart Cc: mart, plasma-devel

[Differential] [Updated, 354 lines] D3630: [Digital Clock] Bug fixes and ui code optimization

subdiff updated this revision to Diff 9657. subdiff marked an inline comment as done. subdiff added a comment. - Fixed pixelSize of sizehelper. - Only changes now to small horizontal mode if date or timezone visible (no sudden size change when resizing with clock only visible). REPOSITORY

[Powerdevil] [Bug 374483] Powerdevil KCM is too tall for my screen

https://bugs.kde.org/show_bug.cgi?id=374483 Christoph Feck changed: What|Removed |Added Resolution|--- |DUPLICATE Status|UNCONFIRMED

[Differential] [Commented On] D3892: [Icon Item] Support non-square icons

davidedmundson added inline comments. INLINE COMMENTS > davidedmundson wrote in iconitem.cpp:325 > This makes no sense. > You can't round it to icon sizes *after* scaling, it means the shorter size > is always just wrong. > > If we do merge this patch, you want: > > m_iconPixmap.size().scaled(

[Differential] [Accepted] D3905: [Icon Applet] Add "Open With" and "Open Containing Folder" actions

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3905 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma

[Differential] [Accepted] D3917: AppletConfig: Use correct icon state for category icons

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D3917 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: d

[Differential] [Accepted] D3914: Rename expander icon tooltip to "close popup" to close the popup

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D3914 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Closed] D3921: Remove outdated PackageKit include

This revision was automatically updated to reflect the committed changes. Closed by commit R119:5f9db9b909b5: Remove outdated PackageKit include (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3921?vs=9612&id=9653 REVISION

[Differential] [Closed] D3922: Don't search for packagekit, we don't use it anywhere anymore

This revision was automatically updated to reflect the committed changes. Closed by commit R119:f534640c6d6f: Don't search for packagekit, we don't use it anywhere anymore (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3922

[Differential] [Closed] D3054: Remove uneeded timeout monitor

This revision was automatically updated to reflect the committed changes. Closed by commit R120:6d041ade456e: Remove uneeded timeout monitor (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3054?vs=7390&id=9652 REVISION DE

[Differential] [Closed] D3925: Remove unused #defines

This revision was automatically updated to reflect the committed changes. Closed by commit R120:2c9b8d59101f: Remove unused #defines (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3925?vs=9621&id=9651 REVISION DETAIL h

Re: Review Request 129753: search and replace old hardcoded types from plasmapkg2

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129753/ --- (Updated Jan. 3, 2017, 12:25 p.m.) Status -- This change has been ma

[Differential] [Accepted] D3921: Remove outdated PackageKit include

apol accepted this revision. apol added a reviewer: apol. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D3921 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, hein, apol Cc: plasma-dev

[Differential] [Accepted] D3922: Don't search for packagekit, we don't use it anywhere anymore

apol accepted this revision. apol added a reviewer: apol. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D3922 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, hein, apol Cc: plasma-dev

Re: Review Request 129753: search and replace old hardcoded types from plasmapkg2

> On Jan. 3, 2017, 1:18 p.m., Anthony Fieroni wrote: > > src/plasmapkg/main.cpp, line 30 > > > > > > Missing QStringLiteral If anything it should be QLatin1String. And I'd say it's not a bother given it's a depr

plasma-devel@kde.org

mart updated this revision to Diff 9650. mart added a comment. - use proper breeze plugin id if found REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3832?vs=9479&id=9650 BRANCH arcpatch-D3832 REVISION DETAIL https://phabricator.kde.org/D3832 A

Re: Review Request 129753: search and replace old hardcoded types from plasmapkg2

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129753/#review101764 --- src/plasmapkg/main.cpp (line 30)

Re: Review Request 129753: search and replace old hardcoded types from plasmapkg2

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129753/#review101763 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 2, 2017

[Differential] [Commented On] D3923: Make AppstreamQt optional

anthonyfieroni added a comment. In https://phabricator.kde.org/D3923#73375, @mak wrote: > In any case, knowing the distro might be useful to check whether their packaging makes sense ;-) KaOS don't have appstream nor appstreamQt nor Discover (it's a fairly normal when first two a

plasma-devel@kde.org

mart added inline comments. INLINE COMMENTS > graesslin wrote in kcm.cpp:337 > what remains is that this is not the default used in KWin. > > In KWin it's: > > static const QString s_aurorae = QStringLiteral("org.kde.kwin.aurorae"); > static const QString s_pluginName = QStringLiteral("org.

[Differential] [Requested Changes To] D3738: [Task Manager] Tooltips redesign

hein requested changes to this revision. hein added a reviewer: hein. hein added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > ContextMenu.qml:59 > > +function get(modelProp) { > +return tasksModel.data(modelIndex, modelProp) Maybe s/get/data to

Re: Review Request 129753: search and replace old hardcoded types from plasmapkg2

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129753/#review101762 --- Ship it! Ship It! - Eike Hein On Jan. 2, 2017, 7:52 p.

[Differential] [Closed] D3934: Fix the help message for --type

This revision was automatically updated to reflect the committed changes. Closed by commit R290:d04769cf7459: Fix the help message for --type (authored by mart). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3934?vs=9648&id=9649 REVISION DETAIL https://ph

[Differential] [Accepted] D3934: Fix the help message for --type

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R290 KPackage BRANCH phab/help REVISION DETAIL https://phabricator.kde.org/D3934 EMAIL PREFERENCES https://phabricator.kde.org/settings/pan

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 508 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/508/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 03 Jan 2017 09:59:13 + Build duration: 8 min 59 sec CHANGE SET Revision 2b9e0e7cc61aa4d3811cde8db92ddb2

[Differential] [Request, 2 lines] D3934: Fix the help message for --type

mart created this revision. mart added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY the type as "package", "wallpaper", "theme" was coming from the old plasmapkg2 tool, which

[Differential] [Updated, 122 lines] D3905: [Icon Applet] Add "Open With" and "Open Containing Folder" actions

broulik updated this revision to Diff 9647. broulik added a comment. - Only offer Open With when for protocols that support listing (avoids it trying to open the "parent folder" of a website url) REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3905

Re: problems with Kirigami on iOS

On Tuesday 03 January 2017, Dirk Hohndel wrote: > but that doesn't appear to be sufficient, as the error message above seems > to indicate... > > Is anyone else using Kirigami and Qt 5.7.1 on iOS and has figured out a way > around that problem? i wonder if is possible to build a simple app that u

[Differential] [Abandoned] D3908: [Look and feel KCM] Notify PaletteChange on DBus

broulik abandoned this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3908 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed,

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 507 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/507/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 03 Jan 2017 08:44:46 + Build duration: 10 min CHANGE SET Revision 2cfd11cd47a56ff01fc6e8b70174907befceb

[Differential] [Closed] D3933: Run all selected items on Enter/Return.

This revision was automatically updated to reflect the committed changes. Closed by commit R119:7c2e3b0d3ba8: Run all selected items on Enter/Return. (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3933?vs=9642&id=9643 REVISION DETAI

[Differential] [Requested Changes To] D3933: Run all selected items on Enter/Return.

broulik requested changes to this revision. broulik added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > FolderView.qml:671 > if (currentIndex != -1 && dir.hasSelection()) { > -var func = root.useListViewMode ? dir.cd

[Differential] [Updated, 19 lines] D3933: Run all selected items on Enter/Return.

hein updated this revision to Diff 9642. hein added a comment. Coding style fix. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3933?vs=9641&id=9642 BRANCH master REVISION DETAIL https://phabricator.kde.org/D3933 AFFECTED FILES containments/

[Differential] [Accepted] D3933: Run all selected items on Enter/Return.

broulik accepted this revision. broulik added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > foldermodel.cpp:527 > +foreach (const QModelIndex &index, m_selectionModel->selectedIndexes()) > +{ > +run(index.row()); Put { on same line REPOSITOR

[Differential] [Request, 20 lines] D3933: Run all selected items on Enter/Return.

hein created this revision. hein added reviewers: Plasma, broulik. hein added a subscriber: plasma-devel. Restricted Application added a project: Plasma. REVISION SUMMARY Brings FV in line with Dolphin behavior. CCBUG:374030 REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAI

[Differential] [Closed] D3932: Set current index to start of selection range when performing rectangle selection.

This revision was automatically updated to reflect the committed changes. Closed by commit R119:2b9e0e7cc61a: Set current index to start of selection range when performing rectangle… (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D393

[Differential] [Accepted] D3932: Set current index to start of selection range when performing rectangle selection.

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D3932 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, broulik, #plasma

[Differential] [Request, 17 lines] D3932: Set current index to start of selection range when performing rectangle selection.

hein created this revision. hein added reviewers: Plasma, broulik. hein added a subscriber: plasma-devel. Restricted Application added a project: Plasma. REVISION SUMMARY BUG:374030 REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D3932 AFFEC

[Differential] [Accepted] D3926: Move SNI's libdbusmenu-qt fork to the root directory and use that for appmenu too

broulik accepted this revision. broulik added a reviewer: broulik. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D3926 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferen

[Differential] [Updated, 119 lines] D3905: [Icon Applet] Add "Open With" and "Open Containing Folder" actions

broulik updated this revision to Diff 9638. broulik added a comment. - Parent jump list QAction to the applet not to leak them REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3905?vs=9637&id=9638 REVISION DETAIL https://phabricator.kde.org/D3905

[Differential] [Updated, 119 lines] D3905: [Icon Applet] Add "Open With" and "Open Containing Folder" actions

broulik updated this revision to Diff 9637. broulik added a comment. - assign nullptr after delete REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3905?vs=9580&id=9637 REVISION DETAIL https://phabricator.kde.org/D3905 AFFECTED FILES applets/ic

[Differential] [Commented On] D3905: [Icon Applet] Add "Open With" and "Open Containing Folder" actions

broulik added a comment. > for deskto files that points to an app shortcut those two entries would not be added, right? Yes, "Open With" for apps doesn't make sense (what, open desktop file in editor?) and "Open containing folder" would open /usr/share/applications, very useful ;) REPO

[Powerdevil] [Bug 374483] New: Powerdevil KCM is too tall for my screen

https://bugs.kde.org/show_bug.cgi?id=374483 Bug ID: 374483 Summary: Powerdevil KCM is too tall for my screen Product: Powerdevil Version: 5.8.5 Platform: Archlinux Packages OS: Linux Status: UNCONFIRMED Se

[Differential] [Closed] D3906: [Icon Applet] Fully re-populate when user changes Link URL

This revision was automatically updated to reflect the committed changes. Closed by commit R120:53c4f98a3391: [Icon Applet] Fully re-populate when user changes Link URL (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3906?vs=9582

[Differential] [Closed] D3897: [Panel Containment] Explicitly bind visible on both the container and the applet

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d674ede6e5f2: [Panel Containment] Explicitly bind visible on both the container and the applet (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.k

[Differential] [Closed] D3816: [Task Manager] Parent QAction to "parent" instead of this

This revision was automatically updated to reflect the committed changes. Closed by commit R119:58e932c607db: [Task Manager] Parent QAction to "parent" instead of this (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3816?vs=9371&id

[Differential] [Closed] D3911: [Containment Appearance] Make sure to always load a config view

This revision was automatically updated to reflect the committed changes. Closed by commit R119:76ac242c37b7: [Containment Appearance] Make sure to always load a config view (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3911?vs=9

[Differential] [Accepted] D3816: [Task Manager] Parent QAction to "parent" instead of this

hein accepted this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3816 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, mart, hein, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts,

[Differential] [Closed] D3902: Fix X-Plasma-Drop* types

This revision was automatically updated to reflect the committed changes. Closed by commit R242:a0f3d2429d0a: Fix X-Plasma-Drop* types (authored by broulik). REPOSITORY R242 Plasma Frameworks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3902?vs=9576&id=9630 REVISION DETAIL https

[Differential] [Requested Changes To] D3931: [Plasma folderview] Change behaviour of FolderModel::up

hein requested changes to this revision. hein added a comment. This revision now requires changes to proceed. (a) I don't like accumulating data in a cache that's never evicted and never changed for correctness. What if the hierarchy changes in the meantime? This is like a subtle bug trap.

[Differential] [Updated] D3927: Fix CD'ing into desktop files in plasma folder view placed inside panel

chinmoyr added a dependent revision: D3931: [Plasma folderview] Change behaviour of FolderModel::up. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3927 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: chinmoyr, #plasma, hein

  1   2   >