mart added inline comments. INLINE COMMENTS
> graesslin wrote in kcm.cpp:337 > what remains is that this is not the default used in KWin. > > In KWin it's: > > static const QString s_aurorae = QStringLiteral("org.kde.kwin.aurorae"); > static const QString s_pluginName = QStringLiteral("org.kde.kdecoration2"); > #if HAVE_BREEZE_DECO > static const QString s_defaultPlugin = > QStringLiteral(BREEZE_KDECORATION_PLUGIN_ID); > #else > static const QString s_defaultPlugin = s_aurorae; > #endif problem is that HAVE_BREEZE_DECO and BREEZE_KDECORATION_PLUGIN_ID are not things i could have access frmo plasma-desktop? > graesslin wrote in kcm.cpp:337 > what remains is that this is not the default used in KWin. > > In KWin it's: > > static const QString s_aurorae = QStringLiteral("org.kde.kwin.aurorae"); > static const QString s_pluginName = QStringLiteral("org.kde.kdecoration2"); > #if HAVE_BREEZE_DECO > static const QString s_defaultPlugin = > QStringLiteral(BREEZE_KDECORATION_PLUGIN_ID); > #else > static const QString s_defaultPlugin = s_aurorae; > #endif but does aurorae work if no theme is speacified? does it have a safe fallback hardcoded one? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3832 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: Lucas, graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas