> On Jan. 3, 2017, 1:18 p.m., Anthony Fieroni wrote: > > src/plasmapkg/main.cpp, line 30 > > <https://git.reviewboard.kde.org/r/129753/diff/2/?file=488468#file488468line30> > > > > Missing QStringLiteral
If anything it should be QLatin1String. And I'd say it's not a bother given it's a deprecated tool. - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129753/#review101764 ----------------------------------------------------------- On Jan. 2, 2017, 8:52 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129753/ > ----------------------------------------------------------- > > (Updated Jan. 2, 2017, 8:52 p.m.) > > > Review request for Plasma and Aleix Pol Gonzalez. > > > Bugs: 374463 > http://bugs.kde.org/show_bug.cgi?id=374463 > > > Repository: plasma-framework > > > Description > ------- > > there is a single difference between command line parameters of plasmapkg2 > and kpackagetool5: plasmapkg2 had some hardcoded names like "theme", > "plasmoid" etc. > kpackagetool5 requires the servicetype name to be passed instead. in order to > stay compatible convert those parameter with the proper servicetype name. > it's parsing parameters by hand in order to just pass anything else without > further parsing > > > Diffs > ----- > > src/plasma/packagestructure/plasmathemepackage.cpp 94f0c5c > src/plasmapkg/main.cpp b61b2e5 > > Diff: https://git.reviewboard.kde.org/r/129753/diff/ > > > Testing > ------- > > installing themes from knewstuff works again > > > Thanks, > > Marco Martin > >
