---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129731/#review101677
---
Ship it!
Ship It!
- Martin Koller
On Dec. 31, 2016, 12
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129732/
---
Review request for Plasma, David Faure and Friedrich W. H. Kossebau.
Repo
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129731/
---
Review request for Plasma and Martin Koller.
Repository: kio-extras
Des
https://bugs.kde.org/show_bug.cgi?id=374168
--- Comment #2 from Branko ---
(In reply to Christoph Feck from comment #1)
> Could you add an image which shows the difference between current buttons
> and the buttons you want to see?
I mean "flat" ex: Arc gtk theme. Breeze buttons looks like Plasti
This revision was automatically updated to reflect the committed changes.
Closed by commit R31:278876855b37: Draw scrollbar as focused when scrollbar
itself have focus (authored by drosca).
REPOSITORY
R31 Breeze
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3813?vs=9367&id=9529
REV
This revision was automatically updated to reflect the committed changes.
Closed by commit R116:9a639f4ce9b0: [Connection Editor] Honor
lineedit_reveal_password restriction (authored by broulik).
REPOSITORY
R116 Plasma Network Management Applet
CHANGES SINCE LAST UPDATE
https://phabricator.k
This revision was automatically updated to reflect the committed changes.
Closed by commit R114:8fea513310f2: [Converter Runner] Also convert to the
user's local currency (authored by broulik).
REPOSITORY
R114 Plasma Addons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3870?vs=9487&
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:eceba917244f: [KUIServer] Forward "destUrl" to all
clients (authored by broulik).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3818?vs=9373&id=9521
REVI
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:b469f397e625: [Applicationjobs Data Engine] Expose job
"destUrl" (authored by broulik).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3819?vs=9374&id=9522
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:23364f7f4913: [Lock Screen] Use QtRendering for Clock
(authored by broulik).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3823?vs=9396&id=9520
REVISION
https://bugs.kde.org/show_bug.cgi?id=374255
k...@web.de changed:
What|Removed |Added
CC||k...@web.de
--- Comment #1 from k...@web.de ---
I
graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
Adjusting to a difference from introducing the InputEventSpy. A filter
may only be installed on
graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
An improvement from the introduction of InputEventSpy. Instead of
specifying a std::function as
graesslin added inline comments.
INLINE COMMENTS
> kcm.cpp:337
> +cg = KConfigGroup(&cg, "org.kde.kdecoration2");
> +setWindowDecoration(cg.readEntry("library",
> QStringLiteral("org.kde.breeze")), cg.readEntry("theme", QString()));
> +}
what remains is that this
broulik added a comment.
> not units.prepend(localCurrency) so it's first?
That's what I did originally but since we sort by magnitude/value at the end,
the order would be lost eventually.
(Reviewboard manages to pick context from the repository, Phab only does so
*after* having com
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:84e33081499f: Introduce an InputEventSpy for processing
input events (authored by graesslin).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D3863?vs=9463&id=9504#toc
REPOSITORY
R108 KWin
CH
graesslin marked 3 inline comments as done.
REPOSITORY
R108 KWin
BRANCH
input-event-spy
REVISION DETAIL
https://phabricator.kde.org/D3863
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: graesslin, #kwin, #plasma, sebas
Cc: sebas, plasma-devel, kwin, l
https://bugs.kde.org/show_bug.cgi?id=374168
Christoph Feck changed:
What|Removed |Added
Severity|normal |wishlist
--- Comment #1 from Christoph Feck -
https://bugs.kde.org/show_bug.cgi?id=374311
S. Christian Collins changed:
What|Removed |Added
Resolution|--- |UPSTREAM
Status|UNCONFIRMED
https://bugs.kde.org/show_bug.cgi?id=374311
--- Comment #3 from S. Christian Collins ---
I have reported this bug for Qt here:
https://bugreports.qt.io/browse/QTBUG-57849
--
You are receiving this mail because:
You are the assignee for the bug.
elvisangelaccio added a comment.
In https://phabricator.kde.org/D3870#72454, @subdiff wrote:
> In https://phabricator.kde.org/D3870#72396, @davidedmundson wrote:
>
> > (Slightly offtopic:
> > when Martin G, eike or I make a diff, there's always an option to expand
the context in ph
subdiff added a comment.
In https://phabricator.kde.org/D3870#72396, @davidedmundson wrote:
> (Slightly offtopic:
> when Martin G, eike or I make a diff, there's always an option to expand
the context in phab to view lines above, when Kai or Subdiff make one, it says
"Context not avai
subdiff updated this revision to Diff 9495.
subdiff marked 8 inline comments as done.
Restricted Application edited projects, added Plasma on Wayland, KWin; removed
Plasma.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3617?vs=9407&id=9495
REVISION DE
+1
We haven't had any new reports about icons breaking only on master, so it
seems all fine.*
David
On Friday 30 December 2016 16:00:27 Lindsay Roberts wrote:
> On 30 December 2016 at 15:26, Marco Martin wrote:
> > the patch you mean is https://phabricator.kde.org/D2986 ?
> >
> > I think it makes sense to backpport..
> > also, to me backporting to 5.8 is kindof special, becuase of its lts
> >
On 30 December 2016 at 15:26, Marco Martin wrote:
> the patch you mean is https://phabricator.kde.org/D2986 ?
>
> I think it makes sense to backpport..
> also, to me backporting to 5.8 is kindof special, becuase of its lts status.
> maybe something i would not consider fto backport for a normal r
davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
davidedmundson added a comment.
This revision is now accepted and ready to land.
not units.prepend(localCurrency) so it's first?
(Slightly offtopic:
when Martin G, eike or I make a diff, there's alway
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129725/
---
(Updated Dec. 30, 2016, 1:50 p.m.)
Status
--
This change has been ma
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129725/#review101670
---
Ship it!
Ship It!
- Marco Martin
On Dec. 30, 2016, 12:
broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R114 Plasma Addons.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
The "most common units" for currency list
On Friday 30 December 2016 22:04:19 Lindsay Roberts wrote:
> Have been in discussion about backporting a bug fix -
> https://bugs.kde.org/show_bug.cgi?id=356479 to 5.8.
>
> The only documentation I could find on backport policy was
> https://community.kde.org/Policies/Commit_Policy#Backport_bugfix
On Friday, December 30, 2016 10:04:19 PM UTC Lindsay Roberts wrote:
> Have been in discussion about backporting a bug fix -
> https://bugs.kde.org/show_bug.cgi?id=356479 to 5.8.
>
> The only documentation I could find on backport policy was
> https://community.kde.org/Policies/Commit_Policy#Backpo
sebas added a comment.
Clarified your questions.
My remaining comments are all non-critical so as long as you consider them,
it's up to you if you change things or not. Just wanted to make sure it's not
an oversight there.
INLINE COMMENTS
> ExclGroupBox.qml:53
> +id
https://bugs.kde.org/show_bug.cgi?id=374300
--- Comment #2 from Alexander Schier ---
An easy colorchooser next to the wallpaper-chooser (or even color chooser in
case of the lockscreen) would be a good start. Stuff like font type may be
better off in full themes (didn't try to use other sddm them
https://bugs.kde.org/show_bug.cgi?id=374300
Jens Reuterberg changed:
What|Removed |Added
CC||jens...@kolabnow.com
--- Comment #1 from Jens
Have been in discussion about backporting a bug fix -
https://bugs.kde.org/show_bug.cgi?id=356479 to 5.8.
The only documentation I could find on backport policy was
https://community.kde.org/Policies/Commit_Policy#Backport_bugfixes - which
is roughly as the URI implies: "backport bugfixes."
This
This revision was automatically updated to reflect the committed changes.
Closed by commit R98:85fd0772a125: SWT/Eclipse toolbar fix (authored by
jsalatas).
REPOSITORY
R98 Breeze for Gtk
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3847?vs=9436&id=9482
REVISION DETAIL
https://ph
kfunk added a comment.
In https://phabricator.kde.org/D3809#72334, @graesslin wrote:
> could I ask you a favor? Please trust the maintainer. If I write no it's
not possible then I mean that. This is the knowledge only core devs can have.
To you it looks like a trivial change. To me it i
On Thursday 29 December 2016 23:24:24 Jonathan Riddell wrote:
> kirigami 2 looks like it'll have the same tar name as kirigami 1
>
> https://techbase.kde.org/index.php?title=Kirigami&diff=next&oldid=98188
>
> this means either distros will have to remove one of them when they
> want to switch to
mart added a comment.
anyways, i don't see evident issues in the code, +1 for me, maybe wait Eike
is back, but looking good
REVISION DETAIL
https://phabricator.kde.org/D3805
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: ivan, hein, mart
Cc: plasma-de
mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.
REPOSITORY
R98 Breeze for Gtk
REVISION DETAIL
https://phabricator.kde.org/D3847
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: jsalatas, #breeze,
mart updated this revision to Diff 9479.
mart added a comment.
- add unmanaged case
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3832?vs=9478&id=9479
BRANCH
phab/kwinlnf
REVISION DETAIL
https://phabricator.kde.org/D3832
AFFECTED FILES
kcms
graesslin added a comment.
could I ask you a favor? Please trust the maintainer. If I write no it's not
possible then I mean that. This is the knowledge only core devs can have. To
you it looks like a trivial change. To me it is a very important bug fix which
had weeks of preparations.
mart updated this revision to Diff 9478.
mart added a comment.
- call kwin config reload only once
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3832?vs=9442&id=9478
BRANCH
phab/kwinlnf
REVISION DETAIL
https://phabricator.kde.org/D3832
AFFECT
graesslin added inline comments.
INLINE COMMENTS
> mart wrote in kcm.cpp:642-646
> nono, i meant in the kcm :)
ok :-) yeah that could be neat as it also allows to unstress the system a bit.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D3832
EMAIL PREFERENCES
mart added inline comments.
INLINE COMMENTS
> graesslin wrote in kcm.cpp:642-646
> in KWin? eh, no, please not.
nono, i meant in the kcm :)
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D3832
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/email
kfunk added a comment.
In https://phabricator.kde.org/D3809#72205, @graesslin wrote:
> In https://phabricator.kde.org/D3809#72177, @kfunk wrote:
>
> > This patch makes it impossible to build kwin on Ubuntu 16.10 (latest
Ubuntu release) against distro libxkbcommon package -- isn't it p
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/oxygen-icons5%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/103/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 30 Dec 2016 07:44:53 +
Build duration: 57 sec
CHANGE SET
No changes
JUNIT RESULTS
Name: (roo
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/oxygen-icons5%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/100/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 30 Dec 2016 07:44:24 +
Build duration: 1 min 0 sec
CHANGE SET
No changes
JUNIT RESULTS
49 matches
Mail list logo
