----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129731/#review101677 -----------------------------------------------------------
Ship it! Ship It! - Martin Koller On Dec. 31, 2016, 12:09 a.m., Pino Toscano wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129731/ > ----------------------------------------------------------- > > (Updated Dec. 31, 2016, 12:09 a.m.) > > > Review request for Plasma and Martin Koller. > > > Repository: kio-extras > > > Description > ------- > > Look for gperf, and use it to generate the hash-based lookup for the > requests table; this replaces the static generated file in the sources, > adding a build time only dependency on gperf to the man kioslave. > > The new FindGperf.cmake module is a local copy of the newly proposed > module for ECM [1], which will need to stay here until the module is > included in ECM, and the build time ECM dependency is risen to the > version containing it. > > The output file is now named as header, since it is used a bit like > that, and surely is better than C++ code with a .c extension. > > [1] https://phabricator.kde.org/D3830 > > > Diffs > ----- > > CMakeLists.txt edc2639e5aef00ef48bab8359bed34633fab26ee > cmake/FindGperf.cmake PRE-CREATION > man/CMakeLists.txt cb4585a289d3f69b8a16429ce87bfce115d1cc27 > man/request_gperf.c aa8bc04333ad869751fad277b8c8e0ac71a00cf8 > man/request_hash.cpp 0e9c0ecbdbec1dd03cc7891f0aa8a81eba872b9a > man/tests/CMakeLists.txt 9612b648dec868222e0c160d4839150a7fa2916f > > Diff: https://git.reviewboard.kde.org/r/129731/diff/ > > > Testing > ------- > > Builds fine as before, and the gperf output in the build directory matches > the removed generated source. > > > Thanks, > > Pino Toscano > >
