Re: Review Request 128552: Italicise the name of symlink in folder view plasmoid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128552/ --- (Updated Dec. 27, 2016, 3:43 a.m.) Status -- This change has been ma

[Differential] [Commented On] D3815: [Task Manager] Add "Places" for entries belonging to a file manager

colomar added a comment. To solve the problem of the context menu getting very long: How about putting the places in a submenu? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3815 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreference

Re: Review Request 129707: Re-symlink duplicate icons weather-fog.svg and weather-overcast.svg

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129707/ --- (Updated Dec. 26, 2016, 11:09 p.m.) Status -- This change has been d

Review Request 129707: Re-symlink duplicate icons weather-fog.svg and weather-overcast.svg

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129707/ --- Review request for Plasma and Andreas Kainz. Repository: breeze-icons D

[Differential] [Commented On] D3302: [Task Manager] Indicate applications playing audio

broulik added a comment. I like the idea but depending on the icon, especially non-round ones, might look terrible. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3302 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: brou

[Differential] [Updated] D3818: [KUIserver] Forward "destUrl" to all clients

broulik retitled this revision from "[KUIserver] Forward "destUrl" all clients" to "[KUIserver] Forward "destUrl" to all clients". REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3818 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferenc

[Differential] [Request, 4 lines] D3819: [Applicationjobs Data Engine] Expose job "destUrl"

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R120 Plasma Workspace. broulik added a dependency: D3818: [KUIserver] Forward "destUrl" all clients. Restricted Application added a project: Plasma. Restricted Application added a subscr

[Differential] [Updated] D3818: [KUIserver] Forward "destUrl" all clients

broulik added a dependent revision: D3819: [Applicationjobs Data Engine] Expose job "destUrl". REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3818 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: plasma

[Differential] [Request, 9 lines] D3818: [KUIserver] Forward "destUrl" all clients

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R120 Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Ensures our job data engine will get n

[Differential] [Updated] D3817: [Connection Editor] Honor lineedit_reveal_password restriction

broulik updated the test plan for this revision. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D3817 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, jgrulich Cc: plasma-devel, lesliezhai, a

[Differential] [Request, 14 lines] D3817: [Connection Editor] Honor lineedit_reveal_password restriction

broulik created this revision. broulik added reviewers: Plasma, jgrulich. broulik set the repository for this revision to R116 Plasma Network Management Applet. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN No longer get the r

[Differential] [Updated] D3816: [Task Manager] Parent QAction to "parent" instead of this

broulik updated the summary for this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3816 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, hein Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterbe

[Differential] [Request, 6 lines] D3816: [Task Manager] Parent QAction to "parent" instead of this

broulik created this revision. broulik added reviewers: Plasma, hein. broulik set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This ensures the QAction is dispose

[Differential] [Commented On] D3815: [Task Manager] Add "Places" for entries belonging to a file manager

broulik added inline comments. INLINE COMMENTS > backend.cpp:174 > + > +QAction *action = new QAction(this); > +action->setText(title); I just spotted this memory leak in backend, jumpListActions and recentDocumentActions both take a "parent" argument which is never used

[Differential] [Request, 35 lines] D3815: [Task Manager] Add "Places" for entries belonging to a file manager

broulik created this revision. broulik added reviewers: Plasma, hein, Plasma: Design. broulik set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Since we cannot hav

[Differential] [Accepted] D3813: Draw scrollbar as focused when scrollbar itself have focus

hpereiradacosta accepted this revision. hpereiradacosta added a comment. This revision is now accepted and ready to land. Ok. I buy it. Thanks for the clarification. Ship it then. (and feel free to push the same for oxygen) REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://

[Differential] [Commented On] D3813: Draw scrollbar as focused when scrollbar itself have focus

drosca added a comment. Currently, it tries to find QAbstractScrollArea in parent chain and use focused state of this scroll area (+ there is a special case for KTextView). There is no standard way to specify the widget that is being scrolled by the scrollbar. This only works with standard Q

[Differential] [Updated] D3813: Draw scrollbar as focused when scrollbar itself have focus

hpereiradacosta added a comment. Hi, ,Thanks for the patch ! Do you have an example application for which this fixes the issue ? I'm a bit worried about the possible regressions that your change introduced, so I would like to understand better what happens here ... INLINE COMMENTS >

[Differential] [Request, 6 lines] D3813: Draw scrollbar as focused when scrollbar itself have focus

drosca created this revision. drosca added reviewers: Plasma, hpereiradacosta. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Fixes case when scrollbar have the scrolling widget as focus proxy. REPOSITORY R31 Breeze B

[Differential] [Request, 15 lines] D3812: Deprecate Plasma::Package API in PluginLoader

graesslin created this revision. graesslin added reviewers: Plasma, Frameworks. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY As Plasma::Package is deprecated API using Plasma::Package should also be deprecated. REPOS

[Breeze] [Bug 374168] New: make buttons flat in breeze

https://bugs.kde.org/show_bug.cgi?id=374168 Bug ID: 374168 Summary: make buttons flat in breeze Product: Breeze Version: unspecified Platform: Other OS: Linux Status: UNCONFIRMED Severity: normal

[Differential] [Request, 52 lines] D3810: Add the modifiers relevant for global shortcuts into the input Events

graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY Prior to this change various event filters performed deep calls into

[Differential] [Request, 27 lines] D3809: Use new xkbcommon API for consumed modifiers

graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY This change removes the workaround added with https://phabricator.

[Differential] [Request, 1 line] D3808: Fix the osd re-placement on X11

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY https://phabricator.kde.org/R108:6383f8304711719fe22371474138efc144adc750 introduced a regressio

[Differential] [Commented On] D3617: [Touchpad KCM] New KWin Wayland version

graesslin added inline comments. INLINE COMMENTS > subdiff wrote in kwinwaylandbackend.cpp:84 > Are you sure? The foreach keyword is still listed in the official Qt docu. > What's the best alternative? A normal for-loop? With upcounting integer or > iterator? https://www.kdab.com/goodbye-q_for