broulik added inline comments. INLINE COMMENTS
> backend.cpp:174 > + > + QAction *action = new QAction(this); > + action->setText(title); I just spotted this memory leak in backend, jumpListActions and recentDocumentActions both take a "parent" argument which is never used. I'll make a follow-up patch to change new QAction(this) to new QAction(menu) and I verified that this causes the QActions to be disposed of once the menu closes REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3815 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, hein, #plasma:_design Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
