graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY https://phabricator.kde.org/R108:6383f8304711719fe22371474138efc144adc750 introduced a regression hitting an assert on X11 when an osd window is added. This change tries to address this by adding a GeometryUpdateBlocker around the change. The hit assertion is: pendingGeometryUpdate() == PendingGeometryNone || areGeometryUpdatesBlocked() By using a GeometryUpdateBlocker the second condition becomes true and we no longer hit the condition. BUG: 374038 TEST PLAN Manual tested both on X11 and Wayland, Wayland autotest still passes REPOSITORY R108 KWin BRANCH fix-osd-placement-x11 REVISION DETAIL https://phabricator.kde.org/D3808 AFFECTED FILES abstract_client.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas