Re: Review Request 128038: [libtaskmanager] Stop highlighted window effect in group item

> On Дек. 21, 2016, 2:58 преди обяд, David Edmundson wrote: > > applets/taskmanager/package/contents/ui/GroupDialog.qml, line 37 > > > > > > note we've moved to phabricator for review requests, which is why this

[Breeze] [Bug 373088] Current tab highlighting counter-intuitive when using dark themes

https://bugs.kde.org/show_bug.cgi?id=373088 --- Comment #10 from Christoph Feck --- (or "QPalette::Shadow" at your convenience...) -- You are receiving this mail because: You are the assignee for the bug.

[Breeze] [Bug 373088] Current tab highlighting counter-intuitive when using dark themes

https://bugs.kde.org/show_bug.cgi?id=373088 --- Comment #9 from Christoph Feck --- According to the code, the color that is used to darken the inactive tabs is the WindowText color. With reverse (dark) themes, this color is bright, so instead of darkening, the inactive tabs become lighter. Sugg

[plasmashell] [Bug 340063] Please make KDE fade to black before turning screen off

https://bugs.kde.org/show_bug.cgi?id=340063 --- Comment #15 from S --- Hi, I have to take back my last comment, I'm not seeing any fading. The screen goes from full-on straight to black with no fading transition (I assume this is the lockscreen activating) and then the energy module kicks in and

[plasmashell] [Bug 340063] Please make KDE fade to black before turning screen off

https://bugs.kde.org/show_bug.cgi?id=340063 --- Comment #14 from Christoph Feck --- The screen is not turned off immediately once it is black, see commend #10. -- You are receiving this mail because: You are the assignee for the bug.

Re: Review Request 128038: [libtaskmanager] Stop highlighted window effect in group item

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128038/#review101527 --- applets/taskmanager/package/contents/ui/GroupDialog.qml (li

[Differential] [Commented On] D3756: [Folder View] Add "Restore" from trash option

colomar added a comment. Yup, makes sense! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3756 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, #plasma:_design, hein Cc: colomar, plasma-devel, lesliezhai,

Re: Review Request 129691: digital-clock: Update iso-3166 codes in timezones

> On Dec. 20, 2016, 11:46 p.m., Pino Toscano wrote: > > TBH I don't think the Congo and CZ changes are somehow needed, since the > > current names are already the official names for the countries. > > Jiri Bohac wrote: > The reason is consistency. > The short names are used for all the

Re: Review Request 129691: digital-clock: Update iso-3166 codes in timezones

> On Dec. 20, 2016, 10:46 p.m., Pino Toscano wrote: > > TBH I don't think the Congo and CZ changes are somehow needed, since the > > current names are already the official names for the countries. > > Jiri Bohac wrote: > The reason is consistency. > The short names are used for all the

Re: [Differential] [Commented On] D3769: expose immutable through dbus

It's for Now Dock's next version, a discussion can be found here: https://phabricator.kde.org/D3754 in next version Now Dock will be a Dock outside plasmashell but I want the user to have a unified experience with plasmashell. Unlocking widgets in plasma unlocks them also for my Dock and in reverse

Re: Review Request 129691: digital-clock: Update iso-3166 codes in timezones

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129691/#review101524 --- +0 Note the correct patch would possibly be to port it to

[Differential] [Commented On] D3769: expose immutable through dbus

apol added a comment. It's a bit scary that applications can randomly change this state, no? What's the use-case? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3769 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mvou

Re: Review Request 129691: digital-clock: Update iso-3166 codes in timezones

> On Dec. 20, 2016, 10:46 p.m., Pino Toscano wrote: > > TBH I don't think the Congo and CZ changes are somehow needed, since the > > current names are already the official names for the countries. The reason is consistency. The short names are used for all the remaining countries. It's inconsis

[Differential] [Closed] D3765: Add names to the knsrc files

This revision was automatically updated to reflect the committed changes. Closed by commit R108:1c394ab6453a: Add names to the knsrc files (authored by apol). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3765?vs=9230&id=9240 REVISION DETAIL https://phabricat

Re: Review Request 129691: digital-clock: Update iso-3166 codes in timezones

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129691/#review101522 --- TBH I don't think the Congo and CZ changes are somehow neede

[Differential] [Updated] D3769: expose immutable through dbus

mvourlakos added a reviewer: davidedmundson. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3769 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mvourlakos, #plasma, davidedmundson Cc: plasma-devel, lesliezhai, ali-mohamed,

[Differential] [Request, 29 lines] D3769: expose immutable through dbus

mvourlakos created this revision. mvourlakos added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY --expose immutable and signaling immutability changes through dbus in order to be used from applicati

Review Request 129691: digital-clock: Update iso-3166 codes in timezones

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129691/ --- Review request for Plasma and Albert Astals Cid. Repository: plasma-works

Re: Review Request 129679: Give names to knsrc files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129679/#review101520 --- Ship it! wallpapers/image/wallpaper.knsrc (line 2)

[Differential] [Accepted] D3765: Add names to the knsrc files

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D3765 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, graesslin, #plasma Cc: plasma

Review Request 129680: Give names to knsrc files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129680/ --- Review request for Plasma. Repository: plasma-desktop Description -

Review Request 129679: Give names to knsrc files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129679/ --- Review request for Plasma. Repository: plasma-workspace Description ---

[Differential] [Request, 8 lines] D3765: Add names to the knsrc files

apol created this revision. apol added reviewers: Plasma, graesslin. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY This way they can be properly listed by Discover REPOSITORY R108 KWin BRANCH master REVISION DE

[Differential] [Commented On] D3495: Scale QPainter x11 windowed backend

graesslin added inline comments. INLINE COMMENTS > davidedmundson wrote in scene_qpainter_test.cpp:202-203 > It creates a surface on line 200. > > What's the difference between a top level mapped surface and a window? A surface is something you can attach a buffer to. It's not a window but a w

[Differential] [Request, 1 line] D3764: Make sure that triggering a menu action keeps respecting its action value

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Kirigami.Action.checked is designed so that the user has to change its value upon triggered rather than

[Differential] [Commented On] D3495: Scale QPainter x11 windowed backend

davidedmundson added inline comments. INLINE COMMENTS > graesslin wrote in scene_qpainter_test.cpp:202-203 > the test is called "testWindowScaled", but doesn't create a window. I'm > slightly confused. It creates a surface on line 200. What's the difference between a top level mapped surface a

[Differential] [Commented On] D3495: Scale QPainter x11 windowed backend

graesslin added inline comments. INLINE COMMENTS > davidedmundson wrote in scene_qpainter_test.cpp:202-203 > I don't really need a shell surface at all, I can just remove this. the test is called "testWindowScaled", but doesn't create a window. I'm slightly confused. REPOSITORY R108 KWin RE

[Differential] [Abandoned] D3758: [AppletInterface] Emit toolTipMainTextChanged if it changes in response to a title change

broulik abandoned this revision. REPOSITORY R242 Plasma Frameworks REVISION DETAIL https://phabricator.kde.org/D3758 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohame

[Differential] [Commented On] D3754: expose toggleWidgetExplorer through dbus

mvourlakos added a comment. thank u ! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3754 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mvourlakos, mart, davidedmundson, #plasma Cc: plasma-devel, lesliezhai, ali-moham

[Differential] [Closed] D3754: expose toggleWidgetExplorer through dbus

This revision was automatically updated to reflect the committed changes. Closed by commit R120:805d17664b30: expose toggleWidgetExplorer through dbus (authored by mvourlakos). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3754?vs=9205&id=9223 REVIS

[Differential] [Accepted] D3754: expose toggleWidgetExplorer through dbus

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH toggle REVISION DETAIL https://phabricator.kde.org/D3754 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mvourlakos, mart,

[Differential] [Closed] D3731: Just look up once the SwipeItemFilter

This revision was automatically updated to reflect the committed changes. Closed by commit R169:fc1ba075f35d: Just look up once the SwipeItemFilter (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3731?vs=9159&id=9222 REVISION DETAIL http

[Differential] [Commented On] D3754: expose toggleWidgetExplorer through dbus

mvourlakos added a comment. In https://phabricator.kde.org/D3754#70294, @davidedmundson wrote: > Code is fine, but what's the intended use? Intended use is for all the apps that leave outside plasmashell and want to provide a unified experience with it... Such a case is the next v

[Differential] [Updated] D3085: Use DBusMenu if available

davidedmundson retitled this revision from "RFC: Use DBusMenu if available" to "Use DBusMenu if available". REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D3085 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefere

[Differential] [Updated] D3754: expose toggleWidgetExplorer through dbus

davidedmundson added a comment. Code is fine, but what's the intended use? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3754 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mvourlakos, #plasma, mart, davidedmundson Cc

[Differential] [Closed] D3761: Don't double emit iconChanged

This revision was automatically updated to reflect the committed changes. Closed by commit R242:7e1f2d79dafa: Don't double emit iconChanged (authored by davidedmundson). REPOSITORY R242 Plasma Frameworks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3761?vs=9215&id=9219 REVISION DE

[Differential] [Closed] D3760: Emit toolTipMainTextChanged if it changes in response to a title change

This revision was automatically updated to reflect the committed changes. Closed by commit R242:17f5a3073b66: Emit toolTipMainTextChanged if it changes in response to a title change (authored by davidedmundson). REPOSITORY R242 Plasma Frameworks CHANGES SINCE LAST UPDATE https://phabricator.

[Differential] [Closed] D3759: Don't double emit titleChanged

This revision was automatically updated to reflect the committed changes. Closed by commit R242:63a889ea0d16: Don't double emit titleChanged (authored by davidedmundson). REPOSITORY R242 Plasma Frameworks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3759?vs=9213&id=9217 REVISION D

[Differential] [Accepted] D3759: Don't double emit titleChanged

broulik accepted this revision. broulik added a reviewer: broulik. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Frameworks BRANCH origin-master (branched from master) REVISION DETAIL https://phabricator.kde.org/D3759 EMAIL PREFERENCES https://phabricator.kde.o

[Differential] [Accepted] D3761: Don't double emit iconChanged

broulik accepted this revision. broulik added a reviewer: broulik. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Frameworks BRANCH origin-master (branched from master) REVISION DETAIL https://phabricator.kde.org/D3761 EMAIL PREFERENCES https://phabricator.kde.o

[Differential] [Accepted] D3760: Emit toolTipMainTextChanged if it changes in response to a title change

broulik accepted this revision. broulik added a reviewer: broulik. broulik added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R242 Plasma Frameworks BRANCH origin-master (branched from master) REVISION DETAIL https://phabricator.kde.org/D3760 EMAIL PRE

[Differential] [Closed] D3749: Make it possible to use the keyboard on Kirigami apps

This revision was automatically updated to reflect the committed changes. Closed by commit R169:8dc311598e09: Make it possible to use the keyboard on Kirigami apps (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3749?vs=9199&id=9216 REVISI

[Differential] [Accepted] D3749: Make it possible to use the keyboard on Kirigami apps

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D3749 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc: plasma-dev

[Differential] [Accepted] D3731: Just look up once the SwipeItemFilter

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D3731 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc: plasma-dev

[Differential] [Request, 1 line] D3761: Don't double emit iconChanged

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY AppletInterface::setIcon calls Applet::setIcon which in turn emits Applet::iconChanged A

[Differential] [Request, 7 lines] D3760: Emit toolTipMainTextChanged if it changes in response to a title change

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The fallback for toolTipMainText is showing the applet title. When the applet title change

[Differential] [Request, 1 line] D3759: Don't double emit titleChanged

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY AppletInterface::setTitle calls Applet::setTitle -- which in turn emits Applet::titleChanged

[Differential] [Requested Changes To] D3758: [AppletInterface] Emit toolTipMainTextChanged if it changes in response to a title change

davidedmundson requested changes to this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added a comment. This revision now requires changes to proceed. Not your fault, but this current code is completely wrong and needs fixing. It should *not* be emitting a signa

[Differential] [Request, 6 lines] D3758: [AppletInterface] Emit toolTipMainTextChanged if it changes in response to a title change

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R242 Plasma Frameworks. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The fallback for toolTipMainText is s

[Differential] [Closed] D3753: Fix comparing pa_cvolume objects

This revision was automatically updated to reflect the committed changes. Closed by commit R115:825e64edc982: Fix comparing pa_cvolume objects (authored by drosca). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3753?vs=9204&id=9210 REVISIO

[Differential] [Accepted] D3753: Fix comparing pa_cvolume objects

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Oops sorry. The docs were written pretty confusingly. REPOSITORY R115 Plasma Audio Volume Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D3753 EMAI

[Differential] [Request, 23 lines] D3756: [Folder View] Add "Restore" from trash option

broulik created this revision. broulik added reviewers: Plasma, Plasma: Design, hein. broulik set the repository for this revision to R119 Plasma Desktop. broulik added a dependency: D3755: [Folder View] Offer "Empty Trash" whenever we're in "trash" scheme. Restricted Application added a project:

[Differential] [Updated] D3755: [Folder View] Offer "Empty Trash" whenever we're in "trash" scheme

broulik added a dependent revision: D3756: [Folder View] Add "Restore" from trash option. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3755 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, hein Cc: plasma-

[Differential] [Request, 4 lines] D3755: [Folder View] Offer "Empty Trash" whenever we're in "trash" scheme

broulik created this revision. broulik added reviewers: Plasma, hein. broulik set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY We can navigate subfolders of trash

[Differential] [Commented On] D3753: Fix comparing pa_cvolume objects

shumski added a comment. I can confirm the bug is fixed with this. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D3753 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, #plasma, davidedmundson Cc: shumsk

[Differential] [Updated] D3754: expose toggleWidgetExplorer through dbus

mvourlakos added reviewers: mart, davidedmundson. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3754 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mvourlakos, #plasma, mart, davidedmundson Cc: plasma-devel, lesliezhai, a

[Differential] [Request, 4 lines] D3754: expose toggleWidgetExplorer through dbus

mvourlakos created this revision. mvourlakos added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY --shows/hides the WidgetExplorer through dbus Test Plani: trigger widget explorer from command lin