drosca created this revision.
drosca added reviewers: Plasma, davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
pa_cvolume_equal returns 1 when true, 0 otherwise
BUG: 373943
REPOSITORY
R115 Plasma Aud
subdiff added a comment.
In https://phabricator.kde.org/D3738#70083, @colomar wrote:
> Great improvements!
> Is the desktop / Activity only shown if
>
> - there are multiple ones and
> - the task manager shows tasks from different ones?
Glad you like it! And yes, yes. :)
davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D3744
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailprefer
apol created this revision.
apol added reviewers: Kirigami, mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Forwards key presses to the current page
Makes it possible to move forward to the next page on the page
davidedmundson updated this revision to Diff 9197.
davidedmundson marked 3 inline comments as done.
davidedmundson added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
MG's comments
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/
davidedmundson added inline comments.
INLINE COMMENTS
> graesslin wrote in scene_qpainter_test.cpp:202-203
> the idea of the Test::createShellSurface variant returning a QObject is to
> have a test_data() with the two supported modes, so that we test both WlShell
> and XdgShellUnstableV5. You c
colomar added a comment.
Great improvements!
Is the desktop / Activity only shown if
- there are multiple ones and
- the task manager shows tasks from different ones?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D3738
EMAIL PREFERENCES
https://pha
davidedmundson added inline comments.
INLINE COMMENTS
> davidedmundson wrote in appmenumodel.cpp:85
> If you return here you have an unmatching begin/remove
Turns out this is what was causing that kate->konsole crash.
I should have trusted my reviewing instead of spending some time in valgrind.
This revision was automatically updated to reflect the committed changes.
Closed by commit R115:fbab032d122e: Correctly initialise and compare pa_cvolume
structs (authored by davidedmundson).
REPOSITORY
R115 Plasma Audio Volume Applet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D37
drosca accepted this revision.
drosca added a reviewer: drosca.
This revision is now accepted and ready to land.
REPOSITORY
R115 Plasma Audio Volume Applet
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D3739
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailp
broulik created this revision.
broulik added reviewers: Plasma, hein.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This keeps Plasma from trying to sh
broulik created this revision.
broulik added reviewers: Plasma, hein.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
We change the height in response to
broulik created this revision.
broulik added reviewers: Plasma, Plasma: Design, hein.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This will have Fold
https://bugs.kde.org/show_bug.cgi?id=340063
--- Comment #13 from S ---
OK, it looks like I'm seeing the fade, but it definitely seems too fast. The
idea in my opinion is not just to make it aesthetic, but to give the user an
alert that it's about to turn off so it can be interrupted. I'd like to
This revision was automatically updated to reflect the committed changes.
Closed by commit R134:596589da77ec: Search for KF5Kirigami2 instead of
KF5Kirigami (authored by heikobecker).
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3734?vs=9171&
subdiff added a reviewer: VDG.
subdiff added a project: VDG.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D3738
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: subdiff, #plasma, #vdg
Cc: plasma-devel, lesliezhai, ali-mohamed
subdiff created this revision.
subdiff added a reviewer: Plasma.
subdiff added a subscriber: plasma-devel.
subdiff set the repository for this revision to R119 Plasma Desktop.
subdiff added a project: Plasma.
REVISION SUMMARY
This patch reworks the design of the task manager tooltips as requeste
apol accepted this revision.
apol added a reviewer: apol.
This revision is now accepted and ready to land.
REPOSITORY
R134 Discover Software Store
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D3734
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreference
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Previously m_volume was uninitialised, resulting in a comparison on
garbage data when first r
davidedmundson abandoned this revision.
davidedmundson added a comment.
In https://phabricator.kde.org/D3736#69877, @drosca wrote:
> Perhaps it would be better to use `pa_cvolume_init`? In this case it really
doesn't matter, but invalid volume value (for `pa_cvolume::values`) is not
zero
drosca added a comment.
Perhaps it would be better to use `pa_cvolume_init`? In this case it really
doesn't matter, but invalid volume value (for `pa_cvolume::values`) is not
zero, but `UINT32_MAX`.
REPOSITORY
R115 Plasma Audio Volume Applet
REVISION DETAIL
https://phabricator.kde.org/D
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129669/
---
(Updated Dec. 19, 2016, 5:28 p.m.)
Status
--
This change has been ma
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
We do a memcmp on m_volume to the new volume object
On the first run this is uninitialised
elvisangelaccio added inline comments.
INLINE COMMENTS
> graesslin wrote in kwaylandintegration.cpp:35
> just wondering: we once have here a QByteArray and once a const char[] -
> shouldn't we use the same in both?
I used char[] for consistency with the old code, but I can use QByteArray if
yo
graesslin added inline comments.
INLINE COMMENTS
> davidedmundson wrote in osd.cpp:73
> I don't get why this line exists, you can render an internal window on either
> platform..
>
> but if it should exist, why it is not put it for show too?
> I don't get why this line exists, you can render a
heikobecker created this revision.
heikobecker added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
plasma-discover crashes if it isn't present.
REPOSITORY
R134 Discover Software Store
BRANCH
mas
On 19/12/2016 02:49 μμ, Marco Martin wrote:
On Monday 19 December 2016, Michail Vourlakos wrote:
What is missing from plasmashell according to my tests in order to
provide a unified experience are the following:
1. plasmashell immutable changed signal
the containment does have a signal fo
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:a7ccca25baaf: [TextField] Allow disabling reveal password
button through KIOSK restriction (authored by broulik).
REPOSITORY
R242 Plasma Frameworks
CHANGES SINCE LAST UPDATE
https://phabricator.kd
sitter updated this revision to Diff 9164.
sitter added a comment.
switch to lgpl-2-3-ev as suggested in review
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3707?vs=9153&id=9164
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D370
sitter added inline comments.
INLINE COMMENTS
> dfaure wrote in servicerunnertest.cpp:59
> BTW if this is necessary then there's a bug in ksycoca :-)
>
> You can leave it (it helps getting the debug output from ksycoca in the right
> method) but if it fails without this line, then please tell m
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-tests%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/510/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 19 Dec 2016 13:03:25 +
Build duration: 1 min 18 sec
CHANGE SET
No changes
JUNIT RESULTS
Name:
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-tests%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/510/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 19 Dec 2016 13:03:25 +
Build duration: 1 min 18 sec
CHANGE SET
No changes
JUNIT RESULTS
Name:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129642/
---
(Updated Dec. 19, 2016, 12:54 p.m.)
Status
--
This change has been m
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:47ce959f6f10: [Kicker] Support drag from bookmarks runner
(authored by broulik).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3728?vs=9149&id=9161
REVISIO
dfaure added inline comments.
INLINE COMMENTS
> servicerunnertest.cpp:59
> +
> +KSycoca::self()->ensureCacheValid();
> +}
BTW if this is necessary then there's a bug in ksycoca :-)
You can leave it (it helps getting the debug output from ksycoca in the right
method) but if it fails without
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:eb81b3f1628e: [AppletQuickItem] Support launch error
message (authored by broulik).
REPOSITORY
R242 Plasma Frameworks
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3725?vs=9144&id=9160
R
dfaure added a comment.
I would say yes, it's worth using LGPL v2+ or v2+v3 or v2+v3+e.V., whichever
you prefer, for any new code. Otherwise it's even more work the day we want to
relicense away from v2 only (I know because I've been trying to do that for
some code for a very long time, and
On Monday 19 December 2016, Michail Vourlakos wrote:
> What is missing from plasmashell according to my tests in order to
> provide a unified experience are the following:
>
>
> 1. plasmashell immutable changed signal
the containment does have a signal for that
> 2. toggle plasmashell immutab
On 19/12/2016 02:31 μμ, Marco Martin wrote:
it is not possible to create a different panel view neither change the panel
settings view, nor the sizing policies.
What you can do is to add a custom action to the context menu, which will
create a new dialog window in which you can put the settin
apol created this revision.
apol added reviewers: Kirigami, mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Store it in a property instead of looking it up every now and then
REPOSITORY
R169 Kirigami
BRANCH
m
On Monday 19 December 2016, Michail Vourlakos wrote:
> > isn't NowDock its own custompanel already?
>
> no it isnt...
> Do you know a way to create my own panelview for plasmashell? (this is
> what I mean by custompanel)
>
> Current Implementation:
> in metadata.desktop it is set:
> X-Plasma-Cont
On 19/12/2016 11:43 πμ, Marco Martin wrote:
On Saturday 17 December 2016, Michail Vourlakos wrote:
Hello everyone,
do you know if it is possible to add a different panel implementation in
plasma and provide me with some guidelines for this?
The use case is the Now Dock for which I want to pr
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:d199731bd33d: Make sure pages are destroying when popping
(authored by apol).
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3726?vs=9145&id=9158
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R116:824018a3d3ff: Block Network manager notifications when
the popup is visible (authored by davidedmundson).
REPOSITORY
R116 Plasma Network Management Applet
CHANGES SINCE LAST UPDATE
https://phabric
davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
kill-window-osd
REVISION DETAIL
https://phabricator.kde.org/D3724
EMAIL PREFERENCES
https://phabricator.kde.org/settings/p
davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
reposition-osd-on-size-change
REVISION DETAIL
https://phabricator.kde.org/D3720
EMAIL PREFERENCES
https://phabricator.kde.
davidedmundson added a comment.
looks generally good.
1 nitpick about QML icon usage, and one question.
INLINE COMMENTS
> onscreennotification.h:47
> +explicit OnScreenNotification(QObject *parent = nullptr);
> +virtual ~OnScreenNotification();
> +bool isVisible() const;
No
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:db1502268663: Fix logic for arrow handling in RTL
locales. (authored by hein).
REPOSITORY
R242 Plasma Frameworks
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3718?vs=9132&id=9156
REVISI
Plasma Meeting minutes 12-19-2016
NOTE: No meeting next Monday due to holidays.
Present: notmart, romangg, bshah, kbroulik, Riddell, Sho_
notmart:
* bug triaging
* a bit of spring cleaning of old reviews
* plymouth kcm: basics correctly working, install, uninstall, apply,
thumbnails still broken
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:9d45aa5a9584: Larger icons and stack windows above label
item. (authored by hein).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3719?vs=9133&id=9155
REVIS
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D3719
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: hein, mart, davidedm
davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Frameworks
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D3718
EMAIL PREFERENCES
https://phabricator.kde.org/settin
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:7c00be121eeb: ensure results are sorted by relevance
(authored by sitter).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3704?vs=9078&id=9154
REVISION DETA
mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Frameworks
REVISION DETAIL
https://phabricator.kde.org/D3725
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasm
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-tests%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/509/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 19 Dec 2016 11:08:11 +
Build duration: 3 min 37 sec
CHANGE SET
No changes
JUNIT RESULTS
Name:
hein accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D3728
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, hein, #plasma
Cc: plasma-devel, leslie
hein accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
BRANCH
Plasma/5.8
REVISION DETAIL
https://phabricator.kde.org/D3704
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: sitter, hein
Cc: plasma-de
sitter added inline comments.
INLINE COMMENTS
> dfaure wrote in servicerunnertest.cpp:5
> Is LGPL-v2-only on purpose here?
Not particularly. It's the same as the existing source file though, to have the
same license restrictions apply to both. Is it worth changing it to gpgl2+kdev
considering
broulik added a comment.
I can also reproduce the crash when running kscreenlocker_greet --testing
It crashes when the KActionCollection (that holds the actions for the global
shortcuts) gets destroyed on teardown. By that time KGlobalAccel cleanup
already happened, it then creates a new
sitter updated this revision to Diff 9153.
sitter marked an inline comment as done.
sitter added a comment.
drop excessive code to isolate ksyscoca. setting qstandardpaths into testing
mode is enough to isolate this {icon check-square}
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UP
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129669/#review101505
---
Ship it!
Ship It!
- Marco Martin
On Dec. 18, 2016, 12:
On Saturday 17 December 2016, Michail Vourlakos wrote:
> Hello everyone,
>
>
> do you know if it is possible to add a different panel implementation in
> plasma and provide me with some guidelines for this?
>
> The use case is the Now Dock for which I want to provide a unified
> settings experie
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R169 Kirigami
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D3726
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: apol, #kirigami, mart
Cc: plasma-dev
63 matches
Mail list logo
