subdiff created this revision. subdiff added a reviewer: Plasma. subdiff added a subscriber: plasma-devel. subdiff set the repository for this revision to R119 Plasma Desktop. subdiff added a project: Plasma.
REVISION SUMMARY This patch reworks the design of the task manager tooltips as requested by task https://phabricator.kde.org/T2029. **Comparision video:** https://youtu.be/6MKfBK63kpo Features: --------- - New tooltip design: - Less screen space occupied by tooltips - Tooltips have always the same size - Better structured informations about a task: Appname, window title, desktop, activity if useful - Close button better looking and more visible - Group tooltips show per group task all individual informations - Group tooltips provide context menu per task and its group - Group tooltips in vertical bar are lined up as column - If supported by media player, controls are available for each instance separately - Fixed: In any case secondary media players instances are always also shown in group tooltip - Fixed: Flickable area when exceeding available display space - Fixed: mpris2 source name detection only activated on changed sources and not on every new data tick - Fixed: Many warning and error messages Technical overview: ------------------- - TooltipDelegate is loaded per task, which simplifies code and helps to prevent graphical glitches. - For groups instead of relying on the window list provided by X, we now use a proper submodel of the grouped tasks (because of a Qt bug for now we need to do some workaround here by loading it delayed on a parent index change) - Window titles are processed by some reg exp to show only the relevant part of it - Media player instances are distinguished by their process ids Pictures: --------- Default tooltip of opened application: F831825: Screenshot_20161219_172305.png <https://phabricator.kde.org/F831825> Media player tooltip: F831827: Screenshot_20161219_172429.png <https://phabricator.kde.org/F831827> Group tooltip horizontal panel: F831828: Screenshot_20161219_172553.png <https://phabricator.kde.org/F831828> Group tooltip vertical panel: F831829: Screenshot_20161219_172632.png <https://phabricator.kde.org/F831829> TEST PLAN Manually tested on X, can't login to Wayland session for some other reason at the moment, so not tested there (but the old tooltips were broken in Wayland anyway). REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3738 AFFECTED FILES applets/taskmanager/package/contents/ui/ContextMenu.qml applets/taskmanager/package/contents/ui/Task.qml applets/taskmanager/package/contents/ui/ToolTipDelegate.qml applets/taskmanager/package/contents/ui/ToolTipWindowMouseArea.qml applets/taskmanager/package/contents/ui/main.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: subdiff, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
