davidedmundson added inline comments.

INLINE COMMENTS

> graesslin wrote in scene_qpainter_test.cpp:202-203
> the idea of the Test::createShellSurface variant returning a QObject is to 
> have a test_data() with the two supported modes, so that we test both WlShell 
> and XdgShellUnstableV5. You can compare with other tests.
> 
> If you want to only test WlShell there is a simplified setup method returning 
> a ShellSurface instead of QObject.

I don't really need a shell surface at all, I can just remove this.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D3495

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, graesslin
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Reply via email to