[Differential] [Commented On] D3132: [platformx/x11] Add a freeze protection against OpenGL

2016-10-24 Thread antlarr (Antonio Larrosa Jimenez)
antlarr added a comment. I don't know why, but it seems arc diff doesn't work anymore and I have to use arc diff HEAD~7 to include all 7 commits REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3132 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpr

[Differential] [Updated, 63 lines] D3132: [platformx/x11] Add a freeze protection against OpenGL

2016-10-24 Thread antlarr (Antonio Larrosa Jimenez)
antlarr updated this revision to Diff 7644. antlarr added a comment. Restricted Application edited projects, added Plasma; removed KWin. Include all 7 commits REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3132?vs=7638&id=7644 BRANCH arcpatch-D3127_1 REVI

Re: breakout: what Qt version will 5.9 require? 5.6 still or 5.7?

2016-10-24 Thread Martin Graesslin
On Thursday, October 20, 2016 7:07:29 AM CEST Sebastian Kügler wrote: > On Monday, October 17, 2016 6:06:41 PM UTC Jonathan Riddell wrote: > > no discussion on this on during the meeting, do we need 5.7, are > > distros happy with 5.7? > > We discussed it in the other thread, the conclusion is tha

[Differential] [Request, 86 lines] D3154: Send a pointer leave when triggering a move resize

2016-10-24 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland, broulik. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY When triggering a move resize all following pointer events

[Differential] [Commented On] D3132: [platformx/x11] Add a freeze protection against OpenGL

2016-10-24 Thread Martin Gräßlin
graesslin added a comment. The latest patch version seems to not include all changes. REVISION DETAIL https://phabricator.kde.org/D3132 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: antlarr, #kwin, #plasma, davidedmundson Cc: luebking, graesslin, kwin

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 523 - Still Unstable!

2016-10-24 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/523/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 25 Oct 2016 04:12:04 + Build duration: 10 min CHANGE SET Revision 26e5a7bc4c9df555d067ef4c15ef87c4d1

[Differential] [Closed] D3130: Improve Activity Pager Layout for horizontal and vertical cases

2016-10-24 Thread hein (Eike Hein)
hein closed this revision. hein added a comment. Committed: http://commits.kde.org/plasma-desktop/2a5580d486acb1754913b17c19409b66ddec4d84 REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3130 EMAIL PREFERENCES https://phabricator.kde.org/settings/

[Differential] [Updated] D3130: Improve Activity Pager Layout for horizontal and vertical cases

2016-10-24 Thread mvourlakos (Michail Vourlakos)
mvourlakos marked an inline comment as done. mvourlakos added a comment. In https://phabricator.kde.org/D3130#58614, @hein wrote: > Good showing then :) > > I'll commit for you (with your name); make sure to consider applying for dev access a couple of patches in. Check out https://p

[Differential] [Commented On] D3130: Improve Activity Pager Layout for horizontal and vertical cases

2016-10-24 Thread hein (Eike Hein)
hein added a comment. Good showing then :) I'll commit for you (with your name); make sure to consider applying for dev access a couple of patches in. Check out https://phabricator.kde.org/tag/plasma/ on freenode IRC, too! REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL ht

Re: Review Request 129255: Fixed unrar version check.

2016-10-24 Thread Massimiliano Torromeo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129255/ --- (Updated Ott. 24, 2016, 9:27 p.m.) Review request for Plasma. Bugs: 341

Review Request 129255: Fixed unrar version check.

2016-10-24 Thread Massimiliano Torromeo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129255/ --- Review request for Plasma. Repository: kio-extras Description ---

[Differential] [Changed Subscribers] D3130: Improve Activity Pager Layout for horizontal and vertical cases

2016-10-24 Thread davidedmundson (David Edmundson)
davidedmundson added inline comments. INLINE COMMENTS > mvourlakos wrote in main.qml:199 > Hein, is there a way in QML to generate proper enums from config? there is not (currently) REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3130 EMAIL PREFERENCE

[Differential] [Updated] D3130: Improve Activity Pager Layout for horizontal and vertical cases

2016-10-24 Thread mvourlakos (Michail Vourlakos)
mvourlakos marked 2 inline comments as done. mvourlakos added a comment. In https://phabricator.kde.org/D3130#58604, @hein wrote: > Do you have commit access? unfortunately not yet... this is my first patch for plasma... INLINE COMMENTS > hein wrote in main.qml:199 > Please add

[Differential] [Accepted] D3130: Improve Activity Pager Layout for horizontal and vertical cases

2016-10-24 Thread hein (Eike Hein)
hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Do you have commit access? REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3130 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpr

[Differential] [Updated, 46 lines] D3130: Improve Activity Pager Layout for horizontal and vertical cases

2016-10-24 Thread mvourlakos (Michail Vourlakos)
mvourlakos updated this revision to Diff 7641. mvourlakos added a comment. updated in needed changes REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3130?vs=7602&id=7641 REVISION DETAIL https://phabricator.kde.org/D3130 AFFECTED FILES

[Differential] [Commented On] D2314: Context Menu to Mute, Set Default Sink/Source, Active Port

2016-10-24 Thread davidedmundson (David Edmundson)
davidedmundson added a comment. Edit: sorry didn't see drosca replied. Wait till the VDG reply before doing any changes (as you don't want it to be wasted) REPOSITORY rPLASMAPA Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D2314 EMAIL PREFERENCES https://ph

[Differential] [Commented On] D2314: Context Menu to Mute, Set Default Sink/Source, Active Port

2016-10-24 Thread davidedmundson (David Edmundson)
davidedmundson added a comment. Do we need to do it programatically? It's should be do-able in a declarative way with Instantiator ContextMenu { MenuItem { text: i18n("Mute"); ... } MenuItem { text: i18n("Default"); visible

[Differential] [Accepted] D3141: systemmonitor: Optimise source updates.

2016-10-24 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH systemmonitor_perf REVISION DETAIL https://phabricator.kde.org/D3141 EMAIL PREFERENCES https://pha

[Differential] [Requested Changes To] D3130: Improve Activity Pager Layout for horizontal and vertical cases

2016-10-24 Thread hein (Eike Hein)
hein requested changes to this revision. hein added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > main.qml:196 > > -var columns = Math.floor(pagerModel.count / > pagerModel.layoutRows); > +var rows=1; > + There's a lot of small codin

[Differential] [Changed Subscribers] D2314: Context Menu to Mute, Set Default Sink/Source, Active Port

2016-10-24 Thread drosca (David Rosca)
drosca added subscribers: colomar, drosca. drosca added a comment. @colomar Can you please comment on this? We have been talking about using a context menu in plasmoid, but I don't remember what was the final decision from the VDG? REPOSITORY rPLASMAPA Plasma Audio Volume Applet REVISION

[Differential] [Updated] D3130: Improve Activity Pager Layout for horizontal and vertical cases

2016-10-24 Thread Ivan Čukić
ivan added a reviewer: mart. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3130 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mvourlakos, #plasma, hein, mart Cc: mvourlakos, plasma-devel, lesliezhai, ali-mohamed,

[Differential] [Closed] D3083: Mute volume when decreasing volume to zero

2016-10-24 Thread drosca (David Rosca)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAPA6366791aaa50: Mute volume when decreasing volume to zero (authored by drosca). REPOSITORY rPLASMAPA Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3083?vs=74

[Differential] [Updated] D3132: [platformx/x11] Add a freeze protection against OpenGL

2016-10-24 Thread antlarr (Antonio Larrosa Jimenez)
antlarr marked 5 inline comments as done. antlarr added a comment. All issues done REVISION DETAIL https://phabricator.kde.org/D3132 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: antlarr, #kwin, #plasma, davidedmundson Cc: luebking, graesslin, kwin, p

[Differential] [Updated, 10 lines] D3132: [platformx/x11] Add a freeze protection against OpenGL

2016-10-24 Thread antlarr (Antonio Larrosa Jimenez)
antlarr updated this revision to Diff 7638. antlarr added a comment. Restricted Application edited projects, added KWin; removed Plasma. - Only call PostLastGuardedFrame when OpenGLCompositing is set CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3132?vs=7637&id=7638 BRANCH arcpat

[Differential] [Commented On] D3132: [platformx/x11] Add a freeze protection against OpenGL

2016-10-24 Thread antlarr (Antonio Larrosa Jimenez)
antlarr added inline comments. INLINE COMMENTS > luebking wrote in x11_platform.cpp:206 > PreFrame is (now) effectively "PreFirstGuardedFrame", is it? > And if invoked at some later point would create the timer and hit the config > rewrite every single frame (for the counter is stuck at 0)? > >

[Differential] [Commented On] D3132: [platformx/x11] Add a freeze protection against OpenGL

2016-10-24 Thread Martin Gräßlin
graesslin added inline comments. INLINE COMMENTS > composite.cpp:748 > +m_framesToTestForSafety--; > + if (m_framesToTestForSafety == 0) { > + > kwinApp()->platform()->createOpenGLSafePoint(Platform::OpenGLSafePoint::PostLastGuardedFrame); this misses the if (m_scene->

[Differential] [Commented On] D3132: [platformx/x11] Add a freeze protection against OpenGL

2016-10-24 Thread Thomas Lübking
luebking added inline comments. INLINE COMMENTS > graesslin wrote in composite.cpp:748 > this misses the > > if (m_scene->compositingType() & OpenGLCompositing) also indention. > x11_platform.cpp:206 > +// Deliberately continue with PreFrame > +case OpenGLSafePoint::PreFrame: > +

[Differential] [Updated, 65 lines] D3132: [platformx/x11] Add a freeze protection against OpenGL

2016-10-24 Thread antlarr (Antonio Larrosa Jimenez)
antlarr updated this revision to Diff 7637. antlarr added a comment. Restricted Application edited projects, added Plasma; removed KWin. Include all 6 commits REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3132?vs=7636&id=7637 BRANCH arcpatch-D3127_1 REVI

[Differential] [Updated, 63 lines] D3132: [platformx/x11] Add a freeze protection against OpenGL

2016-10-24 Thread antlarr (Antonio Larrosa Jimenez)
antlarr updated this revision to Diff 7636. antlarr marked 21 inline comments as done. antlarr added a comment. Restricted Application edited projects, added KWin; removed Plasma. - Use only one timer to detect freezes and other optimizations - Test 3 frames for freezes by default CHANGES SI

[Breeze] [Bug 370374] GRUB menu has huge lag due to theme

2016-10-24 Thread Harald Sitter via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=370374 --- Comment #9 from Harald Sitter --- If everyone used refind we'd all be happier for it ;) -- You are receiving this mail because: You are the assignee for the bug.

[Breeze] [Bug 370374] GRUB menu has huge lag due to theme

2016-10-24 Thread Kai Uwe Broulik via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=370374 Kai Uwe Broulik changed: What|Removed |Added CC||k...@privat.broulik.de --- Comment #8 from Ka

[Breeze] [Bug 370374] GRUB menu has huge lag due to theme

2016-10-24 Thread Harald Sitter via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=370374 Harald Sitter changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|---

[Breeze] [Bug 370374] GRUB menu has huge lag due to theme

2016-10-24 Thread Roman via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=370374 --- Comment #6 from Roman --- Of course somebody else has reported it already: http://savannah.gnu.org/bugs/?46133 There is no mention of a theme as the issue, but one of the links is to the redhat bug, I posted earlier. If this is a common problem, as

[Differential] [Abandoned] D3078: Add new DBus method for applet de-/activation and in order to fix non-closing launchers on Meta (and also on Active Screenedges)

2016-10-24 Thread subdiff (Roman Gilg)
subdiff abandoned this revision. subdiff added a comment. Abandoned because we now use the other solution in https://git.reviewboard.kde.org/r/129204/ making this diff not necessary anymore. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3078

[Differential] [Accepted] D3152: [Task Manager] Return early if there's no launcherUrl

2016-10-24 Thread hein (Eike Hein)
hein accepted this revision. hein added a reviewer: hein. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3152 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik,

[Differential] [Request, 4 lines] D3152: [Task Manager] Return early if there's no launcherUrl

2016-10-24 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Otherwise it throws "Cannot ca

[Differential] [Request, 2 lines] D3151: Trigger resize of input window when deco size changes

2016-10-24 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Client::updateInputWindow operates with the decoration size. The method gets called from variou

Minutes Monday Plasma Meeting

2016-10-24 Thread Sebastian Kügler
Plasma meeting (IRC), 24-10-2016 Present: mgraesslin, romangg, bshah, d_ed, Sho, sebas mgraesslin: * move windows in widget style oxygen (D3096) Diff 3096 "[kstyle] Implement window moving on Wayland" [Closed] https:// phabricator.kde.org/D3096 * New KWin internal API to get current cursor image

[Differential] [Closed] D3102: Do not ask for root permissions when it's unnecessary

2016-10-24 Thread antlarr (Antonio Larrosa Jimenez)
antlarr closed this revision. REPOSITORY rUSERMANAGER User Manager REVISION DETAIL https://phabricator.kde.org/D3102 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: antlarr, #plasma, davidedmundson Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreu

Jenkins-kde-ci: khotkeys master kf5-qt5 » Linux,gcc - Build # 22 - Failure!

2016-10-24 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/khotkeys%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/22/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 24 Oct 2016 09:37:08 + Build duration: 2 min 54 sec CHANGE SET Revision 9eff3e61bb364af5e2dedae298b15fda71bc91

[Breeze] [Bug 370374] GRUB menu has huge lag due to theme

2016-10-24 Thread Harald Sitter via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=370374 --- Comment #5 from Harald Sitter --- Well, if that is the case then I guess you should be filing a bug with GRUB, not the theme? -- You are receiving this mail because: You are the assignee for the bug.

[Breeze] [Bug 370374] GRUB menu has huge lag due to theme

2016-10-24 Thread Roman via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=370374 Roman changed: What|Removed |Added Resolution|WAITINGFORINFO |--- Status|NEEDSINFO |UNC

[Breeze] [Bug 370981] Can't enter LUKS password

2016-10-24 Thread Viorel-Cătălin Răpițeanu via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=370981 Viorel-Cătălin Răpițeanu changed: What|Removed |Added CC||rapiteanu.cata...@gmail.com --- Comm

[Breeze] [Bug 370981] Can't enter LUKS password

2016-10-24 Thread Harald Sitter via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=370981 Harald Sitter changed: What|Removed |Added Resolution|--- |DOWNSTREAM Status|UNCONFIRMED

[Breeze] [Bug 370981] Can't enter LUKS password

2016-10-24 Thread Martin Kyral via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=370981 Martin Kyral changed: What|Removed |Added CC||sine.nom...@centrum.cz --- Comment #1 from Marti

[Differential] [Request, 6 lines] D3150: [server] Fix crash on updating focused keyboard surface

2016-10-24 Thread Martin Gräßlin
graesslin created this revision. graesslin added a reviewer: Plasma on Wayland. Restricted Application added a subscriber: plasma-devel. Restricted Application added a project: Plasma on Wayland. REVISION SUMMARY In case the current selection does not have a DataSourceInterface updating the fo

[Differential] [Request, 96 lines] D3149: [server] Fix possible crash on creation of DataDevice

2016-10-24 Thread Martin Gräßlin
graesslin created this revision. graesslin added a reviewer: Plasma on Wayland. Restricted Application added a subscriber: plasma-devel. Restricted Application added a project: Plasma on Wayland. REVISION SUMMARY This is a similar condition as https://phabricator.kde.org/D3148. If a DataDeviceI

[Differential] [Request, 49 lines] D3148: [server] Ensure we have a DataSource on the DataDevice in setSelection

2016-10-24 Thread Martin Gräßlin
graesslin created this revision. graesslin added a reviewer: Plasma on Wayland. Restricted Application added a subscriber: plasma-devel. Restricted Application added a project: Plasma on Wayland. REVISION SUMMARY SeatInterface provides a way to set the current selection. This method did not ve

[Differential] [Commented On] D3132: [platformx/x11] Add a freeze protection against OpenGL

2016-10-24 Thread Martin Gräßlin
graesslin added inline comments. INLINE COMMENTS > antlarr wrote in x11_platform.cpp:229-232 > Do you prefer to merge PostInit with PostFrame or with PostLastGuardedFrame? > The difference would be that if it's merged with PostFrame and a user sets > KWIN_MAX_FRAMES_TESTED to 0 (so no freeze de

[Differential] [Commented On] D3132: [platformx/x11] Add a freeze protection against OpenGL

2016-10-24 Thread antlarr (Antonio Larrosa Jimenez)
antlarr added inline comments. INLINE COMMENTS > graesslin wrote in composite.h:242 > I would just count down the m_maxFramesTestedForSafety till it reaches 0 ok > graesslin wrote in x11_platform.cpp:215 > You can use QMetaObject::invokeMethod with Qt::QueuedConnection. Oh, I thought QueuedCon