graesslin added inline comments. INLINE COMMENTS
> antlarr wrote in x11_platform.cpp:229-232 > Do you prefer to merge PostInit with PostFrame or with PostLastGuardedFrame? > The difference would be that if it's merged with PostFrame and a user sets > KWIN_MAX_FRAMES_TESTED to 0 (so no freeze detection is done when painting > frames) then the detection thread and timer wouldn't be deleted and if it's > merged with PostLastGuardedFrame, then a new thread and timer will be created > for the frame drawing. I would merge it with PostFrame, since it requires a > user who probably knows what he's doing to interact and is more optimized for > 99.9999% of cases, and still an idle thread and stopped timer shouldn't > consume any resources in the rare case a user sets that, but I ask just in > case. yep, agree. REVISION DETAIL https://phabricator.kde.org/D3132 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: antlarr, #kwin, #plasma, davidedmundson Cc: luebking, graesslin, kwin, plasma-devel, davidedmundson, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
