mvourlakos marked 2 inline comments as done. mvourlakos added a comment.
In https://phabricator.kde.org/D3130#58604, @hein wrote: > Do you have commit access? unfortunately not yet... this is my first patch for plasma... INLINE COMMENTS > hein wrote in main.qml:199 > Please add comments like /* Horizontal */ into the conditions for readability > (I wish we could generate proper enums from config ...). Hein, is there a way in QML to generate proper enums from config? REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3130 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mvourlakos, mart, hein, #plasma Cc: mvourlakos, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas