Jenkins-kde-ci: oxygen-icons5 master stable-kf5-qt5 » Linux,gcc - Build # 62 - Failure!

2016-10-07 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/oxygen-icons5%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/62/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 08 Oct 2016 06:51:40 + Build duration: 31 sec CHANGE SET No changes

Jenkins-kde-ci: oxygen-icons5 master kf5-qt5 » Linux,gcc - Build # 64 - Failure!

2016-10-07 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/oxygen-icons5%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/64/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 08 Oct 2016 06:44:48 + Build duration: 36 sec CHANGE SET No changes

[Differential] [Updated] D2984: Center the notification label on Breeze's lockscreen and make it use the full width before wrapping

2016-10-07 Thread pritambaral (Pritam Baral)
pritambaral updated the test plan for this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2984 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: pritambaral, #plasma Cc: pritambaral, plasma-devel, leslie

[Differential] [Request, 2 lines] D2984: Center the notification label on Breeze's lockscreen and make it use the full width before wrapping

2016-10-07 Thread pritambaral (Pritam Baral)
pritambaral created this revision. pritambaral added a reviewer: Plasma. pritambaral set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Fixes https:/

[Differential] [Request, 97 lines] D2983: Support solid colour and image backgrounds with a configurable background colour in the SDDM theme

2016-10-07 Thread bgupta (Boudhayan Gupta)
bgupta created this revision. bgupta added a reviewer: davidedmundson. bgupta set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This patch reworks t

Re: Review Request 129118: Remove discovery associated to a key when removing a definition

2016-10-07 Thread Antonio Larrosa Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129118/ --- (Updated Oct. 7, 2016, 5:03 p.m.) Status -- This change has been mar

Re: Review Request 129118: Remove discovery associated to a key when removing a definition

2016-10-07 Thread Antonio Larrosa Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129118/ --- (Updated Oct. 7, 2016, 4:39 p.m.) Review request for KDE Frameworks and P

[Differential] [Request, 10 lines] D2981: Removes preferred definition so a new wallpaper is selected.

2016-10-07 Thread antlarr (Antonio Larrosa Jimenez)
antlarr created this revision. antlarr added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Removes preferred definition so a new wallpaper is selected. Also, just in case, check for division by 0.

Re: Review Request 129118: Remove discovery associated to a key when removing a definition

2016-10-07 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129118/#review99839 --- Ship it! Ship It! - Sebastian Kügler On Oct. 7, 2016, 4

Review Request 129118: Remove discovery associated to a key when removing a definition

2016-10-07 Thread Antonio Larrosa Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129118/ --- Review request for KDE Frameworks and Plasma. Repository: kpackage Desc

Re: Review Request 129102: Don't enforce metadata.desktop, cleanup constructor

2016-10-07 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129102/ --- (Updated Oct. 7, 2016, 5:23 p.m.) Review request for KDE Frameworks and P

[Differential] [Request, 36 lines] D2980: Add event filter for key press/release events while KWin grabbed keyboard on root window

2016-10-07 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY The modifier-only-shortcuts break as soon as KWin grabs the keyboard (e.g. alt+tab, present win

[Differential] [Closed] D2976: Create new session if appropriate when hitting enter on lock screen

2016-10-07 Thread davidedmundson (David Edmundson)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE8aaa3e3e48fe: Create new session if appropriate when hitting enter on lock screen (authored by davidedmundson). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE ht

[Differential] [Closed] D2972: Allow configuring script's screen edges from the KCM

2016-10-07 Thread davidedmundson (David Edmundson)
This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN4bb12f3f010d: Allow configuring script's screen edges from the KCM (authored by davidedmundson). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2972?vs=7193&id=7200

[Differential] [Accepted] D2976: Create new session if appropriate when hitting enter on lock screen

2016-10-07 Thread broulik (Kai Uwe Broulik)
broulik accepted this revision. broulik added a reviewer: broulik. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D2976 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/e

[Differential] [Accepted] D2972: Allow configuring script's screen edges from the KCM

2016-10-07 Thread Martin Gräßlin
graesslin accepted this revision. graesslin added a reviewer: graesslin. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D2972 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmunds

[Breeze] [Bug 370248] The Person Widget is using the Desktop icon in ...

2016-10-07 Thread Aaron Honeycutt via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=370248 Aaron Honeycutt changed: What|Removed |Added Component|general |Icons Assignee|plasma-devel@kde.org

[Differential] [Updated] D2979: Support for relative pointer motion events

2016-10-07 Thread Martin Gräßlin
graesslin added a dependency: D2978: Implement support for the relative pointer protocol. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D2979 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland Cc: pl

[Differential] [Request, 136 lines] D2979: Support for relative pointer motion events

2016-10-07 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY If KWin interacts with Libinput the RelativePointerManager interface

[Differential] [Updated] D2978: Implement support for the relative pointer protocol

2016-10-07 Thread Martin Gräßlin
graesslin added a dependent revision: D2979: Support for relative pointer motion events. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D2978 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma Cc: plasma-devel,

[Breeze] [Bug 370248] The Person Widget is using the Desktop icon in ...

2016-10-07 Thread Aaron Honeycutt via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=370248 Aaron Honeycutt changed: What|Removed |Added Platform|Other |Kubuntu Packages -- You are receiving this m

[Breeze] [Bug 370248] New: The Person Widget is using the Desktop icon in ...

2016-10-07 Thread Aaron Honeycutt via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=370248 Bug ID: 370248 Summary: The Person Widget is using the Desktop icon in ... Product: Breeze Version: 5.7.5 Platform: Other OS: Linux Status: UNCONFIRMED Severity:

[Differential] [Closed] D2977: Use KPackage in kcmscripts

2016-10-07 Thread davidedmundson (David Edmundson)
This revision was automatically updated to reflect the committed changes. Closed by commit rKWINb1e76ed8c461: Use KPackage in kcmscripts (authored by davidedmundson). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2977?vs=7194&id=7196 REVISION DETAIL https://

[Differential] [Accepted] D2977: Use KPackage in kcmscripts

2016-10-07 Thread Martin Gräßlin
graesslin accepted this revision. graesslin added a reviewer: graesslin. graesslin added a comment. This revision is now accepted and ready to land. {hugs} - thanks a lot! I actually didn't expect to port this one. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/

[Differential] [Request, 1,241 lines] D2978: Implement support for the relative pointer protocol

2016-10-07 Thread Martin Gräßlin
graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma on Wayland. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This change implements the zwp_relative_pointer_v1 protocol which allows to send relative mo

[Differential] [Request, 19 lines] D2977: Use KPackage in kcmscripts

2016-10-07 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. TEST PLAN Tested all but show OSD appeared REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kd

[Differential] [Updated, 48 lines] D2972: Allow configuring script's screen edges from the KCM

2016-10-07 Thread davidedmundson (David Edmundson)
davidedmundson updated this revision to Diff 7193. davidedmundson added a comment. Restricted Application edited projects, added Plasma; removed KWin. fixup REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2972?vs=7191&id=7193 REVISION DETAIL https://phabric

[Differential] [Closed] D2967: delete containments upon activity deletion

2016-10-07 Thread mart (Marco Martin)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE921722093048: delete containments upon activity deletion (authored by mart). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2967?vs=

[Differential] [Accepted] D2967: delete containments upon activity deletion

2016-10-07 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH phab/deleteactivity REVISION DETAIL https://phabricator.kde.org/D2967 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences

[Differential] [Updated] D2976: Create new session if appropriate when hitting enter on lock screen

2016-10-07 Thread davidedmundson (David Edmundson)
davidedmundson added a comment. In https://phabricator.kde.org/D2976#55250, @mart wrote: > like it better than emitting a button click. > > but wasn't also a problem of it being implemented theme-side? That was https://phabricator.kde.org/D2957 REPOSITORY rPLASMAWORKSPACE Pl

[Differential] [Commented On] D2976: Create new session if appropriate when hitting enter on lock screen

2016-10-07 Thread mart (Marco Martin)
mart added a comment. like it better than emitting a button click. but wasn't also a problem of it being implemented theme-side? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2976 EMAIL PREFERENCES https://phabricator.kde.org/settings/pa

[Differential] [Updated, 48 lines] D2972: Allow configuring script's screen edges from the KCM

2016-10-07 Thread davidedmundson (David Edmundson)
davidedmundson updated this revision to Diff 7191. davidedmundson added a comment. Restricted Application edited projects, added KWin; removed Plasma. Use KPackage for loading REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2972?vs=7187&id=7191 REVISION DETAI

[Differential] [Commented On] D2967: delete containments upon activity deletion

2016-10-07 Thread mart (Marco Martin)
mart added a comment. In https://phabricator.kde.org/D2967#55233, @davidedmundson wrote: > But it also tracks them and deletes when an object is removed: > ShellCorona::desktopContainmentDestroyed > > If you manually do it as well you're throwing all sense of a design pattern out t

[Differential] [Updated, 5 lines] D2967: delete containments upon activity deletion

2016-10-07 Thread mart (Marco Martin)
mart updated this revision to Diff 7189. mart added a comment. - remove duplicate remove REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2967?vs=7159&id=7189 BRANCH phab/deleteactivity REVISION DETAIL https://phabricator.kde.org/D2

[Differential] [Request, 8 lines] D2976: Create new session if appropriate when hitting enter on lock screen

2016-10-07 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Alternate fix for https://phabricator.kde.org/D2956 [Lock Screen] When pressing Return just tr

[Differential] [Commented On] D2972: Allow configuring script's screen edges from the KCM

2016-10-07 Thread Martin Gräßlin
graesslin added inline comments. INLINE COMMENTS > davidedmundson wrote in main.cpp:212 > it's copy paste from kcm_kwinscripts > > If you are doing that in kwin you have a bug as you're ignoring the > KWin-Exclude-Listing flag and potentially loading things that you can't > configure. > If yo

[Differential] [Commented On] D2967: delete containments upon activity deletion

2016-10-07 Thread davidedmundson (David Edmundson)
davidedmundson added a comment. But it also tracks them and deletes when an object is removed: ShellCorona::desktopContainmentDestroyed If you manually do it as well you're throwing all sense of a design pattern out the window and having it sometimes update the list before removal, so

[Differential] [Commented On] D2967: delete containments upon activity deletion

2016-10-07 Thread mart (Marco Martin)
mart added a comment. In https://phabricator.kde.org/D2967#55135, @davidedmundson wrote: > > m_desktopContainments.remove(id); > > should not be here. why not? m_desktopContainments is a QHash > indexed by activity, if i don't update it manually here, it will stay full of dan

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 410 - Failure!

2016-10-07 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/410/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 07 Oct 2016 09:32:35 + Build duration: 3 min 15 sec CHANGE SET Revision ad9c897baa328bc3c318e4ba308d950

[Differential] [Updated, 42 lines] D2972: Allow configuring script's screen edges from the KCM

2016-10-07 Thread davidedmundson (David Edmundson)
davidedmundson updated this revision to Diff 7187. davidedmundson added a comment. Restricted Application edited projects, added Plasma; removed KWin. foreach -> for REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2972?vs=7170&id=7187 REVISION DETAIL https:

[Differential] [Commented On] D2972: Allow configuring script's screen edges from the KCM

2016-10-07 Thread davidedmundson (David Edmundson)
davidedmundson added inline comments. INLINE COMMENTS > graesslin wrote in main.cpp:212 > Why are you querying KService? Scripts are packages and at least KWin > internally they are queried using: > > > KPackage::PackageLoader::self()->listPackages(QStringLiteral("KWin/Script"), > scriptFol

[Differential] [Commented On] D2975: [shell] Event compress resizePanel

2016-10-07 Thread bshah (Bhushan Shah)
bshah added a comment. In https://phabricator.kde.org/D2975#55224, @mart wrote: > can it use QQmlParserStatus instead? Idea of using QQmlParserStatus is fine and it might save some cycles at start but problem remains same when I move panel around.. I don't think QQmlParser status

[Differential] [Commented On] D2975: [shell] Event compress resizePanel

2016-10-07 Thread mart (Marco Martin)
mart added a comment. can it use QQmlParserStatus instead? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2975 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bshah, #plasma Cc: mart, hein, plasma-devel, les

Re: Plasma 5.9 Kickoff Meeting

2016-10-07 Thread Jonathan Riddell
Winner is Monday at 11:00UTC, 12:00midday BST and 13:00CEST See you then http://doodle.com/poll/rp5e7gffkdhf87hs Jonathan On 6 October 2016 at 20:52, Alex L. wrote: > On mercoledì 5 ottobre 2016 14:12:51 CEST Jonathan Riddell wrote: >> What was good about 5.8? What would you like to see in 5.9?

[Differential] [Commented On] D2975: [shell] Event compress resizePanel

2016-10-07 Thread hein (Eike Hein)
hein added a comment. 100% no. Timers with magic timeout values are a "let's hope it works out if we wait a bit" anti-pattern to paper over figuring out proper update logic. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2975 EMAIL PREFERENCES

[Differential] [Request, 18 lines] D2975: [shell] Event compress resizePanel

2016-10-07 Thread bshah (Bhushan Shah)
bshah created this revision. bshah added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY At startup and as well when one moves panel, resizePanel is called multiple times. For instance, at startup res

[Differential] [Closed] D2963: [server] Send key events to all wl_keyboard resources of a client

2016-10-07 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLAND862bb68e4a0e: [server] Send key events to all wl_keyboard resources of a client (authored by graesslin). REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29