----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129102/ -----------------------------------------------------------
(Updated Oct. 7, 2016, 5:23 p.m.) Review request for KDE Frameworks and Plasma. Changes ------- address David's remarks Repository: plasma-framework Description ------- Makes it possible to use plugins that offer a metadata.json file. Define the service type when falling back to the desktop file parser, so the type system is proper. Don't destroy a KPluginMetadata tuple to instanciate it right away. Diffs (updated) ----- src/plasma/applet.cpp 5eb529c src/plasma/containment.h 0b7a3ef src/plasma/containment.cpp 1840f24 src/plasma/pluginloader.h 566461d src/plasma/pluginloader.cpp db2b2c9 src/plasma/private/applet_p.cpp fafb450 Diff: https://git.reviewboard.kde.org/r/129102/diff/ Testing ------- Tests still pass, plasma still loads, even with RR #129103. Thanks, Aleix Pol Gonzalez
