----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129118/ -----------------------------------------------------------
(Updated Oct. 7, 2016, 5:03 p.m.) Status ------ This change has been marked as submitted. Review request for KDE Frameworks and Plasma. Repository: kpackage Description ------- Plasmashell was calling Package::removeDefinition but a later call to Package::filePath still returned a value because there was an entry in d->discoveries but no way to remove it, which made plasma use old values. Diffs ----- src/kpackage/package.cpp 363a67ed5b7c592aea4845b84ca05e63da05991a Diff: https://git.reviewboard.kde.org/r/129118/diff/ Testing ------- I gdb'd a patched plasmashell (1) to fix a wallpaper aspect ratio problem while changing the screen resolution between 1024x768 and 1280x720 and tracing Image::findPreferedImageInPackage . package.filePath("preferred") is not empty at the beginning of the method even if package.removeDefinition("preferred") was just called, so it seems the key should be removed from d->discoveries too. (1) The plasma patch is at https://phabricator.kde.org/D2981 Thanks, Antonio Larrosa Jimenez
