Can the svg versions for icons can be used for sizes < 64px?

2016-09-09 Thread Michail Vourlakos
Hello everyone, I am using in my plasmoid PlasmaCore.IconItems which behave in a very specific way for icons sizes below 64px, by using (best match mechanism). Unfortunately in my plasmoid (Now Dock) this does not work very well in some cases because a icon for 38px. or 56px. is needed for ex

Re: Review Request 128552: Italicise the name of symlink in folder view plasmoid

2016-09-09 Thread Chinmoy Ranjan Pradhan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128552/ --- (Updated Sept. 10, 2016, 5:47 a.m.) Review request for Plasma and Eike He

Re: Plasma 5.7.4 is out

2016-09-09 Thread Andreas Müller
On Tue, Aug 23, 2016 at 6:46 PM, David Edmundson wrote: > https://www.kde.org/announcements/plasma-5.7.4.php > > Regards > > David I did not find anything in announcement: What happened to plasma-mediacenter? Andreas

Re: Review Request 128802: task bar lines

2016-09-09 Thread Andreas Kainz
> On Sept. 9, 2016, 1:24 nachm., David Rosca wrote: > > You can't tell apart launcher and normal task now, they look exactly the > > same (just icon, no line). > > Kai Uwe Broulik wrote: > Aw, crap. Right. For Icon Tasks there's no label for the active windows. > > Marco Martin wrote: >

another point on outdated KDE/Plasma websites

2016-09-09 Thread Marco Martin
Hi all, besides the outdated kde.org website in dire need for a redesign, i came across at this https://bugs.kde.org/show_bug.cgi?id=368475 the problem is actually that the url http://plasma.kde.org doesn't work anymore should it be made just a redirect to https://www.kde.org/workspaces/plasma

[Differential] [Commented On] D2589: Make the AbstractListItem a Rectangle

2016-09-09 Thread mart (Marco Martin)
mart added a comment. ping, push? REPOSITORY rKIRIGAMI Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D2589 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc: plasma-devel, apol

[Differential] [Closed] D2726: Make kpackage_install_package work with KDE_INSTALL_DIRS_NO_DEPRECATED

2016-09-09 Thread kossebau (Friedrich W. H. Kossebau)
kossebau closed this revision. kossebau added a comment. Submitted as http://commits.kde.org/kpackage/cf70d380d7a9b2207f8e83e02d36db42a47c85ca and parents REVISION DETAIL https://phabricator.kde.org/D2726 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To

[Differential] [Request, 11 lines] D2730: [Task Manager] Use Qt.binding for prefix

2016-09-09 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Bind prefix directly and onRep

Re: Review Request 128802: task bar lines

2016-09-09 Thread David Rosca
> On Sept. 9, 2016, 1:24 p.m., David Rosca wrote: > > You can't tell apart launcher and normal task now, they look exactly the > > same (just icon, no line). > > Kai Uwe Broulik wrote: > Aw, crap. Right. For Icon Tasks there's no label for the active windows. > > Marco Martin wrote: >

[Differential] [Request, 14 lines] D2729: Don't constrain width of Text field on translated text

2016-09-09 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This caused it to be cropped on some translations. This patch only sets the minimum size t

Re: Review Request 128802: task bar lines

2016-09-09 Thread Marco Martin
> On Sept. 9, 2016, 1:24 p.m., David Rosca wrote: > > You can't tell apart launcher and normal task now, they look exactly the > > same (just icon, no line). > > Kai Uwe Broulik wrote: > Aw, crap. Right. For Icon Tasks there's no label for the active windows. > > Marco Martin wrote: >

[Differential] [Accepted] D2728: [Desktop View] Remove unused "wallpaper" propert

2016-09-09 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2728 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/e

[Differential] [Request, 10 lines] D2728: [Desktop View] Remove unused "wallpaper" propert

2016-09-09 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The wallpaper seems to be atta

Re: Review Request 128802: task bar lines

2016-09-09 Thread Marco Martin
> On Sept. 9, 2016, 1:24 p.m., David Rosca wrote: > > You can't tell apart launcher and normal task now, they look exactly the > > same (just icon, no line). > > Kai Uwe Broulik wrote: > Aw, crap. Right. For Icon Tasks there's no label for the active windows. yes, there should be a line fo

[Differential] [Commented On] D2693: Standardize Drawer width

2016-09-09 Thread mart (Marco Martin)
mart added a comment. seems to be ok in android, so good to go when it's made a standalone diff REPOSITORY rKIRIGAMI Kirigami REVISION DETAIL https://phabricator.kde.org/D2693 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc:

[Differential] [Requested Changes To] D2693: Standardize Drawer width

2016-09-09 Thread mart (Marco Martin)
mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. it's based upon https://phabricator.kde.org/D2580, can you rebase this upon master? REPOSITORY rKIRIGAMI Kirigami REVISION DETAIL https://phabricator.kde.org/D2693 EMAIL PREFERE

Re: Review Request 128802: task bar lines

2016-09-09 Thread Kai Uwe Broulik
> On Sept. 9, 2016, 1:24 nachm., David Rosca wrote: > > You can't tell apart launcher and normal task now, they look exactly the > > same (just icon, no line). Aw, crap. Right. For Icon Tasks there's no label for the active windows. - Kai Uwe

[Differential] [Closed] D2723: port panel loading away from ksycoca

2016-09-09 Thread mart (Marco Martin)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE30a874c89cd7: port panel loading away from ksycoca (authored by mart). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2723?vs=6600&i

[Differential] [Updated, 19 lines] D2723: port panel loading away from ksycoca

2016-09-09 Thread mart (Marco Martin)
mart updated this revision to Diff 6600. mart added a comment. - pass layout by reference REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2723?vs=6584&id=6600 BRANCH phab/nococa REVISION DETAIL https://phabricator.kde.org/D2723 AF

Re: Review Request 128802: task bar lines

2016-09-09 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128802/#review99025 --- You can't tell apart launcher and normal task now, they look

[Differential] [Accepted] D2726: Make kpackage_install_package work with KDE_INSTALL_DIRS_NO_DEPRECATED

2016-09-09 Thread mart (Marco Martin)
mart accepted this revision. This revision is now accepted and ready to land. BRANCH supportKDE_INSTALL_DIRS_NO_DEPRECATED REVISION DETAIL https://phabricator.kde.org/D2726 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, #plasma, apol, mart Cc:

[Differential] [Accepted] D2723: port panel loading away from ksycoca

2016-09-09 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > scriptengine_v1.cpp:488 > > -const QString constraint = QStringLiteral("[X-KDE-PluginInfo-Name] == > '%2'").arg(layout); > -KService::List off

[Differential] [Changed Subscribers] D2727: don't list "NoDisplay" panels

2016-09-09 Thread davidedmundson (David Edmundson)
davidedmundson added inline comments. INLINE COMMENTS > shellcorona.cpp:1606 > { > -return md.value(QStringLiteral("X-Plasma-Shell")) == > qApp->applicationName() && > md.value(QStringLiteral("X-Plasma-ContainmentCategories")).contains(QStringLiteral("panel")); > +return md

[Differential] [Accepted] D2620: DebugConsole window does not take keyboard input

2016-09-09 Thread bshah (Bhushan Shah)
bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH debug-console-no-keyboard-input REVISION DETAIL https://phabricator.kde.org/D2620 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/email

[Differential] [Closed] D2727: don't list "NoDisplay" panels

2016-09-09 Thread mart (Marco Martin)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEfa128c722d50: don't list "NoDisplay" panels (authored by mart). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2727?vs=6598&id=6599

[Differential] [Accepted] D2727: don't list "NoDisplay" panels

2016-09-09 Thread bshah (Bhushan Shah)
bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH phab/nohidden REVISION DETAIL https://phabricator.kde.org/D2727 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/

[Differential] [Request, 7 lines] D2727: don't list "NoDisplay" panels

2016-09-09 Thread mart (Marco Martin)
mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY some panel plugins don't want to be displayed in the context menu with the NoDisplay key. for instance, the systray REPOSITORY rPLASMAWORKS

[Differential] [Updated] D2727: don't list "NoDisplay" panels

2016-09-09 Thread mart (Marco Martin)
mart added a reviewer: Plasma. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2727 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts,

[Differential] [Accepted] D2534: [Desktop View] Place Plasma sidebars at the right screen edge in right-to-left mode

2016-09-09 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2534 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, safaalfulaij, #pla

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 319 - Still Unstable!

2016-09-09 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/319/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 09 Sep 2016 12:50:27 + Build duration: 8 min 5 sec CHANGE SET Revision cde7ee6dd26849106c45d7757c4671a

[Differential] [Request, 9 lines] D2726: Make kpackage_install_package work with KDE_INSTALL_DIRS_NO_DEPRECATED

2016-09-09 Thread kossebau (Friedrich W. H. Kossebau)
kossebau created this revision. kossebau added reviewers: Plasma, mart, apol. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Currently kpackage_install_package fails if KDE_INSTALL_DIRS_NO_DEPRECATED is set to TRUE, bec

[Differential] [Updated, 44 lines] D2534: [Desktop View] Place Plasma sidebars at the right screen edge in right-to-left mode

2016-09-09 Thread broulik (Kai Uwe Broulik)
broulik updated this revision to Diff 6594. broulik added a comment. Bind to X/Y directly REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2534?vs=6417&id=6594 REVISION DETAIL https://phabricator.kde.org/D2534 AFFECTED FILES desktoppack

[Differential] [Closed] D2539: [Desktop Containment] Enable LayoutMirroring

2016-09-09 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPcde7ee6dd268: [Desktop Containment] Enable LayoutMirroring (authored by broulik). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2539?vs=6

[Differential] [Closed] D2718: show an OSD on display button press

2016-09-09 Thread Sebastian Kügler
This revision was automatically updated to reflect the committed changes. Closed by commit rKSCREENad53dc4afaab: show an OSD on display button press (authored by sebas). REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2718?vs=6567&id=6592 REVISION DETAIL

[Differential] [Closed] D2711: add osd slot for screen layout changes

2016-09-09 Thread Sebastian Kügler
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE64a3a1cd4167: add osd slot for screen layout changes (authored by sebas). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2711?vs=656

[Differential] [Commented On] D2534: [Desktop View] Place Plasma sidebars at the right screen edge in right-to-left mode

2016-09-09 Thread davidedmundson (David Edmundson)
davidedmundson added a comment. I was wrong on both counts. (Sorry!) dialog.cpp only adjusts position if visualParent is set. visualParent is not set, so x and y are in fact only set by this app. you can set them, and you can set them normally. the location property is eff

Re: Change settings for docking station

2016-09-09 Thread Sebastian Kügler
Hi Max, On Thursday, September 8, 2016 4:25:55 PM UTC Max Schettler wrote: > I just got a docking station and was wondering whether there is a way to > have settings change depending on the docking status. For example I'd > like to switch my primary screen and Have my Taskbar be displayed always

[Differential] [Updated, 21 lines] D2539: [Desktop Containment] Enable LayoutMirroring

2016-09-09 Thread broulik (Kai Uwe Broulik)
broulik retitled this revision from "WIP: [Desktop Containment] Enable LayoutMirroring" to "[Desktop Containment] Enable LayoutMirroring". broulik updated the test plan for this revision. broulik updated this revision to Diff 6589. REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UP

[Differential] [Accepted] D2711: add osd slot for screen layout changes

2016-09-09 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH sebas/screenosd REVISION DETAIL https://phabricator.kde.org/D2711 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/e

[Differential] [Closed] D2712: Add a utility to extract config entries from plasmoid xfcg files

2016-09-09 Thread davidedmundson (David Edmundson)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE73595f321cfc: Add a utility to extract config entries from plasmoid xfcg files (authored by davidedmundson). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https

[Differential] [Closed] D2707: Keep action buttons in screen if we can't match design gap

2016-09-09 Thread davidedmundson (David Edmundson)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEfcf96cd14b02: Keep action buttons in screen if we can't match design gap (authored by davidedmundson). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://pha

[Differential] [Closed] D2613: Fix some status notifier items not appearing

2016-09-09 Thread davidedmundson (David Edmundson)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEdf4387a21f6e: Fix some status notifier items not appearing (authored by davidedmundson). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.o

[Differential] [Accepted] D2613: Fix some status notifier items not appearing

2016-09-09 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D2613 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefe

[Differential] [Accepted] D2712: Add a utility to extract config entries from plasmoid xfcg files

2016-09-09 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. let's put this in already to at least test completeness of keys. Olivier: do you think would be feasible to have some sort of integration of this into api.kde.org?

[Differential] [Accepted] D2707: Keep action buttons in screen if we can't match design gap

2016-09-09 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D2707 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefe

[Differential] [Updated] D2712: Add a utility to extract config entries from plasmoid xfcg files

2016-09-09 Thread mart (Marco Martin)
mart added a reviewer: ochurlaud. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2712 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, ochurlaud Cc: mart, plasma-devel, lesliezhai, ali-mo

[Differential] [Commented On] D2723: port panel loading away from ksycoca

2016-09-09 Thread mart (Marco Martin)
mart added inline comments. INLINE COMMENTS > davidedmundson wrote in scriptengine_v1.cpp:490 > I'm a bit lost. > > We have an argument to this method which is stored as local QString layout. > > The old code found all Plasma/LayoutTemplates with that name. > As far as I can tell, this finds al

[Differential] [Updated, 19 lines] D2723: port panel loading away from ksycoca

2016-09-09 Thread mart (Marco Martin)
mart updated this revision to Diff 6584. mart added a comment. - actually check the panel plugin id REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2723?vs=6580&id=6584 BRANCH phab/nococa REVISION DETAIL https://phabricator.kde.org

[Differential] [Commented On] D2708: Hide clock if there's no room to show it all

2016-09-09 Thread davidedmundson (David Edmundson)
davidedmundson added a comment. In https://phabricator.kde.org/D2708#50598, @andreaska wrote: > does the desktop seccion switch (plasma, gnome, ) and the keyboard indicator work now? Should do? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabrica

[Differential] [Commented On] D2708: Hide clock if there's no room to show it all

2016-09-09 Thread andreaska (Andreas Kainz)
andreaska added a comment. does the desktop seccion switch (plasma, gnome, ) and the keyboard indicator work now? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2708 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefer

[Differential] [Closed] D2708: Hide clock if there's no room to show it all

2016-09-09 Thread davidedmundson (David Edmundson)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEbeb91289047a: Hide clock if there's no room to show it all (authored by davidedmundson). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.o

[Differential] [Closed] D2703: Fix applets not being added on service restart

2016-09-09 Thread davidedmundson (David Edmundson)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE62ac5cd17b00: Fix applets not being added on service restart (authored by davidedmundson). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde

[Differential] [Accepted] D2539: WIP: [Desktop Containment] Enable LayoutMirroring

2016-09-09 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2539 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/e

[Differential] [Requested Changes To] D2534: [Desktop View] Place Plasma sidebars at the right screen edge in right-to-left mode

2016-09-09 Thread davidedmundson (David Edmundson)
davidedmundson requested changes to this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > Desktop.qml:139 > + > +// PlasmaCore.Dialog has its own positioning logic so it breaks

[Differential] [Requested Changes To] D2723: port panel loading away from ksycoca

2016-09-09 Thread davidedmundson (David Edmundson)
davidedmundson requested changes to this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > scriptengine_v1.cpp:490 > +{ > +return md.value(QStringLiteral("X-Plasma-Shell"))

Re: Review Request 128870: [ToolButtonStyle] Fix menu arrow

2016-09-09 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128870/#review99017 --- Yes, please. Also this needs fixing when using Breeze+QSyle

[Differential] [Commented On] D2723: port panel loading away from ksycoca

2016-09-09 Thread mart (Marco Martin)
mart added a comment. In https://phabricator.kde.org/D2723#50572, @andreaska wrote: > the emtpy system tray (desktop right click add panel) shouldn't be a panel cause it doesn't work like a panel. good point, looking into that REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVIS

[Differential] [Request, 20 lines] D2724: Make WindowPixmap::isValid virtual and override in concrete implementation

2016-09-09 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY If a buffer gets destroyed the texture created from it is still vali

[Differential] [Commented On] D2723: port panel loading away from ksycoca

2016-09-09 Thread andreaska (Andreas Kainz)
andreaska added a comment. the emtpy system tray (desktop right click add panel) shouldn't be a panel cause it doesn't work like a panel. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2723 EMAIL PREFERENCES https://phabricator.kde.org/settin

[Differential] [Updated] D2723: port panel loading away from ksycoca

2016-09-09 Thread mart (Marco Martin)
mart added a reviewer: Plasma. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2723 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts,

[Differential] [Request, 19 lines] D2723: port panel loading away from ksycoca

2016-09-09 Thread mart (Marco Martin)
mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY the panel tamplates are listed with kpackage listing but were still loaded with kservicetypetrader this made possible to have templates listed

Re: Review Request 128802: task bar lines

2016-09-09 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128802/ --- (Updated Sept. 9, 2016, 1:20 p.m.) Status -- This change has been ma

[Differential] [Updated] D2722: Wallpaper slideshow: Incorrect checking of file suffix against glob pattern

2016-09-09 Thread marten (Jonathan Marten)
marten set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2722 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: marten, davidedmundson, #pla

[Differential] [Updated, 11 lines] D2722: Wallpaper slideshow: Incorrect checking of file suffix against glob pattern

2016-09-09 Thread marten (Jonathan Marten)
marten removed rPLASMAWORKSPACE Plasma Workspace as the repository for this revision. marten updated this revision to Diff 6579. marten added a comment. Implemented BackgroundFinder::isAcceptableSuffix() as suggested. Yes, I already have Git commit access (assuming that nothing special ne

[Differential] [Commented On] D2722: Wallpaper slideshow: Incorrect checking of file suffix against glob pattern

2016-09-09 Thread marten (Jonathan Marten)
marten added a comment. broulik's suggestion would make the code clearer, I'll look into it. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2722 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: marten, #plas

[Differential] [Commented On] D2722: Wallpaper slideshow: Incorrect checking of file suffix against glob pattern

2016-09-09 Thread broulik (Kai Uwe Broulik)
broulik added a comment. I think it would be cleaner to have a BackgroundFinder::isAcceptableSuffix(const QString &suffix) const method. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2722 EMAIL PREFERENCES https://phabricator.kde.org/setting

[Differential] [Accepted] D2722: Wallpaper slideshow: Incorrect checking of file suffix against glob pattern

2016-09-09 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added a comment. This revision is now accepted and ready to land. Comments are more useful in the code than a commit log. Copy and paste the bit about globs in there. Also do you have co

[Differential] [Updated] D2682: Make sure padding is respected in the GlobalDrawer

2016-09-09 Thread mart (Marco Martin)
mart added a comment. as discussed, it would make the menu itels look quite broken, having margins they shouldn't have REPOSITORY rKIRIGAMI Kirigami REVISION DETAIL https://phabricator.kde.org/D2682 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ap

[Differential] [Commented On] D2580: possible to use OverlaySheet with ListView

2016-09-09 Thread mart (Marco Martin)
mart added a comment. In https://phabricator.kde.org/D2580#50121, @apol wrote: > We've been looking into it with @colomar and we like how it works. We think it would be useful if we'd get a small margin on either side so that it's easy to close when we're half-way through the scrolling p

[Differential] [Accepted] D2705: Fix warnings

2016-09-09 Thread mart (Marco Martin)
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKIRIGAMI Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D2705 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc: plasm

[Differential] [Request, 2 lines] D2722: Wallpaper slideshow: Incorrect checking of file suffix against glob pattern

2016-09-09 Thread marten (Jonathan Marten)
marten created this revision. marten added a reviewer: Plasma. marten set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When a new image file is det

Review Request 128870: [ToolButtonStyle] Fix menu arrow

2016-09-09 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128870/ --- Review request for Plasma. Repository: plasma-framework Description ---

[Differential] [Commented On] D2687: WIP: [Icon Widget] Bring back properties dialog

2016-09-09 Thread mart (Marco Martin)
mart added a comment. i kindof feel that we shouldn't use neither kio nor krun in this case (maybe kio yes, but krun::run* doesn't seem particularly appropriate in this case) REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2687 EMAIL PREFERENCES

[Differential] [Accepted] D2703: Fix applets not being added on service restart

2016-09-09 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. as discussed would be nice to have containment::applets updating immediately, but not yet, 5.8 must work with non fixed frameworks as well, so +2 REPOSITORY rPLAS

[Differential] [Accepted] D2708: Hide clock if there's no room to show it all

2016-09-09 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D2708 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefe

[Differential] [Commented On] D2712: Add a utility to extract config entries from plasmoid xfcg files

2016-09-09 Thread mart (Marco Martin)
mart added a comment. i wonder if would be betterto have it write directly html and having it hooked somehow to api.kde.org? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2712 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emai

[Differential] [Accepted] D2718: show an OSD on display button press

2016-09-09 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKSCREEN KScreen BRANCH sebas/displaybuttonosd REVISION DETAIL https://phabricator.kde.org/D2718 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefer

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 318 - Still Unstable!

2016-09-09 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/318/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 09 Sep 2016 09:12:12 + Build duration: 6 min 13 sec CHANGE SET Revision 5acd6a3a3d4d4174011dcd961ce9ed

[Differential] [Closed] D2720: Add an option to limit the Pager to the current screen.

2016-09-09 Thread hein (Eike Hein)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP5acd6a3a3d4d: Add an option to limit the Pager to the current screen. (authored by hein). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2

Re: Review Request 128423: fix rename file (or folder) in folder plugin (and desktop in folder mode)

2016-09-09 Thread Painless Roaster
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128423/ --- (Updated Sept. 9, 2016, 9:11 a.m.) Status -- This change has been ma

Re: Review Request 128423: fix rename file (or folder) in folder plugin (and desktop in folder mode)

2016-09-09 Thread Eike Hein
> On July 28, 2016, 6:02 a.m., Painless Roaster wrote: > > Ship It! > > Eike Hein wrote: > Do you need someone to commit this for you? > > Painless Roaster wrote: > I do not have an account on github. > > Eike Hein wrote: > Thanks, I'll see about getting this in next week. > > Eik

SystemSettings See also links

2016-09-09 Thread kainz.a
System Settings has a lot of different single KCM's they are grouped and when you open a KCM you see also the other KCM's from the group in the sidebar, but sometimes it would be also usefull to show the user KCM modules that are not in the same group cause the KCM modul is related to the group. f

[Differential] [Updated, 121 lines] D2720: Add an option to limit the Pager to the current screen.

2016-09-09 Thread hein (Eike Hein)
hein updated this revision to Diff 6576. hein added a comment. Add bug number. REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2720?vs=6575&id=6576 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2720 AFFECTED FILES apple

[Differential] [Accepted] D2720: Add an option to limit the Pager to the current screen.

2016-09-09 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. I'm fine with that, but it's quite on the edge for 5.8. this one is still ok, but after this is better not to add other features for this cycle REPOSITORY rPLAS

[Differential] [Updated] D2720: Add an option to limit the Pager to the current screen.

2016-09-09 Thread hein (Eike Hein)
hein added a reviewer: lbeltrame. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2720 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, #plasma, davidedmundson, graesslin, lbeltrame Cc: plasma-devel, lesliezhai,

[Differential] [Accepted] D2719: [System Tray] Call Qt.createComponent for PlasmoidItem only once

2016-09-09 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2719 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: brou

[Differential] [Updated, 121 lines] D2720: Add an option to limit the Pager to the current screen.

2016-09-09 Thread hein (Eike Hein)
hein updated this revision to Diff 6575. hein added a comment. Make the grid layout happy. REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2720?vs=6574&id=6575 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2720 AFFECTED F

[Differential] [Request, 116 lines] D2720: Add an option to limit the Pager to the current screen.

2016-09-09 Thread hein (Eike Hein)
hein created this revision. hein added reviewers: Plasma, davidedmundson, graesslin. hein added a subscriber: plasma-devel. Restricted Application added a project: Plasma. REVISION SUMMARY The Pager's display normally encompasses all connected screens and shows windows on all of them. This add

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 317 - Still Unstable!

2016-09-09 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/317/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 09 Sep 2016 08:44:16 + Build duration: 6 min 12 sec CHANGE SET Revision 708eed1a66035ea3eb3bb994d27d1f

[Differential] [Closed] D2691: [Touchpad plasmoid] Major cleanup

2016-09-09 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP708eed1a6603: [Touchpad plasmoid] Major cleanup (authored by broulik). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2691?vs=6510&id=6572

[Differential] [Commented On] D2718: show an OSD on display button press

2016-09-09 Thread Sebastian Kügler
sebas added a comment. Display means one monitor, screen the combination of all. That is consistent with how we use it elsewhere as far as I can tell. REPOSITORY rKSCREEN KScreen REVISION DETAIL https://phabricator.kde.org/D2718 EMAIL PREFERENCES https://phabricator.kde.org/settings/p

Re: Howto start desktop/context menu in windowed mode for testing

2016-09-09 Thread Marco Martin
On Wednesday 07 September 2016, Gregor Mi wrote: > > $ plasmawindowed org.kde.desktopcontainment > > Both have different items in the context menu but not the "Run Command...", > "Activities..." etc. So is there another windowed way to get the context > menu? no, the full context menu is loaded

Change settings for docking station

2016-09-09 Thread Max Schettler
Hello all, I just got a docking station and was wondering whether there is a way to have settings change depending on the docking status. For example I'd like to switch my primary screen and Have my Taskbar be displayed always instead of it hiding automatically. Is there a way to do this with Plas

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 316 - Still Unstable!

2016-09-09 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/316/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 09 Sep 2016 07:56:57 + Build duration: 5 min 51 sec CHANGE SET Revision 83335d5a85e2e480c6085bc525ec7e

[Differential] [Closed] D2704: [Activity Manager] Hide "Create Activity" and "Delete Activity" if not authorized

2016-09-09 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP83335d5a85e2: [Activity Manager] Hide "Create Activity" and "Delete Activity" if not… (authored by broulik). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://pha

[Differential] [Request, 8 lines] D2719: [System Tray] Call Qt.createComponent for PlasmoidItem only once

2016-09-09 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN I slapped a console.time in ther

[Differential] [Closed] D2690: [System Tray] Set applet status to RequiresAttention when popup is open

2016-09-09 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEac7245667e60: [System Tray] Set applet status to RequiresAttention when popup is open (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https