davidedmundson requested changes to this revision.
davidedmundson added a reviewer: davidedmundson.
davidedmundson added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> Desktop.qml:139
> +
> +        // PlasmaCore.Dialog has its own positioning logic so it breaks the 
> X/Y bindings at some point
> +        x: desiredX

> // PlasmaCore.Dialog has its own positioning logic

So any fixes to x/y need to go there, not adding a second system competing.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2534

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, safaalfulaij, #plasma, davidedmundson
Cc: davidedmundson, mart, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

Reply via email to