marten created this revision. marten added a reviewer: Plasma. marten set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY When a new image file is detected via Image::pathCreated(), its file extension is checked against BackgroundFinder::suffixes() to ensure that it is a supported format. However, despite its name, suffixes() returns a list of glob patterns (i.e. all prefixed with "*.") so the contains() never succeeds and the new file is not added. suffixes() is also used within the BackgroundCreator class itself to set a directory name filter. To maintain compatibility it may be better to not change the name or meaning of this function, but instead to take account of the pattern in Image::pathCreated(). This patch does just that. TEST PLAN Built plasma-workspace with this changed, checked correct operation of slideshow wallpaper. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2722 AFFECTED FILES wallpapers/image/image.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: marten, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
