[Differential] [Accepted] D2465: [kded] correctly restore lidOpened configuration on startup

graesslin accepted this revision. graesslin added a reviewer: graesslin. This revision is now accepted and ready to land. REPOSITORY rKSCREEN KScreen BRANCH sebas/lidopeninit REVISION DETAIL https://phabricator.kde.org/D2465 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/e

Re: Review Request 128707: Add support for captive portals

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128707/#review98490 --- I'm not happy with the QWebEngineView as that's going to cras

fix Kirigami qrc file

>From fb2d355d00011f7ff9a0a7ea69ea93ecc36a5486 Mon Sep 17 00:00:00 2001 From: Dirk Hohndel Date: Thu, 18 Aug 2016 22:05:25 -0700 Subject: [PATCH] Remove reference to Icon.qml under desktop style This file was removed in commit 2496430d9404 ("c++ implementation of Icon on Desktop style") Signed-

[Differential] [Request, 76 lines] D2496: normalize output positions in setoperation

sebas created this revision. sebas added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When setting a config, outputs may fall outside of the virtual screen layout. This can happen when, for example

Re: [PATCH 1/7] add simple script to generate a qrc containing all qml files

Can you please upload the patches to phabricator.kde.org or reviewboard.kde.org? Thanks! Aleix On Tue, Aug 16, 2016 at 8:23 PM, Martin Gysel wrote: > --- > scripts/gen_qml_qrc.sh | 39 +++ > 1 file changed, 39 insertions(+) > create mode 100755 scripts/gen_q

[Differential] [Updated, 2 lines] D2495: Supress QML warning

davidedmundson updated this revision to Diff 6053. davidedmundson added a comment. clearer syntax REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2495?vs=6052&id=6053 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2495 AFF

[Differential] [Request, 2 lines] D2495: Supress QML warning

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Role LegacyWinIdList can be null, for example on a StartupItem or on Wayland. This means we a

[Differential] [Accepted] D2492: [Panel Containment] Cleanup

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2492 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik,

[Differential] [Request, 63 lines] D2492: [Panel Containment] Cleanup

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY - When creating the applet con

[Differential] [Accepted] D2491: [Kickoff] Mirror breadcrumb arrow in right-to-left layout

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2491 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/e

[Differential] [Request, 2 lines] D2491: [Kickoff] Mirror breadcrumb arrow in right-to-left layout

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The breadcrumbs are already mi

[Differential] [Accepted] D2489: [Containment Actions Configuration] Add labels for Back / Forward mouse buttons

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2489 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik,

[Differential] [Accepted] D2490: [Desktop Toolbox] Animate position change

mart accepted this revision. mart added a reviewer: mart. mart added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > ToolBoxRoot.qml:75 > +Behavior on x { > +NumberAnimation { duration: units.longDuration; easing.type: > Easing.InOutQuad }

Re: Review Request 128699: Plasma 5.8 "Bismuth" Wallpaper

> On Aug. 18, 2016, 7:11 p.m., Marco Martin wrote: > > ship it from me.. maybe wait for a second as well, to see there is enough > > agreement Roger that. - Ken --- This is an automatically generated e-mail. To reply, visit: https://gi

Re: plasma-frameworks compile failure

On Thursday 18 August 2016 21:06:00 Jonathan Riddell wrote: > > I've not updated any other frameworks, is there something that needs > updated first? kdeclarative needs to be updated -- Marco Martin

[Differential] [Request, 7 lines] D2490: [Desktop Toolbox] Animate position change

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This animates when the toolbox

Re: plasma-frameworks compile failure

On 18/08/16 21:31, David Edmundson wrote: > kdeclarative > ​ Aha! Trying a new build of that. TY

Re: plasma-frameworks compile failure

kdeclarative ​

Re: plasma-frameworks compile failure

On 18/08/16 21:06, Jonathan Riddell wrote: > Getting an error in plasma-frameworks today > > http://build.neon.kde.org/job/xenial_unstable_frameworks_plasma-framework_bin_amd64/92/console > > /workspace/build/src/plasmaquick/containmentview.cpp:205:69: error: > ‘setTranslationDomain’ was not decl

Re: Review Request 128707: Add support for captive portals

> On Aug. 18, 2016, 10:27 a.m., Kai Uwe Broulik wrote: > > While I really appreciate that we get support for this I don't think just > > opening a webview automatically is a good idea. > > > > Can we perhaps show a notification [1] "log in to this network" with a > > button that will then open

[Differential] [Request, 2 lines] D2489: [Containment Actions Configuration] Add labels for Back / Forward mouse buttons

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY It's not like we're doing any

plasma-frameworks compile failure

Getting an error in plasma-frameworks today http://build.neon.kde.org/job/xenial_unstable_frameworks_plasma-framework_bin_amd64/92/console /workspace/build/src/plasmaquick/containmentview.cpp:205:69: error: ‘setTranslationDomain’ was not declared in this scope 16:37:02 setTranslation

[Differential] [Commented On] D2487: Simpler KSplash design

broulik added a comment. > with a transparent window i'm a bit concerned that all eventual flickering of compositor starting at half startup I didn't notice any issue, given the root window is black there's nothing to see with or without compositing. KWin just briefly freezes the screen

[Differential] [Accepted] D2345: use a separate configuration per look and feel

ivan accepted this revision. ivan added a reviewer: ivan. ivan added a comment. Since David has not objected to the last revision, I'm marking as accepted. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2345 EMAIL PREFERENCES https://phabricat

[Differential] [Updated, 2,011 lines] D2345: use a separate configuration per look and feel

mart updated this revision to Diff 6043. mart added a comment. - remove dead code REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2345?vs=6039&id=6043 BRANCH mart/separateLookAndFeelLayout REVISION DETAIL https://phabricator.kde.or

Re: Review Request 128699: Plasma 5.8 "Bismuth" Wallpaper

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128699/#review98486 --- Ship it! ship it from me.. maybe wait for a second as well

[Differential] [Accepted] D2488: [Desktop Containment] Animate margin changes due to available screen rect

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2488 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik,

[Differential] [Commented On] D2487: Simpler KSplash design

mart added a comment. with a transparent window i'm a bit concerned that all eventual flickering of compositor starting at half startup, or resolution be changed? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2487 EMAIL PREFERENCES https://p

[Differential] [Request, 13 lines] D2488: [Desktop Containment] Animate margin changes due to available screen rect

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Animate the changing margins w

Re: Review Request 128699: Plasma 5.8 "Bismuth" Wallpaper

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128699/#review98485 --- I've updated the VDG share with the (final?) version of the w

[Differential] [Commented On] D2345: use a separate configuration per look and feel

ivan added inline comments. INLINE COMMENTS > containment.cpp:197 > +//addWidget("org.kde.plasma.analogclock", {"x": 0, "y": 100, > "width": 300, "height": 400}); > +const QVariantMap geom = > context->argument(1).toVariant().value(); > +geometry = QRectF(con

Re: Review Request 128699: Plasma 5.8 "Bismuth" Wallpaper

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128699/ --- (Updated Aug. 18, 2016, 6:23 p.m.) Review request for Plasma. Repositor

[Differential] [Request, 74 lines] D2487: Simpler KSplash design

broulik created this revision. broulik added reviewers: Plasma, Plasma: Design. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This chang

[Differential] [Updated, 2,012 lines] D2345: use a separate configuration per look and feel

mart updated this revision to Diff 6039. mart added a comment. - use a single config file again REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2345?vs=6031&id=6039 BRANCH mart/separateLookAndFeelLayout REVISION DETAIL https://phab

plasma-devel@kde.org

mart updated this revision to Diff 6038. mart added a comment. - switch to single config file REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2448?vs=6035&id=6038 BRANCH arcpatch-D2448_1 REVISION DETAIL https://phabricator.kde.org/D244

[Differential] [Commented On] D2484: [Image Wallpaper] Avoid cross-fading which reveals black background behind images

fredrik added a comment. The correct way to fix this is to use a custom shader that does approximately this: uniform sampler2D texture1; uniform sampler2D texture2; uniform float fadeProgress; varying vec2 texcoord1; varying vec2 texcoord2; void main(void) {

[Differential] [Accepted] D2484: [Image Wallpaper] Avoid cross-fading which reveals black background behind images

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2484 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: brou

Re: more Kirigami patches

On Tuesday 16 August 2016 20:23:45 Martin Gysel wrote: > Hi > Here are some patches I have in my branch. > It contains a script to (re)generate the qml file, one the generate a > resource file with possibly used icons and one to generaste a qmltypes file. > It adds the icon resource to the pri file

plasma-devel@kde.org

mart added a comment. In https://phabricator.kde.org/D2448#46454, @colomar wrote: > UI-wise, I'd do it differently. > Currently, the description of what the checkbox affects and the checkbox itself are too far separated, plus it makes it sound like the layout is going to be changed ev

[Differential] [Commented On] D2484: [Image Wallpaper] Avoid cross-fading which reveals black background behind images

mart added a comment. hmm, it shouldn't cause flicker, fading between 2 different sized wallpapers should be just fine REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2484 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefe

plasma-devel@kde.org

colomar added a comment. UI-wise, I'd do it differently. Currently, the description of what the checkbox affects and the checkbox itself are too far separated, plus it makes it sound like the layout is going to be changed even if the checkbox is not checked. Instead what I'd do is, below t

[Differential] [Request, 41 lines] D2484: [Image Wallpaper] Avoid cross-fading which reveals black background behind images

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When simultaneously fadin

Re: Review Request 128707: Add support for captive portals

> On Aug. 18, 2016, 12:37 p.m., Lamarque Souza wrote: > > kded/portalmonitor.cpp, line 44 > > > > > > You should delete m_view here in case this module is unloaded from > > kded5. > > Jan Grulich wrote: > Is

Re: Review Request 128707: Add support for captive portals

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128707/#review98475 --- kded/service.cpp (line 31)

Re: Selecting a Plasma logo

Il 11-08-2016 11:37 Ivan Čukić ha scritto: Hi all, For anyone interested I've also posted the SVG file (Andreas asked for it): https://share.kde.org/index.php/s/0HRcGXCt6UCEWxp Cheers, Ivan I updated it with the last version of my logo (posted on Forums) plus a new version: https://share.

plasma-devel@kde.org

mart updated this revision to Diff 6035. mart added a comment. - typo REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2448?vs=6033&id=6035 BRANCH arcpatch-D2448_1 REVISION DETAIL https://phabricator.kde.org/D2448 AFFECTED FILES kcms

plasma-devel@kde.org

mart updated this revision to Diff 6033. mart added a comment. - be more verbose on what the kcm is doing REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2448?vs=5929&id=6033 BRANCH arcpatch-D2448_1 REVISION DETAIL https://phabricator.

[Differential] [Accepted] D2482: [Kicker Dash] Use ComplementaryColorGroup for icon tinting

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2482 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/e

[Differential] [Request, 2 lines] D2482: [Kicker Dash] Use ComplementaryColorGroup for icon tinting

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Ensures we don't end up with d

[Differential] [Updated, 2,050 lines] D2345: use a separate configuration per look and feel

mart updated this revision to Diff 6031. mart added a comment. merge new serialization code from Ivan REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2345?vs=6030&id=6031 BRANCH mart/separateLookAndFeelLayout REVISION DETAIL https:

[Differential] [Closed] D2480: Serializing the desktop layout to a JavaScript object

ivan closed this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2480 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ivan, #plasma, mart Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abett

[Differential] [Updated, 373 lines] D2345: use a separate configuration per look and feel

mart updated this revision to Diff 6030. mart added a comment. use new config serialization REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2345?vs=6029&id=6030 BRANCH mart/separateLookAndFeelLayout REVISION DETAIL https://phabrica

Re: Review Request 128699: Plasma 5.8 "Bismuth" Wallpaper

> On Aug. 18, 2016, 9:28 a.m., Sebastian Kügler wrote: > > I like it a lot as well. > > > > I can't try it, since reviewboard doesn't let me download the files. Could > > you put them up somewhere? (At least the highest resolution.) Added a downloadable link to the description, uncompressed. T

Re: Review Request 128699: Plasma 5.8 "Bismuth" Wallpaper

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128699/ --- (Updated Aug. 18, 2016, 1:02 p.m.) Review request for Plasma. Repositor

[Differential] [Updated, 373 lines] D2345: use a separate configuration per look and feel

mart updated this revision to Diff 6029. mart added a comment. - Merge branch 'master' into mart/separateLookAndFeelLayout REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2345?vs=5980&id=6029 BRANCH mart/separateLookAndFeelLayout REV

[Differential] [Commented On] D2480: Serializing the desktop layout to a JavaScript object

ivan added inline comments. INLINE COMMENTS > mart wrote in shellcorona.cpp:392 > QByteArray and returning .toUtf8()? toJson is already utf8 byte array REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH ivan/separateLookAndFeelLayoutSerialization REVISION DETAIL https://phabricator.kde

[Differential] [Updated, 1,979 lines] D2480: Serializing the desktop layout to a JavaScript object

ivan updated this revision to Diff 6028. ivan added a comment. - Dumping JS as a UTF8 byte array instead as a string REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2480?vs=6026&id=6028 BRANCH ivan/separateLookAndFeelLayoutSerializati

Re: Review Request 128707: Add support for captive portals

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128707/ --- (Updated Srp. 18, 2016, 12:47 odp.) Review request for Network Management

Re: Review Request 128707: Add support for captive portals

> On Srp. 18, 2016, 12:37 odp., Lamarque Souza wrote: > > kded/portalmonitor.cpp, line 44 > > > > > > You should delete m_view here in case this module is unloaded from > > kded5. Isn't this purpose of QScopedPo

Re: Review Request 128707: Add support for captive portals

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128707/#review98470 --- kded/portalmonitor.cpp (line 44)

Re: Review Request 128707: Add support for captive portals

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128707/#review98468 --- kded/portalmonitor.cpp (line 25)

[Differential] [Accepted] D2480: Serializing the desktop layout to a JavaScript object

mart accepted this revision. mart added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > scriptengine_v1.cpp:345 > +// << appletData.property("plugin").toString() > +// << appletData.property("geometry.x").toInteger() * >

Re: Review Request 128709: Remove code that can never be executed.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128709/ --- (Updated Aug. 18, 2016, 12:21 p.m.) Status -- This change has been m

[Powerdevil] [Bug 362830] Allow lowest brightness when using the brightness down/up buttons

https://bugs.kde.org/show_bug.cgi?id=362830 --- Comment #3 from Pascal d'Hermilly --- I was just wondering if the devs saw my point :-) (Sometimes bugs.kde.org feels lonely) Yeah, so the problem is exactly that turning down the brightness to lowest with the keys switches off the display instead

[Differential] [Request, 1 line] D2481: install new header

sitter created this revision. sitter added a reviewer: davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY it is included by concatenatetasksproxymodel.h (and probably others) REPOSITORY rPLASMAWORKSPACE Pla

[Differential] [Request, 1,985 lines] D2480: Serializing the desktop layout to a JavaScript object

ivan created this revision. ivan added reviewers: Plasma, mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY - Serializing the desktop layout for current activity - Support for different config groups - Introducing

Re: Review Request 128707: Add support for captive portals

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128707/#review98467 --- Fix it, then Ship it! kded/portalmonitor.cpp (line 51)

Re: Review Request 128709: Remove code that can never be executed.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128709/#review98466 --- Ship it! Ship It! - Marco Martin On Aug. 18, 2016, 11:5

Review Request 128709: Remove code that can never be executed.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128709/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

[Differential] [Closed] D2475: [Shell Corona] Don't show panels right away

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE595953f2bc79: [Shell Corona] Don't show panels right away (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2475

[Differential] [Abandoned] D2476: [Panel View] Set visible after everything has settled

broulik abandoned this revision. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2476 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, mart Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuter

Re: Review Request 128708: [ContainmentView] Show panel when ui becomes ready

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128708/ --- (Updated Aug. 18, 2016, 11:43 a.m.) Status -- This change has been m

Re: Review Request 128707: Add support for captive portals

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128707/ --- (Updated Srp. 18, 2016, 11:42 dop.) Review request for Network Management

Re: Review Request 128473: Avoid recursive calls to QPlatformTheme::createPlatformSystemTrayIcon()

> On July 19, 2016, 4:02 a.m., David Edmundson wrote: > > KStatusNotifierItemPrivate::setLegacySystemTrayEnabled(bool enabled) > > already has a recursion check added in > > b45544f3d4dd9cb1873b92a609f45a68f5f6e471 (in knotifications) - which > > basically checks if we're using the KDE platfor

Re: Review Request 128708: [ContainmentView] Show panel when ui becomes ready

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128708/#review98464 --- Ship it! Ship It! - Marco Martin On Aug. 18, 2016, 11:3

Review Request 128708: [ContainmentView] Show panel when ui becomes ready

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128708/ --- Review request for Plasma. Repository: plasma-framework Description ---

[Differential] [Updated] D2465: [kded] correctly restore lidOpened configuration on startup

sebas marked 2 inline comments as done. REPOSITORY rKSCREEN KScreen REVISION DETAIL https://phabricator.kde.org/D2465 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sebas, #plasma Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abe

[Differential] [Commented On] D2465: [kded] correctly restore lidOpened configuration on startup

sebas added inline comments. INLINE COMMENTS > graesslin wrote in daemon.cpp:167-169 > So what is the code going to do here? Will it go into the code path here or > not? Ah, I see what you mean. Yes, it would go in there but do nothing since QFile::exists(..) will return false -- the file is n

[Differential] [Updated, 108 lines] D2465: [kded] correctly restore lidOpened configuration on startup

sebas updated this revision to Diff 6024. sebas added a comment. - Also check isLaptop) REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2465?vs=5988&id=6024 BRANCH sebas/lidopeninit REVISION DETAIL https://phabricator.kde.org/D2465 AFFECTED FILES

Re: Review Request 128707: Add support for captive portals

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128707/#review98462 --- kded/service.cpp (line 49)

Re: Review Request 128692: Don't redeclare property implicitHeight

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128692/ --- (Updated Aug. 18, 2016, 11:06 a.m.) Status -- This change has been m

Re: Review Request 128692: Don't redeclare property implicitHeight

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128692/#review98463 --- Ship it! Ship It! - Kai Uwe Broulik On Aug. 15, 2016, 1

[Differential] [Abandoned] D2479: [Shell Corona] Delay showing the panel slightly

broulik abandoned this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2479 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, ab

Re: Review Request 128707: Add support for captive portals

> On Srp. 18, 2016, 10:27 dop., Kai Uwe Broulik wrote: > > While I really appreciate that we get support for this I don't think just > > opening a webview automatically is a good idea. > > > > Can we perhaps show a notification [1] "log in to this network" with a > > button that will then open

Re: Review Request 128707: Add support for captive portals

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128707/ --- (Updated Srp. 18, 2016, 10:58 dop.) Review request for Network Management

[Differential] [Accepted] D2476: [Panel View] Set visible after everything has settled

mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. ok, tough the phone shell should be adjusted in the same way REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2476 EMAIL P

[Differential] [Closed] D2470: [upowerbackend] set cached brightness manually in case of led backlight

This revision was automatically updated to reflect the committed changes. Closed by commit rPOWERDEVIL26a48f9dbfa8: [upowerbackend] set cached brightness manually in case of led backlight (authored by bshah). REPOSITORY rPOWERDEVIL Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde

[Differential] [Updated, 21 lines] D2470: [upowerbackend] set cached brightness manually in case of led backlight

bshah updated this revision to Diff 6022. bshah marked 2 inline comments as done. bshah added a comment. make things simple REPOSITORY rPOWERDEVIL Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2470?vs=6004&id=6022 BRANCH workaround-broken-backlight-driver (branched

[Differential] [Accepted] D2475: [Shell Corona] Don't show panels right away

mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. as now the screen stays correct since screentofollow is independent from screen(), that should work well now (backstory, something similar was done for 5.0, but did

[Differential] [Updated] D2478: make kcolorschemeditor desktop entry spec compliant and refine it

sitter marked an inline comment as done. sitter added a comment. Dump from IRC > [12:18] ochurlaud: why is kcolorschemeeditor a standalone application if you don't use it as such? > [12:25] sitter: It can be used at such > [12:26] but you might want to access it from the colors k

[Differential] [Closed] D2478: make kcolorschemeditor desktop entry spec compliant and refine it

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP53b7f0d805a7: make kcolorschemeditor desktop entry spec compliant and refine it (authored by sitter). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricato

[Differential] [Accepted] D2478: make kcolorschemeditor desktop entry spec compliant and refine it

ochurlaud accepted this revision. ochurlaud added a comment. After discussion on IRC: the nodisplay bit will be removed in a next iteration when the app will have more context. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D2478 EM

[Differential] [Accepted] D2470: [upowerbackend] set cached brightness manually in case of led backlight

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPOWERDEVIL Powerdevil BRANCH workaround-broken-backlight-driver (branched from master) REVISION DETAIL https://phabricator.kde.org/D2470 EMAIL PREFERENCES https://phabricator.kde.org/settings/pa

[Differential] [Commented On] D2470: [upowerbackend] set cached brightness manually in case of led backlight

broulik added inline comments. INLINE COMMENTS > powerdevilupowerbackend.cpp:55 > , m_kbdMaxBrightness(0) > -, m_lidIsPresent(false), m_lidIsClosed(false), m_onBattery(false) > +, m_lidIsPresent(false), m_lidIsClosed(false), m_onBattery(false), > m_isLedBrightnessControl(false) > {

[Differential] [Updated] D2478: make kcolorschemeditor desktop entry spec compliant and refine it

ochurlaud added a comment. In https://phabricator.kde.org/D2478#46347, @sitter wrote: > Pulling in @ochurlaud > > The NoDisplay remark from Bhushan got me wondering how the KCM actually starts the app. And it turns out that it doesn't. > > SchemeEditorDialog* dialog = new Scheme

Re: Review Request 128707: Add support for captive portals

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128707/#review98460 --- While I really appreciate that we get support for this I don'

Re: Review Request 128707: Add support for captive portals

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128707/#review98459 --- kded/portalmonitor.h (line 43)

[Differential] [Updated] D2478: make kcolorschemeditor desktop entry spec compliant and refine it

sitter added a reviewer: ochurlaud. sitter added a subscriber: ochurlaud. sitter added a comment. Pulling in @ochurlaud The NoDisplay remark from Bhushan got me wondering how the KCM actually starts the app. And it turns out that it doesn't. SchemeEditorDialog* dialog = new SchemeE

[Differential] [Request, 4 lines] D2479: [Shell Corona] Delay showing the panel slightly

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY By doing a roundtrip with

[Powerdevil] [Bug 362830] Allow lowest brightness when using the brightness down/up buttons

https://bugs.kde.org/show_bug.cgi?id=362830 Sebastian Kügler changed: What|Removed |Added CC||se...@kde.org --- Comment #2 from Sebastian

  1   2   >