> On Aug. 18, 2016, 10:27 a.m., Kai Uwe Broulik wrote: > > While I really appreciate that we get support for this I don't think just > > opening a webview automatically is a good idea. > > > > Can we perhaps show a notification [1] "log in to this network" with a > > button that will then open the web view? Would also be nice if we could > > indicate that we're behind a portal in the network applet icon (note the > > exclamation mark on the wifi icon) - we even already have "limited" icons > > in NM. > > > > [1] > > https://4.bp.blogspot.com/-dw9MiaM5GmE/VaFd4t_QmZI/AAAAAAAAFuM/OTMfLTcdUeA/s1600/starbucks.png > > Jan Grulich wrote: > We already kinda show exclamation mark on the wifi icon, it's just that > the connectivity is not updated everytime and needs to be perhaps forced > everytime we connect to a new network. > > Showing a notification is a good idea, that's why I added more people > (including usability) to even start a discussion about that and implement it > the best possible way. For now I implemented it the same way as Gnome does.
I agree with Kai Uwe: Detecting that a wifi needs login is a background event, not necessarily the user's current main task, therefore a notification is the right way to inform the user about it and allow the appropriate action. - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128707/#review98460 ----------------------------------------------------------- On Aug. 18, 2016, 12:47 p.m., Jan Grulich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128707/ > ----------------------------------------------------------- > > (Updated Aug. 18, 2016, 12:47 p.m.) > > > Review request for Network Management, Plasma, KDE Usability, and Lamarque > Souza. > > > Bugs: 365417 > http://bugs.kde.org/show_bug.cgi?id=365417 > > > Repository: plasma-nm > > > Description > ------- > > Adds portal monitor to our kded module, which checks NetworkManager > connectivity. If the value gets changed to NM_CONNECTIVITY_PORTAL (means we > are behind a captive portal), then we open a QWebEngineView trying to load > "http://kde.org"; page which is supposed to be redirected to the captive > portal page. Once user logs in and url changes, we re-check the connectivity > again and close the web view if we are no longer behind the captive portal. > > > Diffs > ----- > > CMakeLists.txt a27c1f2 > kded/CMakeLists.txt 1f0613e > kded/portalmonitor.h PRE-CREATION > kded/portalmonitor.cpp PRE-CREATION > kded/service.cpp 18ffd41 > > Diff: https://git.reviewboard.kde.org/r/128707/diff/ > > > Testing > ------- > > Tested with three different captive portals and it worked perfectly. > > > Thanks, > > Jan Grulich > >
