[Powerdevil] [Bug 358588] backlight not restored properly, after it was reduced on inactivity

https://bugs.kde.org/show_bug.cgi?id=358588 Māris Nartišs changed: What|Removed |Added CC||maris@gmail.com --- Comment #1 from Māris N

[Differential] [Requested Changes To] D1126: Remove Desktop.SystemSettings import

sebas requested changes to this revision. sebas added a reviewer: sebas. This revision now requires changes to proceed. INLINE COMMENTS containments/desktop/package/contents/ui/main.qml:218 this should be => (otherwise, the drag won't start at startDragDistance, but only at startDragDistance+1

[Differential] [Changed Subscribers] D1126: Remove Desktop.SystemSettings import

sebas added subscribers: mart, sebas. sebas added a comment. To me, this looks like something we want. @mart could you have a look as well? REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1126 EMAIL PREFERENCES https://phabricator.kde.org/settings/

[Differential] [Accepted] D1292: Add mute microphone global shortcut

sebas accepted this revision. sebas added a reviewer: sebas. sebas added a comment. This revision is now accepted and ready to land. Nice, my laptop even has the mic mute key. REPOSITORY rPLASMAPA Plasma Audio Volume Applet BRANCH mic-mute-globalshortcut REVISION DETAIL https://phabric

[Differential] [Accepted] D1291: Add microphone volume OSD

sebas accepted this revision. sebas added a reviewer: sebas. sebas added a comment. This revision is now accepted and ready to land. Cool! :) REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH mic-osd REVISION DETAIL https://phabricator.kde.org/D1291 EMAIL PREFERENCES https://phabr

[Differential] [Accepted] D1134: Alternatives: Add new applet only after the old one was removed

sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH alternatives-helper (branched from master) REVISION DETAIL https://phabricator.kde.org/D1134 EMAIL PREFERENCES https://phabri

[Differential] [Accepted] D1443: Applet: Move Application streams with drag and drop

sebas accepted this revision. sebas added a comment. This revision is now accepted and ready to land. Sorry it took so long. Looks seriously nice! REPOSITORY rPLASMAPA Plasma Audio Volume Applet BRANCH applet-movestreams REVISION DETAIL https://phabricator.kde.org/D1443 EMAIL PREFEREN

[Differential] [Commented On] D1538: [libinput] Add a wrapper class Device for a libinput_device

sebas added a comment. Looks good to me. I've tested it on my laptop, and it shows all kind of devices, generally the output makes sense. When turning the laptop into tablet mode, nothing seems to happen to the keyboard device. It could be that it's just physically blocked (there's a ne

Review Request 127837: oxygen_windeco: Fix potential use-after-free from improper use of QCache

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127837/ --- Review request for KDE Frameworks and Plasma. Repository: oxygen Descri

[Differential] [Updated] D1533: guard access to unsafe config pointer

sebas marked an inline comment as done. REPOSITORY rKSCREEN KScreen REVISION DETAIL https://phabricator.kde.org/D1533 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sebas, Plasma Cc: graesslin, plasma-devel, sebas ___

[Differential] [Updated, 3 lines] D1533: guard access to unsafe config pointer

sebas updated this revision to Diff 3648. sebas added a comment. don't kill that poor \newline REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1533?vs=3632&id=3648 BRANCH sebas/362586 REVISION DETAIL https://phabricator.kde.org/D1533 AFFECTED FILE

[Differential] [Updated, 24 lines] D1534: make the serializer a bit more robust

sebas updated this revision to Diff 3647. sebas added a comment. - add autotests for null config behavior REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1534?vs=3633&id=3647 BRANCH sebas/fortifyserializer REVISION DETAIL https://phabricator.kde.or

[Differential] [Closed] D1535: add some tests for corrupt configs

This revision was automatically updated to reflect the committed changes. Closed by commit rKSCREEN2cc73bd0608a: add some tests for corrupt configs (authored by sebas). REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1535?vs=3635&id=3646 REVISION DETAIL

[Differential] [Updated, 7 lines] D1532: validate the config before checking if it can be applied

sebas updated this revision to Diff 3645. sebas added a comment. - autotest for null config REPOSITORY rLIBKSCREEN KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1532?vs=3631&id=3645 BRANCH sebas/guardcanbeapplied REVISION DETAIL https://phabricator.kde.org/D

Re: Review Request 127794: [Comic] Plasmoid icon is placed in plasmoid content

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127794/ --- (Updated May 4, 2016, 7:35 p.m.) Status -- This change has been mark

Re: Review Request 127794: [Comic] Plasmoid icon is placed in plasmoid content

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127794/#review95182 --- Ship it! Ship It! - Marco Martin On May 4, 2016, 5 p.m.

Re: Review Request 127794: [Comic] Plasmoid icon is placed in plasmoid content

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127794/ --- (Updated Май 4, 2016, 8 след обяд) Review request for Plasma and Marco Ma

Re: Review Request 127794: [Comic] Plasmoid icon is placed in plasmoid content

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127794/#review95177 --- applets/comic/package/contents/ui/main.qml (line 45)

Re: Review Request 127794: [Comic] Plasmoid icon is placed in plasmoid content

> On Май 4, 2016, 6:46 след обяд, Marco Martin wrote: > > applets/comic/package/contents/ui/main.qml, line 45 > > > > > > no, plasmoid.icon is just an icon name, this wouldn't work But if i returning, bug is not

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 72 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/72/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 04 May 2016 15:48:33 + Build duration: 10 min CHANGE SET Revision 16bc876686625984842e017e9ee0c516e7f

Re: Review Request 127781: Remove clearly broken code

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127781/#review95173 --- Ship it! let's kill it as wouldn't work, then let's rethin

Re: Review Request 127791: Fix usage of string "shut down"

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127791/ --- (Updated May 4, 2016, 3:48 p.m.) Status -- This change has been mark

Re: Review Request 127791: Fix usage of string "shut down"

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127791/#review95172 --- Ship it! Ship It! - Marco Martin On April 29, 2016, 3:5

Re: Review Request 127794: [Comic] Plasmoid icon is placed in plasmoid content

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127794/#review95171 --- Fix it, then Ship it! it's ok, except line 45 applets/co

Re: Review Request 127702: ConfigModel: Don't try to resolve empty source path from package

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127702/ --- (Updated May 4, 2016, 3:36 p.m.) Status -- This change has been mark

Re: Review Request 127826: [IconThumbnail] Request for icon, don't let kwindow::icon to decide

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127826/#review95166 --- Ship it! Ship It! - Marco Martin On May 3, 2016, 6:28 p

Re: Review Request 127702: ConfigModel: Don't try to resolve empty source path from package

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127702/#review95165 --- Fix it, then Ship it! autotests/configmodeltest.cpp (line

Re: Review Request 127828: Remove .desktop file, it is unused and unhelpful as the app is called by ssh-add not run directly

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127828/#review95162 --- Ship it! Ship It! - Jeremy Whiting On May 4, 2016, 6:03

Plasma Wayland Image

I've updated the Plasma Wayland image and for simplicity I've put it alongside the neon images and made it build daily http://jriddell.org/2016/05/04/plasma-wayland-images-go-daily/ or follow the 1 step instruction if you already have Neon developer edition unstable installed https://blog.martin

[Differential] [Updated, 564 lines] D1538: [libinput] Add a wrapper class Device for a libinput_device

graesslin updated this revision to Diff 3641. graesslin added a comment. Also get whether the device can be disabled REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1538?vs=3640&id=3641 BRANCH libinput-device REVISION DETAIL https://phabricator.kde.org/D

Re: Review Request 127790: Fix usage of string "shut down"

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127790/ --- (Updated May 4, 2016, 1:59 p.m.) Status -- This change has been mark

[Differential] [Updated] D1538: [libinput] Add a wrapper class Device for a libinput_device

graesslin marked an inline comment as done. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1538 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma Cc: broulik, plasma-devel, sebas ___

[Differential] [Updated, 552 lines] D1538: [libinput] Add a wrapper class Device for a libinput_device

graesslin updated this revision to Diff 3640. graesslin added a comment. - i18nc - config features exposed REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1538?vs=3638&id=3640 BRANCH libinput-device REVISION DETAIL https://phabricator.kde.org/D1538 AF

[Differential] [Commented On] D1533: guard access to unsafe config pointer

sebas added a comment. At least one of these two is needed, but I prefer both to be in there, just to be sure. It's not immediately obvious that config can be null here, so the next person to change this code is less likely to screw it up. REPOSITORY rKSCREEN KScreen REVISION DETAIL htt

[Differential] [Commented On] D1535: add some tests for corrupt configs

sebas added a comment. I found the logic puzzling at first as well, but what the Serializer does it it takes a config object and tries to change it. (Not my idea, but it seems to work quite OK overall). Serializer::config() is a bit special then because it can do two things: return an invali

[Differential] [Commented On] D1539: Don't show knetattach in the menu, it's only useful from within a file manager/dialog

jriddell added a comment. fixed to "it's not useful" REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1539 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: jriddell, Plasma, mart Cc: broulik, andreaska, plasma-deve

[Differential] [Updated] D1539: Don't show knetattach in the menu, it's only useful from within a file manager/dialog

jriddell updated the summary for this revision. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1539 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: jriddell, Plasma, mart Cc: broulik, andreaska, plasma-devel, sebas

[Differential] [Accepted] D1539: Don't show knetattach in the menu, it's only useful from within a file manager/dialog

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1539 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: jriddell

[Differential] [Commented On] D1538: [libinput] Add a wrapper class Device for a libinput_device

graesslin added inline comments. INLINE COMMENTS debug_console.cpp:419 Yes, I decided to map all buttons here. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1538 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma Cc

[Differential] [Commented On] D1539: Don't show knetattach in the menu, it's only useful from within a file manager/dialog

broulik added a comment. +1 > It's pretty useful to call it from the app menu That irony confused me. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1539 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Accepted] D1537: show klipper in non-kde desktops

sebas accepted this revision. sebas added a reviewer: sebas. sebas added a comment. This revision is now accepted and ready to land. Makes sense to me. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1537 EMAIL PREFERENCES https://phabricator.k

[Differential] [Accepted] D1537: show klipper in non-kde desktops

graesslin accepted this revision. graesslin added a comment. If we assume someone (me!) thought it's a good idea to have it still shown in Plasma, then the logical thing would be to just remove the line completely. I'll leave this to e.g. VDG to decide whether the entry should be listed o

[Differential] [Request, 2 lines] D1539: Don't show knetattach in the menu, it's only useful from within a file manager/dialog

jriddell created this revision. jriddell added a reviewer: Plasma. jriddell added a subscriber: andreaska. jriddell set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISI

Re: Review Request 127828: Remove .desktop file, it is unused and unhelpful as the app is called by ssh-add not run directly

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127828/#review95161 --- Ship it! Ship It! - Andreas Kainz On Mai 4, 2016, 12:03

Review Request 127828: Remove .desktop file, it is unused and unhelpful as the app is called by ssh-add not run directly

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127828/ --- Review request for Plasma, Andreas Kainz and Jeremy Whiting. Repository:

[Differential] [Commented On] D1538: [libinput] Add a wrapper class Device for a libinput_device

graesslin added a comment. F120309: 20160504_001.jpg Debug console with two "keyboards" exposed. Sorry for phone camera foto - we are lacking proper screenshot support on Wayland. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org

[Differential] [Request, 516 lines] D1538: [libinput] Add a wrapper class Device for a libinput_device

graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The Device class wraps all the information we can get from libinput about the device, like whether it's

[Differential] [Updated] D1537: show klipper in non-kde desktops

jriddell added reviewers: Plasma, graesslin. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1537 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: jriddell, Plasma, graesslin Cc: plasma-devel, sebas __

[Differential] [Updated] D1537: show klipper in non-kde desktops

jriddell updated the summary for this revision. jriddell added a reviewer: andreaska. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1537 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: jriddell, Plasma, graessl

Re: Review Request 127779: use system colors for monochrome icons

> On May 2, 2016, 1:17 p.m., Sebastian Kügler wrote: > > src/kiconloader.cpp, line 869 > > > > > > Where does this one get deleted? > > Marco Martin wrote: > it's a QScopedPointer, so it gets deleted when th

[Differential] [Request, 2 lines] D1537: show klipper in non-kde desktops

jriddell created this revision. jriddell set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Klipper is currently set to onlyShowIn=KDE which makes no

Re: Review Request 127779: use system colors for monochrome icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127779/ --- (Updated May 4, 2016, 9:56 a.m.) Review request for KDE Frameworks and Pl

Re: Review Request 127779: use system colors for monochrome icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127779/ --- (Updated May 4, 2016, 9:51 a.m.) Review request for KDE Frameworks and Pl

Re: Review Request 127779: use system colors for monochrome icons

> On May 2, 2016, 1:17 p.m., Sebastian Kügler wrote: > > src/kiconloader.cpp, line 869 > > > > > > Where does this one get deleted? it's a QScopedPointer, so it gets deleted when the function returns - Marco