----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127826/#review95166 -----------------------------------------------------------
Ship it! Ship It! - Marco Martin On May 3, 2016, 6:28 p.m., Anthony Fieroni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127826/ > ----------------------------------------------------------- > > (Updated May 3, 2016, 6:28 p.m.) > > > Review request for Plasma, David Edmundson and Martin Gräßlin. > > > Repository: plasma-framework > > > Description > ------- > > I'm toking when app is minimized and when hover taskitem in task manager it's > drawed a thumnail icon window. So what is the real problem, some apps, many > as KDE', not provides their icons in window props and NETWinInfo fails to get > them. So in this case we must specified size explicitely to > KWindowSystem::icon. But this is not enough because KWindowSystem::icon makes > incorrect decision to crop icon to 48x48. Explanation the shots: > 1. Current code not specified size explicitely, returned icon is 16x16 > 2. New code wants icon 256x256 but KWindowSystem::icon ignore it and > returning icon 48x48 > 3. New code in 2 frameworks both, it works. > So i makes shots with Dragon but many applications are affected, even KDE' > akregator, ktimer, kalarm and so on, i don't start to comment other toolkit > apps, when we violates KDE'. > > > Diffs > ----- > > src/declarativeimports/core/windowthumbnail.cpp 251aaa4 > > Diff: https://git.reviewboard.kde.org/r/127826/diff/ > > > Testing > ------- > > Depends on https://git.reviewboard.kde.org/r/127809/ > > > File Attachments > ---------------- > > current plasma-framework and current kwindowsystem > > https://git.reviewboard.kde.org/media/uploaded/files/2016/05/03/f81bc88b-fe3b-4f00-b2f2-502effe4c245__Screenshot_20160503_202946.png > new plasma-framework, current kwindowsystem > > https://git.reviewboard.kde.org/media/uploaded/files/2016/05/03/36d7baa3-e875-420f-b2c2-39c2e5d409b9__Screenshot_20160503_203337.png > new plasma-framework, new kwindowsystem > > https://git.reviewboard.kde.org/media/uploaded/files/2016/05/03/857380fe-cdfd-478d-9df2-743f87d4c1ec__Screenshot_20160503_203946.png > > > Thanks, > > Anthony Fieroni > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
