[Differential] [Updated] D1209: do not zoom in highlighted windows

2016-03-23 Thread Martin Gräßlin
graesslin added a comment. This is a relatively new feature, introduced with: commit https://phabricator.kde.org/rKWIN14d1fdf63fc27d908f062695e85fa55dde725b55 Author: Thomas Lübking Date: Mon Sep 14 11:36:56 2015 +0200 desktop grid: zoom hovered window To indicate that

[Differential] [Closed] D1208: [server] Add a workaround for a freeze in QtWayland

2016-03-23 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLAND1934ea48cd1d: [server] Add a workaround for a freeze in QtWayland (authored by graesslin). REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1208?vs=2925&id=

[Differential] [Closed] D1207: [server] Add method to get to the main surface from a sub surface

2016-03-23 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLAND1304585f622d: [server] Add method to get to the main surface from a sub surface (authored by graesslin). REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12

Re: Review Request 127476: [Volume item] Increase / decrease by wheel

2016-03-23 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127476/#review93911 --- Please see https://git.reviewboard.kde.org/r/125088/. I mysel

[Differential] [Accepted] D1207: [server] Add method to get to the main surface from a sub surface

2016-03-23 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH server-sub-surface-main-surface REVISION DETAIL https://phabricator.kde.org/D1207 EMAIL PREFERENCES https://phabricator.kde.org/settings/pan

[Differential] [Accepted] D1208: [server] Add a workaround for a freeze in QtWayland

2016-03-23 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. sebas added a comment. This revision is now accepted and ready to land. Plausible and clean practical solution. :) REPOSITORY rKWAYLAND KWayland BRANCH workaround-qt-freeze REVISION DETAIL https://phabricator.kde.org/D1208 E

[Differential] [Updated, 10 lines] D1209: do not zoom in highlighted windows

2016-03-23 Thread Sebastian Kügler
sebas updated this revision to Diff 2928. sebas added a comment. - these bools are not needed anymore REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1209?vs=2927&id=2928 BRANCH sebas/desktopgridunjar REVISION DETAIL https://phabricator.kde.org/D1209 AF

[Differential] [Request, 8 lines] D1209: do not zoom in highlighted windows

2016-03-23 Thread Sebastian Kügler
sebas created this revision. sebas added a reviewer: graesslin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY Windows under the mouse are (were) highlighted by zooming them slightly. This creates a jarring effect, since the mouse position changes rel

Re: Review Request 127476: [Volume item] Increase / decrease by wheel

2016-03-23 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127476/#review93910 --- Ship it! Ah, sorry, I misread the patch. Ignore my last co

Re: Review Request 127476: [Volume item] Increase / decrease by wheel

2016-03-23 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127476/#review93909 --- It's disabled because the user may accidentally scroll on a t

Re: Review Request 127477: KCM: Add ScrollView to PulseView

2016-03-23 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127477/#review93908 --- Ship it! Ship It! - Sebastian Kügler On March 23, 2016,

Re: Review Request 127476: [Volume item] Increase / decrease by wheel

2016-03-23 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127476/#review93906 --- Ship it! You can find out why a commit was made by using "

Re: Review Request 127477: KCM: Add ScrollView to PulseView

2016-03-23 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127477/#review93905 --- Ship it! Ship It! - David Edmundson On March 23, 2016,

Review Request 127477: KCM: Add ScrollView to PulseView

2016-03-23 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127477/ --- Review request for Plasma. Repository: plasma-pa Description --- T

Re: Review Request 127476: [Volume item] Increase / decrease by wheel

2016-03-23 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127476/ --- (Updated Март 23, 2016, 7:43 след обяд) Review request for Plasma and Har

Review Request 127476: [Volume item] Increase / decrease by wheel

2016-03-23 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127476/ --- Review request for Plasma and Harald Sitter. Repository: plasma-pa Desc

[Differential] [Updated] D1207: [server] Add method to get to the main surface from a sub surface

2016-03-23 Thread Martin Gräßlin
graesslin added a dependent revision: D1208: [server] Add a workaround for a freeze in QtWayland. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D1207 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma Cc: plasm

[Differential] [Updated] D1208: [server] Add a workaround for a freeze in QtWayland

2016-03-23 Thread Martin Gräßlin
graesslin added a dependency: D1207: [server] Add method to get to the main surface from a sub surface. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D1208 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma Cc:

[Differential] [Request, 5 lines] D1208: [server] Add a workaround for a freeze in QtWayland

2016-03-23 Thread Martin Gräßlin
graesslin created this revision. graesslin added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY See: https://bugreports.qt.io/browse/QTBUG-52092 Freeze happens if a sub-surface is rendered to before the main surface is rendere

[Differential] [Request, 68 lines] D1207: [server] Add method to get to the main surface from a sub surface

2016-03-23 Thread Martin Gräßlin
graesslin created this revision. graesslin added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY Recursively go up to the main surface, that is the top level surface which doesn't have a parent. This is useful to know to which

Re: Review Request 127475: Make one more DBus call async

2016-03-23 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127475/#review93902 --- Ship it! Ship It! - Sebastian Kügler On March 23, 2016,

Review Request 127475: Make one more DBus call async

2016-03-23 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127475/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: left-click on libappindicator indicators

2016-03-23 Thread Raman Gupta
On 03/21/2016 03:19 PM, Martin Klapetek wrote: > On Mon, Mar 21, 2016 at 3:10 PM, Raman Gupta > wrote: > > Currently (or at least as of Plasma 5.5.5 on my Fedora 23 machine), > left-click on libappindicator-based indicator's in the plasma system > tray do

[Differential] [Closed] D1193: Drop xcb-shm usage from QPainterWindowPixmap

2016-03-23 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN6e18cae42aca: Drop xcb-shm usage from QPainterWindowPixmap (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1193?vs=2885&id=2921 REVISION DETA

[Differential] [Closed] D1205: Add a surface tree to DebugConsole

2016-03-23 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWINe62dad48a67f: Add a surface tree to DebugConsole (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1205?vs=2917&id=2922 REVISION DETAIL https

[Differential] [Closed] D1191: Reworking subsurface support

2016-03-23 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLAND710f9eaf042f: [tests] Add a sub-surface test application (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1191?vs=2881&id=2920#toc REPOSITORY rKWAYLAND KWayland C

[Differential] [Updated] D1191: Reworking subsurface support

2016-03-23 Thread Martin Gräßlin
graesslin marked 2 inline comments as done. INLINE COMMENTS autotests/client/test_wayland_subsurface.cpp:220 yeah, but that's old code. src/server/surface_interface.cpp:243 yep I also noticed the incorrect wording while adjusting. Decided to leave it to not have too many unrelated changes in

[Differential] [Closed] D1197: Don't create ServerSideDecoration for non-toplevel QWindows

2016-03-23 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAINTEGRATIONef045b3a2d60: Don't create ServerSideDecoration for non-toplevel QWindows (authored by graesslin). REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma CHANGES SINCE

Re: Review Request 126949: Remove Air and Oxygen themes

2016-03-23 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126949/ --- (Updated March 23, 2016, 12:15 p.m.) Status -- This change has been

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 4 - Still Unstable!

2016-03-23 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/4/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 23 Mar 2016 11:55:49 + Build duration: 11 min CHANGE SET Revision 8b677a981204a3669a4a70b0abb0abc3b4e8

Re: Review Request 127365: [plasma-sdk] Make Qt5Test really optional, fix plasmate dependencies

2016-03-23 Thread Andreas Sturmlechner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127365/ --- (Updated March 23, 2016, 5:03 a.m.) Status -- This change has been m

Re: Review Request 127465: fix regression: fix installation path of breeze-dark theme

2016-03-23 Thread Sebastian Kügler
> On March 22, 2016, 5:09 p.m., Harald Sitter wrote: > > Ship It! > > Gustavo Alvarez wrote: > you can commit it? > > greetings I've pushed the patch for you, thanks! It's only in master though, does this regression also apply to the Plasma/5.6 branch? It looks that way, so I've a

Re: Review Request 127465: fix regression: fix installation path of breeze-dark theme

2016-03-23 Thread Gustavo Alvarez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127465/ --- (Updated March 23, 2016, 11:21 a.m.) Status -- This change has been

[Differential] [Accepted] D1205: Add a surface tree to DebugConsole

2016-03-23 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH debug-console-surface-tree REVISION DETAIL https://phabricator.kde.org/D1205 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferen

Re: Review Request 127365: [plasma-sdk] Make Qt5Test really optional, fix plasmate dependencies

2016-03-23 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127365/#review93887 --- Ship it! Ship It! - Marco Martin On March 13, 2016, 4:4

Re: Review Request 124495: Proofread ksysguard docbook for kf5

2016-03-23 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124495/#review93886 --- Ship it! Ship It! - Marco Martin On July 27, 2015, 6:48

Re: Review Request 127466: KCM: Fix icon size in StreamListItem

2016-03-23 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127466/#review93885 --- Ship it! Ship It! - Marco Martin On March 22, 2016, 8:1

Re: Review Request 127467: KCM: Fix showing empty stream icon

2016-03-23 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127467/#review93884 --- src/client.cpp (line 62)

Re: Review Request 127456: [2/2] Fix calendar applet not clearing selection when hiding

2016-03-23 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127456/#review93883 --- Ship it! Ship It! - Marco Martin On March 21, 2016, 9:1

Re: Review Request 127455: [1/2] Fix calendar applet not clearing selection when hiding

2016-03-23 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127455/#review93882 --- Fix it, then Ship it! src/declarativeimports/calendar/qml

[Differential] [Updated] D1205: Add a surface tree to DebugConsole

2016-03-23 Thread Martin Gräßlin
graesslin added a dependency: D1191: Reworking subsurface support. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1205 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma Cc: plasma-devel

[Differential] [Updated] D1191: Reworking subsurface support

2016-03-23 Thread Martin Gräßlin
graesslin added a dependent revision: D1205: Add a surface tree to DebugConsole. REPOSITORY rKWAYLAND KWayland BRANCH subsurface-fixes REVISION DETAIL https://phabricator.kde.org/D1191 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma,

[Differential] [Commented On] D1205: Add a surface tree to DebugConsole

2016-03-23 Thread Martin Gräßlin
graesslin added a comment. F99262: Spectacle.Nb1441.png New tree in action showing the sub-surface tree of Systemsettings in Desktop Effects KCM. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1205 EMAIL PREFERENCES https:/

[Differential] [Request, 267 lines] D1205: Add a surface tree to DebugConsole

2016-03-23 Thread Martin Gräßlin
graesslin created this revision. graesslin added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY While developing support for sub-surfaces it became obvious that there is a need for visualizing the tree of sub-surfaces. The sur