-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127476/#review93906
-----------------------------------------------------------
Ship it!
You can find out why a commit was made by using "git blame" to find the commit.
It seems the mouse area was added so that:
" Also block wheel events on sliders in applet.
Without this, the value of slider gets changed but it won't change
the actual volume.
"
However, I think your approach works too, you're still blocking the wheel event
from reaching the slider.
Seems to work.
- David Edmundson
On March 23, 2016, 5:43 p.m., Anthony Fieroni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127476/
> -----------------------------------------------------------
>
> (Updated March 23, 2016, 5:43 p.m.)
>
>
> Review request for Plasma and Harald Sitter.
>
>
> Repository: plasma-pa
>
>
> Description
> -------
>
> I don't know why it's disabled, it's pretty handy
>
>
> Diffs
> -----
>
> applet/contents/ui/ListItemBase.qml 2e31eeb
>
> Diff: https://git.reviewboard.kde.org/r/127476/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anthony Fieroni
>
>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
