Re: RFC: Put notifications in sidepanel like widget explorer

2016-02-17 Thread Thomas Pfeiffer
On Montag, 26. Oktober 2015 09:57:37 CET Sebastian Kügler wrote: > On Tuesday, October 20, 2015 15:54:01 Martin Klapetek wrote: > > today I was thinking a bit about our notification system. I believe > > that the constraints the tiny popup give us are just too limiting. > > Currently it fits about

Re: Review Request 127102: Use fixed width for digital clock applet

2016-02-17 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127102/#review92514 --- applets/digital-clock/package/contents/ui/DigitalClock.qml (

Re: Review Request 127102: Use fixed width for digital clock applet

2016-02-17 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127102/#review92513 --- Is this needed after: https://git.reviewboard.kde.org/r/12707

Re: Review Request 127103: Add autotests for IconItem

2016-02-17 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127103/#review92507 --- Ship it! Ship It! - David Edmundson On Feb. 17, 2016, 5

Re: Review Request 126653: Disable animation of icons in plasma tooltips

2016-02-17 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126653/ --- (Updated Feb. 17, 2016, 6:42 p.m.) Status -- This change has been ma

Review Request 127103: Add autotests for IconItem

2016-02-17 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127103/ --- Review request for Plasma. Repository: plasma-framework Description ---

Review Request 127102: Use fixed width for digital clock applet

2016-02-17 Thread Daniel Faust
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127102/ --- Review request for kde-workspace and Plasma. Repository: plasma-workspace

Re: Review Request 126653: Disable animation of icons in plasma tooltips

2016-02-17 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126653/#review92501 --- Ship it! - Marco Martin On Feb. 17, 2016, 3:27 p.m., Dav

Re: Review Request 126653: Disable animation of icons in plasma tooltips

2016-02-17 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126653/ --- (Updated Feb. 17, 2016, 3:27 p.m.) Review request for Plasma. Changes -

Re: Review Request 122859: Don't animate from previous pixmap when IconItem has been invisible

2016-02-17 Thread Marco Martin
> On Dec. 28, 2015, 9:50 a.m., David Rosca wrote: > > What about just adding a property to disable animation (as Eike suggested) > > and disable it for icon in tooltips? > > > > Currently, only the icon is animated when the tooltip contents change, text > > (tooltip title, subtitle) is changed

Re: Review Request 122859: Don't animate from previous pixmap when IconItem has been invisible

2016-02-17 Thread David Rosca
> On Dec. 28, 2015, 9:50 a.m., David Rosca wrote: > > What about just adding a property to disable animation (as Eike suggested) > > and disable it for icon in tooltips? > > > > Currently, only the icon is animated when the tooltip contents change, text > > (tooltip title, subtitle) is changed

Re: Review Request 122859: Don't animate from previous pixmap when IconItem has been invisible

2016-02-17 Thread Marco Martin
> On Dec. 28, 2015, 9:50 a.m., David Rosca wrote: > > What about just adding a property to disable animation (as Eike suggested) > > and disable it for icon in tooltips? > > > > Currently, only the icon is animated when the tooltip contents change, text > > (tooltip title, subtitle) is changed

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

2016-02-17 Thread Marco Martin
> On Feb. 17, 2016, 2:06 p.m., Thomas Lübking wrote: > > effects/morphingpopups/package/contents/code/morphingpopups.js, line 27 > > > > > > Hold it! ;-) > > > > This is still error prone. Just keep the a

Re: Review Request 122859: Don't animate from previous pixmap when IconItem has been invisible

2016-02-17 Thread David Rosca
> On Dec. 28, 2015, 12:50 a.m., David Edmundson wrote: > > src/declarativeimports/core/iconitem.cpp, line 405 > > > > > > huh? that just reloads the current image whenever visibility gets > > toggled. > >

Re: Review Request 122859: Don't animate from previous pixmap when IconItem has been invisible

2016-02-17 Thread Kai Uwe Broulik
> On Dez. 28, 2015, 12:50 vorm., David Edmundson wrote: > > src/declarativeimports/core/iconitem.cpp, line 405 > > > > > > huh? that just reloads the current image whenever visibility gets > > toggled. > >

Re: Review Request 122859: Don't animate from previous pixmap when IconItem has been invisible

2016-02-17 Thread David Rosca
> On Dec. 28, 2015, 12:50 a.m., David Edmundson wrote: > > src/declarativeimports/core/iconitem.cpp, line 405 > > > > > > huh? that just reloads the current image whenever visibility gets > > toggled. > >

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

2016-02-17 Thread Thomas Lübking
> On Feb. 17, 2016, 2:06 p.m., Thomas Lübking wrote: > > effects/morphingpopups/package/contents/code/morphingpopups.js, line 27 > > > > > > Hold it! ;-) > > > > This is still error prone. Just keep the a

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

2016-02-17 Thread Marco Martin
> On Feb. 17, 2016, 2:06 p.m., Thomas Lübking wrote: > > effects/morphingpopups/package/contents/code/morphingpopups.js, line 27 > > > > > > Hold it! ;-) > > > > This is still error prone. Just keep the a

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

2016-02-17 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126968/#review92489 --- effects/morphingpopups/package/contents/code/morphingpopups.

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

2016-02-17 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126968/ --- (Updated Feb. 17, 2016, 2:03 p.m.) Status -- This change has been ma

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

2016-02-17 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126968/#review92488 --- Ship it! Ship It! - Martin Gräßlin On Feb. 17, 2016, 11

Re: Review Request 127085: Make the desfault theme follow system colors

2016-02-17 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127085/#review92485 --- printprinze = print - Andreas Kainz On Feb. 17, 2016, 11:0

Re: Review Request 127085: Make the desfault theme follow system colors

2016-02-17 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127085/ --- (Updated Feb. 17, 2016, 11:08 a.m.) Status -- This change has been m

Re: Review Request 127085: Make the desfault theme follow system colors

2016-02-17 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127085/#review92484 --- the Prinz color look different is this only differet very nic

Re: Review Request 127085: Make the desfault theme follow system colors

2016-02-17 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127085/ --- (Updated Feb. 17, 2016, 10:57 a.m.) Review request for Plasma and Jens Re

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

2016-02-17 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126968/ --- (Updated Feb. 17, 2016, 10:12 a.m.) Review request for kwin and Plasma.