> On Feb. 17, 2016, 2:06 p.m., Thomas Lübking wrote: > > effects/morphingpopups/package/contents/code/morphingpopups.js, line 27 > > <https://git.reviewboard.kde.org/r/126968/diff/5/?file=444498#file444498line27> > > > > Hold it! ;-) > > > > This is still error prone. Just keep the animation variables, try to > > retarget and if that fails add a new animation. > > > > animationEnded means that *some* animation has ended, ie. you clean > > move also when fade ended. Once somebody decides to alter durations, you'll > > run into conflicts. > > Marco Martin wrote: > ok, sorry we didn't get that exactly. > I'll do a new review request on top of current master, ok?
Yes, of course. After my yesterdays commit mess, I'm not in any position to criticize anybody on early commits =) - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126968/#review92489 ----------------------------------------------------------- On Feb. 17, 2016, 2:03 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126968/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2016, 2:03 p.m.) > > > Review request for kwin and Plasma. > > > Bugs: 347863 and 349669 > https://bugs.kde.org/show_bug.cgi?id=347863 > https://bugs.kde.org/show_bug.cgi?id=349669 > > > Repository: kwin > > > Description > ------- > > this effect, derived from the Maximize one, will take the place of the manual > window position animation that Plasma tooltip are using. > this should cause less problems as animationg positions on X is very error > prone, plus it's less jarring when the tooltip sizes changes too, since that > gets animated as well (behavior similar to Window7 taskbar tooltips) > look: > https://www.youtube.com/watch?v=sxE23ZgkkpU > slow motion: > https://www.youtube.com/watch?v=jDByfncO568 > > replaces https://git.reviewboard.kde.org/r/126870 > > > Diffs > ----- > > effects/CMakeLists.txt e3beebf > effects/morphingpopups/CMakeLists.txt PRE-CREATION > effects/morphingpopups/package/CMakeLists.txt PRE-CREATION > effects/morphingpopups/package/contents/code/morphingpopups.js PRE-CREATION > effects/morphingpopups/package/metadata.desktop PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/126968/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
